@jupyterlab/ui-components - npm Package Compare versions

Comparing version 4.0.0-rc.0 to 4.0.0-rc.1

lib/components/windowedlist.d.ts

@@ -192,2 +192,10 @@ import { IChangedArgs } from '@jupyterlab/coreutils';
     /**
+     * Whether the parent is hidden or not.
+     *
+     * This should be set externally if a container is hidden to
+     * stop updating the widget size when hidden.
+     */
+    get isParentHidden(): boolean;
+    set isParentHidden(v: boolean);
+    /**
      * Widget layout
@@ -267,2 +275,3 @@ */
     private _addListeners;
+    private _applyNoWindowingStyles;
     private _removeListeners;
@@ -274,3 +283,5 @@ private _update;
     private _innerElement;
+    private _isParentHidden;
     private _isScrolling;
+    private _needsUpdate;
     private _windowElement;
@@ -277,0 +288,0 @@ private _resetScrollToItemTimeout;

lib/components/windowedlist.js

@@ -517,2 +517,3 @@ /*
         super({ node });
+        this._needsUpdate = false;
         super.layout = (_a = options.layout) !== null && _a !== void 0 ? _a : new WindowedLayout();
@@ -530,2 +531,14 @@ this._viewModel = options.model;
     /**
+     * Whether the parent is hidden or not.
+     *
+     * This should be set externally if a container is hidden to
+     * stop updating the widget size when hidden.
+     */
+    get isParentHidden() {
+        return this._isParentHidden;
+    }
+    set isParentHidden(v) {
+        this._isParentHidden = v;
+    }
+    /**
      * Widget layout
@@ -628,2 +641,5 @@ */
         }
+        else {
+            this._applyNoWindowingStyles();
+        }
         this.viewModel.height = this.node.getBoundingClientRect().height;
@@ -703,7 +719,15 @@ }
             if (this._scrollRepaint === null) {
+                this._needsUpdate = false;
                 this._scrollRepaint = window.requestAnimationFrame(() => {
                     this._scrollRepaint = null;
                     this._update();
+                    if (this._needsUpdate) {
+                        this.update();
+                    }
                 });
             }
+            else {
+                // Force re rendering if some changes happen during rendering.
+                this._needsUpdate = true;
+            }
         }
@@ -725,2 +749,6 @@ else {
     }
+    _applyNoWindowingStyles() {
+        this._windowElement.style.position = 'relative';
+        this._windowElement.style.top = '0px';
+    }
     _removeListeners() {
@@ -731,5 +759,3 @@ var _a;
         this._resizeObserver = null;
-        this._innerElement.style.height = '100%';
-        this._windowElement.style.position = 'relative';
-        this._windowElement.style.top = '0px';
+        this._applyNoWindowingStyles();
     }
@@ -808,2 +834,5 @@ _update() {
         this._resetScrollToItem();
+        if (this.isHidden || this.isParentHidden) {
+            return;
+        }
         const newSizes = [];
@@ -829,5 +858,3 @@ for (let entry of entries) {
             }
-            else {
-                this.update();
-            }
+            this.update();
         }
@@ -834,0 +861,0 @@ }

package.json

 {
   "name": "@jupyterlab/ui-components",
-  "version": "4.0.0-rc.0",
+  "version": "4.0.0-rc.1",
   "description": "JupyterLab - UI components written in React",
@@ -44,6 +44,6 @@ "homepage": "https://github.com/jupyterlab/jupyterlab",
   "dependencies": {
-    "@jupyterlab/coreutils": "^6.0.0-rc.0",
-    "@jupyterlab/observables": "^5.0.0-rc.0",
-    "@jupyterlab/rendermime-interfaces": "^3.8.0-rc.0",
-    "@jupyterlab/translation": "^4.0.0-rc.0",
+    "@jupyterlab/coreutils": "^6.0.0-rc.1",
+    "@jupyterlab/observables": "^5.0.0-rc.1",
+    "@jupyterlab/rendermime-interfaces": "^3.8.0-rc.1",
+    "@jupyterlab/translation": "^4.0.0-rc.1",
     "@lumino/algorithm": "^2.0.0",
@@ -66,3 +66,3 @@ "@lumino/commands": "^2.1.1",
   "devDependencies": {
-    "@jupyterlab/testing": "^4.0.0-rc.0",
+    "@jupyterlab/testing": "^4.0.0-rc.1",
     "@types/jest": "^29.2.0",
@@ -69,0 +69,0 @@ "@types/react": "^18.0.26",

src/components/windowedlist.ts

@@ -697,2 +697,15 @@ /*
   /**
+   * Whether the parent is hidden or not.
+   *
+   * This should be set externally if a container is hidden to
+   * stop updating the widget size when hidden.
+   */
+  get isParentHidden(): boolean {
+    return this._isParentHidden;
+  }
+  set isParentHidden(v: boolean) {
+    this._isParentHidden = v;
+  }
+
+  /**
    * Widget layout
@@ -819,2 +832,4 @@ */
       this._addListeners();
+    } else {
+      this._applyNoWindowingStyles();
     }
@@ -910,6 +925,13 @@ this.viewModel.height = this.node.getBoundingClientRect().height;
       if (this._scrollRepaint === null) {
+        this._needsUpdate = false;
         this._scrollRepaint = window.requestAnimationFrame(() => {
           this._scrollRepaint = null;
           this._update();
+          if (this._needsUpdate) {
+            this.update();
+          }
         });
+      } else {
+        // Force re rendering if some changes happen during rendering.
+        this._needsUpdate = true;
       }
@@ -937,2 +959,7 @@ } else {
 
+  private _applyNoWindowingStyles() {
+    this._windowElement.style.position = 'relative';
+    this._windowElement.style.top = '0px';
+  }
+
   private _removeListeners() {
@@ -942,5 +969,3 @@ this.node.removeEventListener('scroll', this);
     this._resizeObserver = null;
-    this._innerElement.style.height = '100%';
-    this._windowElement.style.position = 'relative';
-    this._windowElement.style.top = '0px';
+    this._applyNoWindowingStyles();
   }
@@ -1037,2 +1062,6 @@
 
+    if (this.isHidden || this.isParentHidden) {
+      return;
+    }
+
     const newSizes: { index: number; size: number }[] = [];
@@ -1061,5 +1090,5 @@ for (let entry of entries) {
         });
-      } else {
-        this.update();
       }
+
+      this.update();
     }
@@ -1086,3 +1115,5 @@ }
   private _innerElement: HTMLDivElement;
+  private _isParentHidden: boolean;
   private _isScrolling: PromiseDelegate<void> | null;
+  private _needsUpdate = false;
   private _windowElement: HTMLDivElement;
@@ -1089,0 +1120,0 @@ private _resetScrollToItemTimeout: number | null;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

829194

increased by0.29%

Lines of code

17871

increased by0.38%

Dependency changes

• Updated@jupyterlab/coreutils@^6.0.0-rc.1

• Updated@jupyterlab/observables@^5.0.0-rc.1

• Updated@jupyterlab/rendermime-interfaces@^3.8.0-rc.1

• Updated@jupyterlab/translation@^4.0.0-rc.1