@khanacademy/wonder-blocks-button - npm Package Compare versions

Comparing version 2.3.4 to 2.4.0

components/button.js

@@ -6,3 +6,3 @@ // @flow
 import {getClickableBehavior} from "@khanacademy/wonder-blocks-core";
-import type {StyleType} from "@khanacademy/wonder-blocks-core";
+import type {AriaProps, StyleType} from "@khanacademy/wonder-blocks-core";
 import type {IconAsset} from "@khanacademy/wonder-blocks-icon";
@@ -13,2 +13,9 @@ import ButtonCore from "./button-core.js";
     /**
+     * aria-label should be used when `spinner={true}` to let people using screen
+     * readers that the action taken by clicking the button will take some
+     * time to complete.
+     */
+    ...AriaProps,
+
+    /**
      * Text to appear on the button.
@@ -33,9 +40,2 @@ */
     /**
-     * This should be use when `spinner={true}` to let people using screen
-     * readers that the action taken by clicking the button will take some
-     * time to complete.
-     */
-    "aria-label": string,
-
-    /**
      * The color of the button, either blue or red.
@@ -164,3 +164,2 @@ */
         spinner: false,
-        "aria-label": "",
     };
@@ -167,0 +166,0 @@

dist/es/index.js

@@ -503,4 +503,3 @@ import { createElement, Component, Fragment } from 'react';
   disabled: false,
-  spinner: false,
-  "aria-label": ""
+  spinner: false
 });
@@ -507,0 +506,0 @@

dist/index.js

@@ -595,4 +595,3 @@ module.exports =
   disabled: false,
-  spinner: false,
-  "aria-label": ""
+  spinner: false
 });
@@ -599,0 +598,0 @@

package.json

 {
   "name": "@khanacademy/wonder-blocks-button",
-  "version": "2.3.4",
+  "version": "2.4.0",
   "design": "v1",
@@ -18,8 +18,8 @@ "publishConfig": {
   "dependencies": {
-    "@khanacademy/wonder-blocks-color": "^1.1.3",
-    "@khanacademy/wonder-blocks-core": "^2.2.1",
-    "@khanacademy/wonder-blocks-icon": "^1.1.3",
-    "@khanacademy/wonder-blocks-progress-spinner": "^1.1.3",
-    "@khanacademy/wonder-blocks-spacing": "^2.1.3",
-    "@khanacademy/wonder-blocks-typography": "^1.1.3"
+    "@khanacademy/wonder-blocks-color": "^1.1.4",
+    "@khanacademy/wonder-blocks-core": "^2.3.0",
+    "@khanacademy/wonder-blocks-icon": "^1.2.0",
+    "@khanacademy/wonder-blocks-progress-spinner": "^1.1.4",
+    "@khanacademy/wonder-blocks-spacing": "^2.1.4",
+    "@khanacademy/wonder-blocks-typography": "^1.1.4"
   },
@@ -26,0 +26,0 @@ "peerDependencies": {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

377473

decreased by-0.19%

Lines of code

2210

decreased by-0.14%

Dependency changes

• Updated@khanacademy/wonder-blocks-color@^1.1.4

• Updated@khanacademy/wonder-blocks-core@^2.3.0

• Updated@khanacademy/wonder-blocks-icon@^1.2.0

• Updated@khanacademy/wonder-blocks-progress-spinner@^1.1.4

• Updated@khanacademy/wonder-blocks-spacing@^2.1.4

• Updated@khanacademy/wonder-blocks-typography@^1.1.4