@khanacademy/wonder-blocks-icon-button - npm Package Compare versions

Comparing version 3.1.4 to 3.1.5

components/icon-button-core.js

@@ -64,3 +64,2 @@ // @flow
             skipClientNav,
-            "aria-label": ariaLabel,
             color,
@@ -102,5 +101,2 @@ disabled,
         const commonProps = {
-            // TODO(kevinb): figure out a better way of forward ARIA props
-            "aria-disabled": disabled ? "true" : undefined,
-            "aria-label": ariaLabel,
             "data-test-id": testId,
@@ -154,2 +150,6 @@ style: [defaultStyle, style],
         touchAction: "manipulation",
+        ":focus": {
+            // Mobile: Removes a blue highlight style shown when the user clicks a button
+            WebkitTapHighlightColor: "rgba(0,0,0,0)",
+        },
     },
@@ -156,0 +156,0 @@ disabled: {

components/icon-button.js

@@ -11,3 +11,3 @@ // @flow
 export type SharedProps = {|
-    ...AriaProps,
+    ...$Rest<AriaProps, {|"aria-disabled": "true" | "false" | void|}>,
 
@@ -14,0 +14,0 @@ /**

dist/es/index.js

@@ -186,3 +186,2 @@ import React from 'react';
           skipClientNav = _this$props.skipClientNav,
-          ariaLabel = _this$props["aria-label"],
           color = _this$props.color,
@@ -199,3 +198,3 @@ disabled = _this$props.disabled,
           testId = _this$props.testId,
-          handlers = _objectWithoutProperties(_this$props, ["skipClientNav", "aria-label", "color", "disabled", "focused", "hovered", "href", "icon", "kind", "light", "pressed", "style", "testId"]);
+          handlers = _objectWithoutProperties(_this$props, ["skipClientNav", "color", "disabled", "focused", "hovered", "href", "icon", "kind", "light", "pressed", "style", "testId"]);
 
@@ -215,5 +214,2 @@ var router = this.context.router;
       var commonProps = _objectSpread({
-        // TODO(kevinb): figure out a better way of forward ARIA props
-        "aria-disabled": disabled ? "true" : undefined,
-        "aria-label": ariaLabel,
         "data-test-id": testId,
@@ -263,3 +259,7 @@ style: [defaultStyle, style]
     // "double-tap to zoom" shouldn't be used on this element.
-    touchAction: "manipulation"
+    touchAction: "manipulation",
+    ":focus": {
+      // Mobile: Removes a blue highlight style shown when the user clicks a button
+      WebkitTapHighlightColor: "rgba(0,0,0,0)"
+    }
   },
@@ -266,0 +266,0 @@ disabled: {

dist/index.js

@@ -218,3 +218,2 @@ module.exports =
           skipClientNav = _this$props.skipClientNav,
-          ariaLabel = _this$props["aria-label"],
           color = _this$props.color,
@@ -231,3 +230,3 @@ disabled = _this$props.disabled,
           testId = _this$props.testId,
-          handlers = _objectWithoutProperties(_this$props, ["skipClientNav", "aria-label", "color", "disabled", "focused", "hovered", "href", "icon", "kind", "light", "pressed", "style", "testId"]);
+          handlers = _objectWithoutProperties(_this$props, ["skipClientNav", "color", "disabled", "focused", "hovered", "href", "icon", "kind", "light", "pressed", "style", "testId"]);
 
@@ -247,5 +246,2 @@ var router = this.context.router;
       var commonProps = _objectSpread({
-        // TODO(kevinb): figure out a better way of forward ARIA props
-        "aria-disabled": disabled ? "true" : undefined,
-        "aria-label": ariaLabel,
         "data-test-id": testId,
@@ -297,3 +293,7 @@ style: [defaultStyle, style]
     // "double-tap to zoom" shouldn't be used on this element.
-    touchAction: "manipulation"
+    touchAction: "manipulation",
+    ":focus": {
+      // Mobile: Removes a blue highlight style shown when the user clicks a button
+      WebkitTapHighlightColor: "rgba(0,0,0,0)"
+    }
   },
@@ -300,0 +300,0 @@ disabled: {

package.json

 {
   "name": "@khanacademy/wonder-blocks-icon-button",
-  "version": "3.1.4",
+  "version": "3.1.5",
   "design": "v1",
@@ -18,5 +18,5 @@ "publishConfig": {
   "dependencies": {
-    "@khanacademy/wonder-blocks-color": "^1.1.4",
-    "@khanacademy/wonder-blocks-core": "^2.3.0",
-    "@khanacademy/wonder-blocks-icon": "^1.2.0"
+    "@khanacademy/wonder-blocks-color": "^1.1.5",
+    "@khanacademy/wonder-blocks-core": "^2.3.1",
+    "@khanacademy/wonder-blocks-icon": "^1.2.1"
   },
@@ -23,0 +23,0 @@ "peerDependencies": {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

179539

increased by3.17%

Dependency changes

• Updated@khanacademy/wonder-blocks-color@^1.1.5

• Updated@khanacademy/wonder-blocks-core@^2.3.1

• Updated@khanacademy/wonder-blocks-icon@^1.2.1