@ledgerhq/hw-transport-web-ble - npm Package Compare versions

Comparing version 6.27.19 to 6.27.20-next.0

CHANGELOG.md

 # @ledgerhq/hw-transport-web-ble
 
+## 6.27.20-next.0
+
+### Patch Changes
+
+- Updated dependencies [[`9e2d32aec4`](https://github.com/LedgerHQ/ledger-live/commit/9e2d32aec4ebd8774880f94e3ef0e805ebb172ac), [`7968dfc551`](https://github.com/LedgerHQ/ledger-live/commit/7968dfc551acca00b7fabf00a726758d74be33de), [`6b7fc5d071`](https://github.com/LedgerHQ/ledger-live/commit/6b7fc5d0711a83ed2fcacacd02795862a4a3bf1d), [`9e2d32aec4`](https://github.com/LedgerHQ/ledger-live/commit/9e2d32aec4ebd8774880f94e3ef0e805ebb172ac), [`4d6fa0772e`](https://github.com/LedgerHQ/ledger-live/commit/4d6fa0772e19cdbd4b432fafa43621c42e2a5fdd)]:
+  - @ledgerhq/logs@6.11.0-next.0
+  - @ledgerhq/hw-transport@6.29.0-next.0
+  - @ledgerhq/errors@6.15.0-next.0
+  - @ledgerhq/devices@8.0.8-next.0
+
 ## 6.27.19
@@ -4,0 +14,0 @@

lib-es/TransportWebBLE.js

@@ -18,3 +18,3 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
 import { log } from "@ledgerhq/logs";
-import { Observable, defer, merge, from } from "rxjs";
+import { Observable, defer, merge, from, firstValueFrom } from "rxjs";
 import { share, ignoreElements, first, map, tap } from "rxjs/operators";
@@ -194,3 +194,3 @@ import { monitorCharacteristic } from "./monitorCharacteristic";
                     mtu =
-                        (yield merge(this.notifyObservable.pipe(first(buffer => buffer.readUInt8(0) === 0x08), map(buffer => buffer.readUInt8(5))), defer(() => from(this.write(Buffer.from([0x08, 0, 0, 0, 0])))).pipe(ignoreElements())).toPromise()) + 3;
+                        (yield firstValueFrom(merge(this.notifyObservable.pipe(first(buffer => buffer.readUInt8(0) === 0x08), map(buffer => buffer.readUInt8(5))), defer(() => from(this.write(Buffer.from([0x08, 0, 0, 0, 0])))).pipe(ignoreElements())))) + 3;
                 }
@@ -222,3 +222,3 @@ catch (e) {
                     log("apdu", `=> ${msgIn}`);
-                    const data = yield merge(this.notifyObservable.pipe(receiveAPDU), sendAPDU(this.write, apdu, this.mtuSize)).toPromise();
+                    const data = yield firstValueFrom(merge(this.notifyObservable.pipe(receiveAPDU), sendAPDU(this.write, apdu, this.mtuSize)));
                     const msgOut = data.toString("hex");
@@ -225,0 +225,0 @@ log("apdu", `<= ${msgOut}`);

lib/TransportWebBLE.js

@@ -198,3 +198,3 @@ "use strict";
                     mtu =
-                        (yield (0, rxjs_1.merge)(this.notifyObservable.pipe((0, operators_1.first)(buffer => buffer.readUInt8(0) === 0x08), (0, operators_1.map)(buffer => buffer.readUInt8(5))), (0, rxjs_1.defer)(() => (0, rxjs_1.from)(this.write(Buffer.from([0x08, 0, 0, 0, 0])))).pipe((0, operators_1.ignoreElements)())).toPromise()) + 3;
+                        (yield (0, rxjs_1.firstValueFrom)((0, rxjs_1.merge)(this.notifyObservable.pipe((0, operators_1.first)(buffer => buffer.readUInt8(0) === 0x08), (0, operators_1.map)(buffer => buffer.readUInt8(5))), (0, rxjs_1.defer)(() => (0, rxjs_1.from)(this.write(Buffer.from([0x08, 0, 0, 0, 0])))).pipe((0, operators_1.ignoreElements)())))) + 3;
                 }
@@ -226,3 +226,3 @@ catch (e) {
                     (0, logs_1.log)("apdu", `=> ${msgIn}`);
-                    const data = yield (0, rxjs_1.merge)(this.notifyObservable.pipe(receiveAPDU_1.receiveAPDU), (0, sendAPDU_1.sendAPDU)(this.write, apdu, this.mtuSize)).toPromise();
+                    const data = yield (0, rxjs_1.firstValueFrom)((0, rxjs_1.merge)(this.notifyObservable.pipe(receiveAPDU_1.receiveAPDU), (0, sendAPDU_1.sendAPDU)(this.write, apdu, this.mtuSize)));
                     const msgOut = data.toString("hex");
@@ -229,0 +229,0 @@ (0, logs_1.log)("apdu", `<= ${msgOut}`);

package.json

 {
   "name": "@ledgerhq/hw-transport-web-ble",
-  "version": "6.27.19",
+  "version": "6.27.20-next.0",
   "description": "Ledger Hardware Wallet Web Bluetooth implementation of the communication layer",
@@ -30,7 +30,7 @@ "keywords": [
   "dependencies": {
-    "rxjs": "6",
-    "@ledgerhq/devices": "^8.0.7",
-    "@ledgerhq/errors": "^6.14.0",
-    "@ledgerhq/hw-transport": "^6.28.8",
-    "@ledgerhq/logs": "^6.10.1"
+    "rxjs": "^7.8.1",
+    "@ledgerhq/devices": "^8.0.8-next.0",
+    "@ledgerhq/errors": "^6.15.0-next.0",
+    "@ledgerhq/hw-transport": "^6.29.0-next.0",
+    "@ledgerhq/logs": "^6.11.0-next.0"
   },
@@ -40,3 +40,3 @@ "devDependencies": {
     "@types/node": "^18.15.3",
-    "@types/web-bluetooth": "^0.0.17",
+    "@types/web-bluetooth": "^0.0.19",
     "documentation": "13.2.5",
@@ -57,4 +57,5 @@ "jest": "^28.1.1",
     "lint:fix": "pnpm lint --fix",
-    "test": "jest"
+    "test": "jest",
+    "unimported": "unimported"
   }
 }

src/TransportWebBLE.ts

@@ -9,3 +9,3 @@ /* eslint-disable prefer-template */
 import { log } from "@ledgerhq/logs";
-import { Observable, Subscription, defer, merge, from } from "rxjs";
+import { Observable, Subscription, defer, merge, from, firstValueFrom } from "rxjs";
 import { share, ignoreElements, first, map, tap } from "rxjs/operators";
@@ -246,9 +246,11 @@ import type { Device, Characteristic } from "./types";
         mtu =
-          (await merge(
-            this.notifyObservable.pipe(
-              first(buffer => buffer.readUInt8(0) === 0x08),
-              map(buffer => buffer.readUInt8(5)),
+          (await firstValueFrom(
+            merge(
+              this.notifyObservable.pipe(
+                first(buffer => buffer.readUInt8(0) === 0x08),
+                map(buffer => buffer.readUInt8(5)),
+              ),
+              defer(() => from(this.write(Buffer.from([0x08, 0, 0, 0, 0])))).pipe(ignoreElements()),
             ),
-            defer(() => from(this.write(Buffer.from([0x08, 0, 0, 0, 0])))).pipe(ignoreElements()),
-          ).toPromise()) + 3;
+          )) + 3;
       } catch (e) {
@@ -280,6 +282,5 @@ log("ble-error", "inferMTU got " + String(e));
         log("apdu", `=> ${msgIn}`);
-        const data = await merge(
-          this.notifyObservable.pipe(receiveAPDU),
-          sendAPDU(this.write, apdu, this.mtuSize),
-        ).toPromise();
+        const data = await firstValueFrom(
+          merge(this.notifyObservable.pipe(receiveAPDU), sendAPDU(this.write, apdu, this.mtuSize)),
+        );
         const msgOut = data.toString("hex");
@@ -286,0 +287,0 @@ log("apdu", `<= ${msgOut}`);

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

81133

increased by1.22%

Number of package files

34

increased by3.03%

Lines of code

1010

increased by0.4%

Worsened metrics

Number of low quality alerts

1

increased byInfinity%

Dependency changes

• - Removedrxjs@6.6.7(transitive)

• - Removedtslib@1.14.1(transitive)

• Updated@ledgerhq/devices@^8.0.8-next.0

• Updated@ledgerhq/errors@^6.15.0-next.0

• Updated@ledgerhq/hw-transport@^6.29.0-next.0

• Updated@ledgerhq/logs@^6.11.0-next.0

• Updatedrxjs@^7.8.1