@ledgerhq/hw-transport - npm Package Compare versions

Comparing version 1.1.0-beta.9f0d7158 to 1.1.0-beta.b03dab45

lib/Transport.js

@@ -81,3 +81,3 @@ "use strict";
    * events can come over times, for instance if you plug a USB device after listen() or a bluetooth device become discoverable
-   * @param cb is a function called each time a descriptor is found
+   * @param observer is an object with a onNext, onError and onDone function (compatible with observer pattern)
    * @return a Subscription object on which you can `.unsubscribe()` to stop discovering descriptors.
@@ -84,0 +84,0 @@ * @example

package.json

 {
   "name": "@ledgerhq/hw-transport",
-  "version": "1.1.0-beta.9f0d7158",
+  "version": "1.1.0-beta.b03dab45",
   "description": "Ledger Hardware Wallet common interface of the communication layer",
@@ -5,0 +5,0 @@ "keywords": [

src/Transport.js

@@ -6,3 +6,8 @@ //@flow
 
-type Subscription = { unsubscribe: () => void };
+export type Subscription = { unsubscribe: () => void };
+export type Observer<T> = {
+  onNext: (descriptor: T) => void,
+  onError: (e: ?Error) => void,
+  onDone: () => void
+};
 
@@ -29,3 +34,3 @@ /**
    * events can come over times, for instance if you plug a USB device after listen() or a bluetooth device become discoverable
-   * @param cb is a function called each time a descriptor is found
+   * @param observer is an object with a onNext, onError and onDone function (compatible with observer pattern)
    * @return a Subscription object on which you can `.unsubscribe()` to stop discovering descriptors.
@@ -39,7 +44,3 @@ * @example
    */
-  static +discover: (
-    onNext: (descriptor: Descriptor) => void,
-    onError?: (e: Error) => void,
-    onDone?: () => void
-  ) => Subscription;
+  static +discover: (observer: Observer<Descriptor>) => Subscription;
 
@@ -46,0 +47,0 @@ /**

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

36562

increased by0.89%

Lines of code

632

increased by0.16%

No dependency changes