@ledgerhq/hw-transport - npm Package Compare versions

Comparing version 2.2.0 to 3.0.0

lib/Transport.js

@@ -129,2 +129,3 @@ "use strict";
     this.debug = false;
+    this.exchangeTimeout = 30000;
     this._events = new _events3.default();
@@ -294,2 +295,12 @@
     /**
+     * Set a timeout (in milliseconds) for the exchange call. Only some transport might implement it. (e.g. U2F)
+     */
+
+  }, {
+    key: "setExchangeTimeout",
+    value: function setExchangeTimeout(exchangeTimeout) {
+      this.exchangeTimeout = exchangeTimeout;
+    }
+
+    /**
      * wrapper on top of exchange to simplify work of the implementation.
@@ -319,3 +330,3 @@ * @param cla
 
-      var timeout = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : 5000;
+      var openTimeout = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : 5000;
 
@@ -327,6 +338,6 @@ if (arguments.length > 1) {
         var found = false;
-        var timeoutId = setTimeout(function () {
+        var openTimeoutId = setTimeout(function () {
           sub.unsubscribe();
-          reject(new TransportError("Transport timeout", "timeout"));
-        }, timeout);
+          reject(new TransportError("Transport openTimeout", "OpenTimeout"));
+        }, openTimeout);
         var sub = _this2.listen({
@@ -336,11 +347,11 @@ next: function next(e) {
             sub.unsubscribe();
-            clearTimeout(timeoutId);
-            _this2.open(e.descriptor, timeout).then(resolve, reject);
+            clearTimeout(openTimeoutId);
+            _this2.open(e.descriptor, openTimeout).then(resolve, reject);
           },
           error: function error(e) {
-            clearTimeout(timeoutId);
+            clearTimeout(openTimeoutId);
             reject(e);
           },
           complete: function complete() {
-            clearTimeout(timeoutId);
+            clearTimeout(openTimeoutId);
             if (!found) {
@@ -347,0 +358,0 @@ reject(new TransportError("No device found", "NoDeviceFound"));

package.json

 {
   "name": "@ledgerhq/hw-transport",
-  "version": "2.2.0",
+  "version": "3.0.0",
   "description": "Ledger Hardware Wallet common interface of the communication layer",
@@ -5,0 +5,0 @@ "keywords": [

src/Transport.js

@@ -94,2 +94,3 @@ //@flow
   debug: boolean = false;
+  exchangeTimeout: number = 30000;
 
@@ -198,2 +199,9 @@ /**
   /**
+   * Set a timeout (in milliseconds) for the exchange call. Only some transport might implement it. (e.g. U2F)
+   */
+  setExchangeTimeout(exchangeTimeout: number) {
+    this.exchangeTimeout = exchangeTimeout;
+  }
+
+  /**
    * wrapper on top of exchange to simplify work of the implementation.
@@ -243,3 +251,3 @@ * @param cla
    */
-  static create(timeout?: number = 5000): Promise<Transport<Descriptor>> {
+  static create(openTimeout?: number = 5000): Promise<Transport<Descriptor>> {
     if (arguments.length > 1) {
@@ -253,6 +261,6 @@ console.warn(
       let found = false;
-      const timeoutId = setTimeout(() => {
+      const openTimeoutId = setTimeout(() => {
         sub.unsubscribe();
-        reject(new TransportError("Transport timeout", "timeout"));
-      }, timeout);
+        reject(new TransportError("Transport openTimeout", "OpenTimeout"));
+      }, openTimeout);
       const sub = this.listen({
@@ -262,11 +270,11 @@ next: e => {
           sub.unsubscribe();
-          clearTimeout(timeoutId);
-          this.open(e.descriptor, timeout).then(resolve, reject);
+          clearTimeout(openTimeoutId);
+          this.open(e.descriptor, openTimeout).then(resolve, reject);
         },
         error: e => {
-          clearTimeout(timeoutId);
+          clearTimeout(openTimeoutId);
           reject(e);
         },
         complete: () => {
-          clearTimeout(timeoutId);
+          clearTimeout(openTimeoutId);
           if (!found) {
@@ -273,0 +281,0 @@ reject(new TransportError("No device found", "NoDeviceFound"));

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

50765

increased by2.24%

Lines of code

844

increased by1.32%

Worsened metrics

Number of package files

10

decreased by-9.09%

No dependency changes