@ledgerhq/hw-transport - npm Package Compare versions

Comparing version 3.1.0-beta.da8a3a7f to 4.0.0

lib/Transport.js

@@ -328,13 +328,11 @@ "use strict";
 
-      var openTimeout = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : 5000;
+      var openTimeout = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : 3000;
+      var listenTimeout = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : 10000;
 
-      if (arguments.length > 1) {
-        console.warn(this.name + ".create: second parameter 'debugMode' has been dropped. instead, please use transport.setDebugMode(debug)");
-      }
       return new _promise2.default(function (resolve, reject) {
         var found = false;
-        var openTimeoutId = setTimeout(function () {
+        var listenTimeoutId = setTimeout(function () {
           sub.unsubscribe();
-          reject(new TransportError("Transport openTimeout", "OpenTimeout"));
-        }, openTimeout);
+          reject(new TransportError(_this2.ErrorMessage_ListenTimeout, "ListenTimeout"));
+        }, listenTimeout);
         var sub = _this2.listen({
@@ -344,13 +342,13 @@ next: function next(e) {
             sub.unsubscribe();
-            clearTimeout(openTimeoutId);
+            clearTimeout(listenTimeoutId);
             _this2.open(e.descriptor, openTimeout).then(resolve, reject);
           },
           error: function error(e) {
-            clearTimeout(openTimeoutId);
+            clearTimeout(listenTimeoutId);
             reject(e);
           },
           complete: function complete() {
-            clearTimeout(openTimeoutId);
+            clearTimeout(listenTimeoutId);
             if (!found) {
-              reject(new TransportError("No device found", "NoDeviceFound"));
+              reject(new TransportError(_this2.ErrorMessage_NoDeviceFound, "NoDeviceFound"));
             }
@@ -365,3 +363,5 @@ }
 
+Transport.ErrorMessage_ListenTimeout = "No Ledger device found (timeout)";
+Transport.ErrorMessage_NoDeviceFound = "No Ledger device found";
 exports.default = Transport;
 //# sourceMappingURL=Transport.js.map

package.json

 {
   "name": "@ledgerhq/hw-transport",
-  "version": "3.1.0-beta.da8a3a7f",
+  "version": "4.0.0",
   "description": "Ledger Hardware Wallet common interface of the communication layer",
@@ -5,0 +5,0 @@ "keywords": [

src/Transport.js

@@ -249,15 +249,14 @@ //@flow
    */
-  static create(openTimeout?: number = 5000): Promise<Transport<Descriptor>> {
-    if (arguments.length > 1) {
-      console.warn(
-        this.name +
-          ".create: second parameter 'debugMode' has been dropped. instead, please use transport.setDebugMode(debug)"
-      );
-    }
+  static create(
+    openTimeout?: number = 3000,
+    listenTimeout?: number = 10000
+  ): Promise<Transport<Descriptor>> {
     return new Promise((resolve, reject) => {
       let found = false;
-      const openTimeoutId = setTimeout(() => {
+      const listenTimeoutId = setTimeout(() => {
         sub.unsubscribe();
-        reject(new TransportError("Transport openTimeout", "OpenTimeout"));
-      }, openTimeout);
+        reject(
+          new TransportError(this.ErrorMessage_ListenTimeout, "ListenTimeout")
+        );
+      }, listenTimeout);
       const sub = this.listen({
@@ -267,13 +266,18 @@ next: e => {
           sub.unsubscribe();
-          clearTimeout(openTimeoutId);
+          clearTimeout(listenTimeoutId);
           this.open(e.descriptor, openTimeout).then(resolve, reject);
         },
         error: e => {
-          clearTimeout(openTimeoutId);
+          clearTimeout(listenTimeoutId);
           reject(e);
         },
         complete: () => {
-          clearTimeout(openTimeoutId);
+          clearTimeout(listenTimeoutId);
           if (!found) {
-            reject(new TransportError("No device found", "NoDeviceFound"));
+            reject(
+              new TransportError(
+                this.ErrorMessage_NoDeviceFound,
+                "NoDeviceFound"
+              )
+            );
           }
@@ -284,2 +288,5 @@ }
   }
+
+  static ErrorMessage_ListenTimeout = "No Ledger device found (timeout)";
+  static ErrorMessage_NoDeviceFound = "No Ledger device found";
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

51237

increased by0.45%

Lines of code

850

increased by0.12%

Number of low quality alerts

0

decreased by-100%

Worsened metrics

Number of package files

10

decreased by-9.09%

No dependency changes