@lego/tslint-config - npm Package Compare versions

Comparing version 1.4.1 to 1.5.0

lib/rules/tslint/functionality.js

@@ -68,2 +68,4 @@ "use strict";
         'no-object-literal-type-assertion': true,
+        // Disallow specific global variables.
+        'no-restricted-globals': [true, 'name', 'length', 'event'],
         // Disallows unnecessary `return await`.
@@ -70,0 +72,0 @@ 'no-return-await': true,

lib/rules/tslint/style.js

@@ -162,3 +162,3 @@ "use strict";
         'variable-name': {
-            options: ['ban-keywords', 'check-format', 'allow-pascal-case'],
+            options: ['ban-keywords', 'allow-leading-underscore', 'check-format', 'allow-pascal-case'],
         },
@@ -165,0 +165,0 @@ // Enforces whitespace style conventions.

lib/utils/typescript-only.js

@@ -35,3 +35,2 @@ "use strict";
     'typedef',
-    'typedef-whitespace',
     'unified-signatures',
@@ -63,2 +62,3 @@ 'await-promise',
     'type-literal-delimiter',
+    'typedef-whitespace',
 ];
@@ -65,0 +65,0 @@ exports.allRules = __assign({}, functionality_1.rules, maintainability_1.rules, style_1.rules, typescript_1.rules);

package.json

 {
   "name": "@lego/tslint-config",
-  "version": "1.4.1",
+  "version": "1.5.0",
   "description": "LEGO shareable tslint config for ts projects",
@@ -34,6 +34,6 @@ "keywords": [
     "@lego/prettier-config": "1.1.0",
-    "idx": "^2.5.2",
-    "prettier": "^1.15.3",
-    "tslint": "^5.12.1",
-    "tslint-config-prettier": "^1.17.0",
+    "idx": "^2.5.4",
+    "prettier": "^1.16.4",
+    "tslint": "^5.13.1",
+    "tslint-config-prettier": "^1.18.0",
     "tslint-consistent-codestyle": "^1.15.0",
@@ -46,12 +46,12 @@ "tslint-lines-between-class-members": "^1.3.1",
   "devDependencies": {
-    "@types/isomorphic-fetch": "^0.0.34",
-    "@types/jsdom": "^12.2.1",
-    "@types/node": "^10.12.18",
-    "@types/prettier": "^1.15.2",
+    "@types/isomorphic-fetch": "^0.0.35",
+    "@types/jsdom": "^12.2.3",
+    "@types/node": "^11.10.4",
+    "@types/prettier": "^1.16.1",
     "chalk": "^2.4.2",
     "isomorphic-fetch": "^2.2.1",
-    "jsdom": "^13.1.0",
-    "ts-node": "^7.0.1",
-    "typescript": "^3.2.2"
+    "jsdom": "^13.2.0",
+    "ts-node": "^8.0.2",
+    "typescript": "^3.3.3333"
   }
 }

README.md

@@ -24,2 +24,3 @@ # @lego/tslint-config
 - `@lego/tslint-config/lib/configurations/typescript-react` - Base Config + React config + Prettier
+- `@lego/tslint-config/lib/configurations/typescript-react` - Base Config + Angular config + Prettier
 
@@ -42,24 +43,4 @@ add the above preferred configuration in your tslint.json file as f.ex:
 - [x] https://github.com/prettier/tslint-config-prettier
+- [x] https://github.com/mgechev/codelyzer
 
-A future release will add LEGO custom rules for Angular projects.
-
-- [ ] https://github.com/mgechev/codelyzer
-
-if you would like to use codelyzer in the meanwhile, with your own rules, it's imperative that you follow the following
-steps:
-
-You can use the `tslint-angular` preset. All you need is:
-
-```bash
-$ npm i tslint-angular
-```
-
-After that create a `tslint.json` file with the following configuration, note that the order is important.
-
-```json
-{
-  "extends": ["tslint-angular", "@lego/tslint-config"]
-}
-```
-
 ### Overriding Rules
@@ -82,1 +63,8 @@
 feel free to create a pull request.
+
+## Todo
+
+- [] extract `typescript` config into `@lego/tslint-config-typescript`
+- [] extract `typescript angular` config into `@lego/tslint-config-angular`
+- [] add `rxjs` best practices
+- [] extract `typescript react` config into `@lego/tslint-config-react`

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

44689

increased by15.94%

Number of package files

33

increased by32%

Lines of code

945

increased by16.24%

Worsened metrics

Number of lines in readme file

68

decreased by-15%

Dependency changes

• Updatedidx@^2.5.4

• Updatedprettier@^1.16.4

• Updatedtslint@^5.13.1

• Updatedtslint-config-prettier@^1.18.0