@lerna/collect-updates - npm Package Compare versions

Comparing version 3.0.0-beta.18 to 3.0.0-beta.19

CHANGELOG.md

@@ -6,2 +6,20 @@ # Change Log
 
+<a name="3.0.0-beta.19"></a>
+# [3.0.0-beta.19](https://github.com/lerna/lerna/compare/v3.0.0-beta.18...v3.0.0-beta.19) (2018-05-03)
+
+
+### Bug Fixes
+
+* **collect-updates:** Derive most recent tag from annotated tags only ([90df646](https://github.com/lerna/lerna/commit/90df646))
+* **collect-updates:** Remove redundant short-circuit ([#1406](https://github.com/lerna/lerna/issues/1406)) ([2bcdd35](https://github.com/lerna/lerna/commit/2bcdd35))
+
+
+### BREAKING CHANGES
+
+* **collect-updates:** Lightweight tags are no longer included when detecting changes since the last release.
+
+
+
+
+
 <a name="3.0.0-beta.18"></a>
@@ -8,0 +26,0 @@ # [3.0.0-beta.18](https://github.com/lerna/lerna/compare/v3.0.0-beta.17...v3.0.0-beta.18) (2018-04-24)

collect-updates.js

@@ -13,3 +13,9 @@ "use strict";
 
-function collectUpdates({ filteredPackages, packageGraph, options, execOpts, logger }) {
+function collectUpdates({
+  filteredPackages,
+  packageGraph,
+  options: { canary, cdVersion, forcePublish, ignoreChanges, since },
+  execOpts,
+  logger,
+}) {
   const packages =
@@ -22,6 +28,6 @@ filteredPackages.length === packageGraph.size
 
-  let { since: committish } = options;
+  let committish = since;
 
   if (hasTags(execOpts)) {
-    if (options.canary) {
+    if (canary) {
       const sha = childProcess.execSync("git", ["rev-parse", "--short", "HEAD"], execOpts);
@@ -33,3 +39,4 @@
     } else if (!committish) {
-      committish = childProcess.execSync("git", ["describe", "--tags", "--abbrev=0"], execOpts);
+      // attempt to find the last annotated tag in the current branch
+      committish = childProcess.execSync("git", ["describe", "--abbrev=0"], execOpts);
     }
@@ -40,3 +47,3 @@ }
 
-  const forced = getForcedPackages(options.forcePublish);
+  const forced = getForcedPackages(forcePublish);
   let candidates;
@@ -49,5 +56,4 @@
 
-    const ignorePatterns = options.ignore || options.ignoreChanges; // "ignore" might be durable
-    const hasDiff = makeDiffPredicate(committish, execOpts, ignorePatterns);
-    const needsBump = (options.cdVersion || "").startsWith("pre")
+    const hasDiff = makeDiffPredicate(committish, execOpts, ignoreChanges);
+    const needsBump = (cdVersion || "").startsWith("pre")
       ? () => false
@@ -67,8 +73,3 @@ : /* skip packages that have not been previously prereleased */
 
-  if (options.canary || packages.size === candidates.size) {
-    logger.verbose("updated", "(short-circuit)");
-
-    return Array.from(candidates);
-  }
-
+  // The result should always be in the same order as the input
   const updates = [];
@@ -75,0 +76,0 @@

package.json

 {
   "name": "@lerna/collect-updates",
-  "version": "3.0.0-beta.18",
+  "version": "3.0.0-beta.19",
   "description": "TODO",
@@ -40,3 +40,3 @@ "keywords": [
   },
-  "gitHead": "7995561e8d010d9fa2e59109b57b9ad8573baba1"
+  "gitHead": "3574466560f600828a0f288cec8d137a21404f15"
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

8957

increased by5.81%

Lines of code

160

increased by1.91%

No dependency changes