@lerna/npm-conf - npm Package Compare versions

Comparing version 3.0.0 to 3.4.1

CHANGELOG.md

@@ -6,2 +6,13 @@ # Change Log
 
+## [3.4.1](https://github.com/lerna/lerna/compare/v3.4.0...v3.4.1) (2018-10-04)
+
+
+### Bug Fixes
+
+* **npm-conf:** Do not overwrite defaults with undefined cli keys ([25af71d](https://github.com/lerna/lerna/commit/25af71d))
+
+
+
+
+
 <a name="3.0.0"></a>
@@ -8,0 +19,0 @@ # [3.0.0](https://github.com/lerna/lerna/compare/v3.0.0-rc.0...v3.0.0) (2018-08-10)

lib/npm-conf.js

@@ -17,3 +17,15 @@ "use strict";
 
-  conf.add(Object.assign({}, opts), "cli");
+  // prevent keys with undefined values from obscuring defaults
+  const cleanOpts = opts
+    ? Object.keys(opts).reduce((acc, key) => {
+        if (opts && opts[key] !== undefined) {
+          // eslint-disable-next-line no-param-reassign
+          acc[key] = opts[key];
+        }
+
+        return acc;
+      }, {})
+    : {};
+
+  conf.add(cleanOpts, "cli");
   conf.addEnv();
@@ -20,0 +32,0 @@ conf.loadPrefix();

package.json

 {
   "name": "@lerna/npm-conf",
-  "version": "3.0.0",
+  "version": "3.4.1",
   "description": "Vendored npm-conf with updates",
@@ -41,3 +41,3 @@ "keywords": [
   },
-  "gitHead": "0c40a17a7cd4e9acd8e7ec33ffacd1c1acef5dc6"
+  "gitHead": "05a27a6d579fdc962f0e0588585b9fb7d0a453b7"
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

25157

increased by2.12%

Lines of code

710

increased by1.43%

No dependency changes