@lerna/package-graph - npm Package Compare versions

Comparing version 3.13.0 to 3.14.0

CHANGELOG.md

@@ -6,2 +6,14 @@ # Change Log
 
+# [3.14.0](https://github.com/lerna/lerna/compare/v3.13.4...v3.14.0) (2019-05-14)
+
+
+### Features
+
+* **conventional-commits:** Add conventional prerelease/graduation ([#1991](https://github.com/lerna/lerna/issues/1991)) ([5d84b61](https://github.com/lerna/lerna/commit/5d84b61)), closes [#1433](https://github.com/lerna/lerna/issues/1433) [#1675](https://github.com/lerna/lerna/issues/1675)
+* **run:** Add just-in-time queue management ([#2045](https://github.com/lerna/lerna/issues/2045)) ([6eca172](https://github.com/lerna/lerna/commit/6eca172))
+
+
+
+
+
 # [3.13.0](https://github.com/lerna/lerna/compare/v3.12.1...v3.13.0) (2019-02-15)
@@ -8,0 +20,0 @@

index.js

@@ -5,3 +5,6 @@ "use strict";
 const semver = require("semver");
+const log = require("npmlog");
+
 const ValidationError = require("@lerna/validation-error");
+const prereleaseIdFromVersion = require("@lerna/prerelease-id-from-version");
 
@@ -26,3 +29,3 @@ /**
         // an existing prerelease ID only matters at the beginning
-        value: (semver.prerelease(pkg.version) || []).shift(),
+        value: prereleaseIdFromVersion(pkg.version),
       },
@@ -193,5 +196,6 @@ // properties that might change over time
    * Return a tuple of cycle paths and nodes, which have been removed from the graph.
+   * @param {!boolean} rejectCycles Whether or not to reject cycles
    * @returns [Set<String[]>, Set<PackageGraphNode>]
    */
-  partitionCycles() {
+  partitionCycles(rejectCycles) {
     const cyclePaths = new Set();
@@ -240,4 +244,12 @@ const cycleNodes = new Set();
 
-    if (cycleNodes.size) {
-      this.prune(...cycleNodes);
+    if (cyclePaths.size) {
+      const cycleMessage = ["Dependency cycles detected, you should fix these!"]
+        .concat(Array.from(cyclePaths).map(cycle => cycle.join(" -> ")))
+        .join("\n");
+
+      if (rejectCycles) {
+        throw new ValidationError("ECYCLE", cycleMessage);
+      }
+
+      log.warn("ECYCLE", cycleMessage);
     }
@@ -249,2 +261,10 @@
   /**
+   * Remove cycle nodes.
+   * @param {Set<PackageGraphNode>} cycleNodes
+   */
+  pruneCycleNodes(cycleNodes) {
+    return this.prune(...cycleNodes);
+  }
+
+  /**
    * Remove all candidate nodes.
@@ -251,0 +271,0 @@ * @param {PackageGraphNode[]} candidates

package.json

 {
   "name": "@lerna/package-graph",
-  "version": "3.13.0",
+  "version": "3.14.0",
   "description": "Lerna's internal representation of a package graph",
@@ -34,7 +34,9 @@ "keywords": [
   "dependencies": {
+    "@lerna/prerelease-id-from-version": "3.14.0",
     "@lerna/validation-error": "3.13.0",
     "npm-package-arg": "^6.1.0",
+    "npmlog": "^4.1.2",
     "semver": "^5.5.0"
   },
-  "gitHead": "9a47201f3fdd1df09cfb1922f26329d1dc4c8cc5"
+  "gitHead": "39da145c67ea587457694f318f32f967b9d66ea9"
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

17196

increased by7.8%

Lines of code

250

increased by6.84%

Worsened metrics

Dependency count

5

increased by66.67%

Dependency changes

• + Added@lerna/prerelease-id-from-version@3.14.0

• + Addednpmlog@^4.1.2

• + Added@lerna/prerelease-id-from-version@3.14.0(transitive)