@lerna/symlink-binary - npm Package Compare versions

Comparing version 3.7.0 to 3.7.2

CHANGELOG.md

@@ -6,2 +6,13 @@ # Change Log
 
+## [3.7.2](https://github.com/lerna/lerna/compare/v3.7.1...v3.7.2) (2018-12-21)
+
+
+### Bug Fixes
+
+* **symlink-binary:** Use Package.lazy() instead of private resolver ([83fe3ef](https://github.com/lerna/lerna/commit/83fe3ef))
+
+
+
+
+
 # [3.7.0](https://github.com/lerna/lerna/compare/v3.6.0...v3.7.0) (2018-12-19)
@@ -8,0 +19,0 @@

package.json

 {
   "name": "@lerna/symlink-binary",
-  "version": "3.7.0",
+  "version": "3.7.2",
   "description": "An internal Lerna tool",
@@ -34,8 +34,7 @@ "keywords": [
     "@lerna/create-symlink": "^3.6.0",
-    "@lerna/package": "^3.7.0",
+    "@lerna/package": "^3.7.2",
     "fs-extra": "^7.0.0",
-    "p-map": "^1.2.0",
-    "read-pkg": "^3.0.0"
+    "p-map": "^1.2.0"
   },
-  "gitHead": "89b53ff2b561e69fad3a3e8671d7dcd0f1c09c3e"
+  "gitHead": "52796f674ad3f2642270e942e96443437c54ff72"
 }

symlink-binary.js

@@ -6,3 +6,2 @@ "use strict";
 const pMap = require("p-map");
-const readPkg = require("read-pkg");
 
@@ -21,3 +20,3 @@ const Package = require("@lerna/package");
 function symlinkBinary(srcPackageRef, destPackageRef) {
-  return Promise.all([resolvePackageRef(srcPackageRef), resolvePackageRef(destPackageRef)]).then(
+  return Promise.all([Package.lazy(srcPackageRef), Package.lazy(destPackageRef)]).then(
     ([srcPackage, destPackage]) => {
@@ -49,10 +48,1 @@ const actions = Object.keys(srcPackage.bin).map(name => {
 }
-
-function resolvePackageRef(pkgRef) {
-  // don't use instanceof because it fails across nested module boundaries
-  if (typeof pkgRef !== "string" && pkgRef.location) {
-    return pkgRef;
-  }
-
-  return readPkg(pkgRef, { normalize: false }).then(json => new Package(json, pkgRef));
-}

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Dependency count

4

decreased by-20%

Worsened metrics

Total package byte prevSize

5872

decreased by-2.08%

Lines of code

38

decreased by-17.39%

Dependency changes

• - Removedread-pkg@^3.0.0

• - Removedfunction-bind@1.1.2(transitive)

• - Removedhasown@2.0.2(transitive)

• - Removedis-core-module@2.15.1(transitive)

• - Removedload-json-file@4.0.0(transitive)

• - Removednormalize-package-data@2.5.0(transitive)

• - Removedpath-parse@1.0.7(transitive)

• - Removedpath-type@3.0.0(transitive)

• - Removedread-pkg@3.0.0(transitive)

• - Removedresolve@1.22.8(transitive)

• - Removedspdx-correct@3.2.0(transitive)

• - Removedspdx-exceptions@2.5.0(transitive)

• - Removedspdx-expression-parse@3.0.1(transitive)

• - Removedspdx-license-ids@3.0.20(transitive)

• - Removedsupports-preserve-symlinks-flag@1.0.0(transitive)

• - Removedvalidate-npm-package-license@3.0.4(transitive)

• Updated@lerna/package@^3.7.2