@libp2p/tcp - npm Package Compare versions

Comparing version 3.0.5 to 3.0.6

dist/src/index.js

@@ -24,2 +24,3 @@ import net from 'net';
         const socket = await this._connect(ma, options);
+        socket.setKeepAlive(true);
         // Avoid uncaught errors caused by unstable connections
@@ -26,0 +27,0 @@ socket.on('error', err => {

dist/src/listener.js

@@ -27,2 +27,3 @@ import net from 'net';
     const server = Object.assign(net.createServer(socket => {
+        socket.setKeepAlive(true);
         // Avoid uncaught errors caused by unstable connections
@@ -29,0 +30,0 @@ socket.on('error', err => {

dist/src/socket-to-conn.js

@@ -24,3 +24,14 @@ import { abortableSource } from 'abortable-iterator';
     }
-    const remoteAddr = options.remoteAddr ?? toMultiaddr(socket.remoteAddress ?? '', socket.remotePort ?? '');
+    let remoteAddr;
+    if (options.remoteAddr != null) {
+        remoteAddr = options.remoteAddr;
+    }
+    else {
+        if (socket.remoteAddress == null || socket.remotePort == null) {
+            // this can be undefined if the socket is destroyed (for example, if the client disconnected)
+            // https://nodejs.org/dist/latest-v16.x/docs/api/net.html#socketremoteaddress
+            throw errCode(new Error('Could not determine remote address or port'), 'ERR_NO_REMOTE_ADDRESS');
+        }
+        remoteAddr = toMultiaddr(socket.remoteAddress, socket.remotePort);
+    }
     const { host, port } = remoteAddr.toOptions();
@@ -27,0 +38,0 @@ const { sink, source } = toIterable.duplex(socket);

package.json

 {
   "name": "@libp2p/tcp",
-  "version": "3.0.5",
+  "version": "3.0.6",
   "description": "Node.js implementation of the TCP module that libp2p uses, which implements the interface-connection and interface-transport interfaces",
@@ -5,0 +5,0 @@ "license": "Apache-2.0 OR MIT",

src/index.ts

@@ -52,2 +52,3 @@ import net from 'net'
     const socket = await this._connect(ma, options)
+    socket.setKeepAlive(true)
 
@@ -54,0 +55,0 @@ // Avoid uncaught errors caused by unstable connections

src/listener.ts

@@ -51,2 +51,4 @@ import net from 'net'
   const server: ServerWithMultiaddrConnections = Object.assign(net.createServer(socket => {
+    socket.setKeepAlive(true)
+
     // Avoid uncaught errors caused by unstable connections
@@ -53,0 +55,0 @@ socket.on('error', err => {

src/socket-to-conn.ts

@@ -41,3 +41,16 @@ import { abortableSource } from 'abortable-iterator'
 
-  const remoteAddr = options.remoteAddr ?? toMultiaddr(socket.remoteAddress ?? '', socket.remotePort ?? '')
+  let remoteAddr: Multiaddr
+
+  if (options.remoteAddr != null) {
+    remoteAddr = options.remoteAddr
+  } else {
+    if (socket.remoteAddress == null || socket.remotePort == null) {
+      // this can be undefined if the socket is destroyed (for example, if the client disconnected)
+      // https://nodejs.org/dist/latest-v16.x/docs/api/net.html#socketremoteaddress
+      throw errCode(new Error('Could not determine remote address or port'), 'ERR_NO_REMOTE_ADDRESS')
+    }
+
+    remoteAddr = toMultiaddr(socket.remoteAddress, socket.remotePort)
+  }
+
   const { host, port } = remoteAddr.toOptions()
@@ -44,0 +57,0 @@ const { sink, source } = toIterable.duplex(socket)

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

64671

increased by2.16%

Lines of code

982

increased by2.61%

No dependency changes