@lighthouse/common - npm Package Compare versions

Comparing version 4.24.1 to 4.24.2-canary.112.1414

dist/pdf/activity-report/index.js

@@ -25,7 +25,2 @@ "use strict";
 const LIGHTHOUSE_BASE_URL = 'https://app.lighthouse.io';
-const maxFormsText = {
-  text: [(0, _helpers.text)(`Detailed Form Submissions in the Daily Activity Report are limited to a total of ${MAX_ATTACHMENTS}. `), (0, _helpers.text)('To access individual Form Submissions, open the hyperlink next to the respective submission within the Other Activity table. Alternatively, they may be accessed in the Lighthouse Management Console.')],
-  style: 'small',
-  margin: [0, 10, 0, 10]
-};
 /**
@@ -153,2 +148,7 @@ * buildActivityPdf
   if (exceedsMaxForms) {
+    const maxFormsText = {
+      text: [(0, _helpers.text)(`Detailed Form Submissions in the Daily Activity Report are limited to a total of ${MAX_ATTACHMENTS}. `), (0, _helpers.text)('To access individual Form Submissions, open the hyperlink next to the respective submission within the Activity Summary table. Alternatively, they may be accessed in the Lighthouse Management Console.')],
+      style: 'small',
+      margin: [0, 10, 0, 10]
+    };
     activitySummarySection.push(maxFormsText);
@@ -440,2 +440,7 @@ }
   if (exceedsMaxForms) {
+    const maxFormsText = {
+      text: [(0, _helpers.text)(`Detailed Form Submissions in the Daily Activity Report are limited to a total of ${MAX_ATTACHMENTS}. `), (0, _helpers.text)('To access individual Form Submissions, open the hyperlink next to the respective submission within the Other Activity table. Alternatively, they may be accessed in the Lighthouse Management Console.')],
+      style: 'small',
+      margin: [0, 10, 0, 10]
+    };
     otherActivitySummarySection.push(maxFormsText);
@@ -442,0 +447,0 @@ }

lib/pdf/activity-report/index.js

@@ -19,7 +19,2 @@ import _regeneratorRuntime from "@babel/runtime/regenerator";
 var LIGHTHOUSE_BASE_URL = 'https://app.lighthouse.io';
-var maxFormsText = {
-  text: [text("Detailed Form Submissions in the Daily Activity Report are limited to a total of ".concat(MAX_ATTACHMENTS, ". ")), text('To access individual Form Submissions, open the hyperlink next to the respective submission within the Other Activity table. Alternatively, they may be accessed in the Lighthouse Management Console.')],
-  style: 'small',
-  margin: [0, 10, 0, 10]
-};
 /**
@@ -176,3 +171,3 @@ * buildActivityPdf
   _buildActivitySummarySection = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee4(data) {
-    var audits, events, issues, _data$maxScans, maxScans, settings, tasks, timezone, enterEvents, exceedsMaxScans, scans, auditRows, issueRows, scanRows, taskRows, formCount, exceedsMaxForms, rows, sortedRows, title, header, hLine, activityTable, activitySummarySection, maxScansText;
+    var audits, events, issues, _data$maxScans, maxScans, settings, tasks, timezone, enterEvents, exceedsMaxScans, scans, auditRows, issueRows, scanRows, taskRows, formCount, exceedsMaxForms, rows, sortedRows, title, header, hLine, activityTable, activitySummarySection, maxScansText, maxFormsText;
 
@@ -229,2 +224,7 @@ return _regeneratorRuntime.wrap(function _callee4$(_context4) {
             if (exceedsMaxForms) {
+              maxFormsText = {
+                text: [text("Detailed Form Submissions in the Daily Activity Report are limited to a total of ".concat(MAX_ATTACHMENTS, ". ")), text('To access individual Form Submissions, open the hyperlink next to the respective submission within the Activity Summary table. Alternatively, they may be accessed in the Lighthouse Management Console.')],
+                style: 'small',
+                margin: [0, 10, 0, 10]
+              };
               activitySummarySection.push(maxFormsText);
@@ -564,3 +564,3 @@ }
   _buildOtherActivitySection = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee7(data) {
-    var audits, issues, tasks, settings, timezone, auditRows, issueRows, taskRows, rows, sortedRows, title, header, hLine, activityTable, otherActivitySummarySection, formCount, exceedsMaxForms;
+    var audits, issues, tasks, settings, timezone, auditRows, issueRows, taskRows, rows, sortedRows, title, header, hLine, activityTable, otherActivitySummarySection, formCount, exceedsMaxForms, maxFormsText;
     return _regeneratorRuntime.wrap(function _callee7$(_context7) {
@@ -599,2 +599,7 @@ while (1) {
             if (exceedsMaxForms) {
+              maxFormsText = {
+                text: [text("Detailed Form Submissions in the Daily Activity Report are limited to a total of ".concat(MAX_ATTACHMENTS, ". ")), text('To access individual Form Submissions, open the hyperlink next to the respective submission within the Other Activity table. Alternatively, they may be accessed in the Lighthouse Management Console.')],
+                style: 'small',
+                margin: [0, 10, 0, 10]
+              };
               otherActivitySummarySection.push(maxFormsText);
@@ -601,0 +606,0 @@ }

package.json

 {
   "name": "@lighthouse/common",
-  "version": "4.24.1",
+  "version": "4.24.2-canary.112.1414",
   "description": "",
@@ -5,0 +5,0 @@ "main": "dist/index.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1236941

increased by0.15%

Lines of code

11900

increased by0.11%

Worsened metrics

Number of low quality alerts

2

increased by100%

No dependency changes