@lion/button - npm Package Compare versions

Comparing version 0.3.34 to 0.3.35

CHANGELOG.md

		@@ -6,2 +6,13 @@ # Change Log

		## [0.3.35](https://github.com/ing-bank/lion/compare/@lion/button@0.3.34...@lion/button@0.3.35) (2019-11-13)


		### Bug Fixes

		* button: make button more accessible ([fdedcf2](https://github.com/ing-bank/lion/commit/fdedcf289490209963794e83aa28ca07fb966583))





		## [0.3.34](https://github.com/ing-bank/lion/compare/@lion/button@0.3.33...@lion/button@0.3.34) (2019-11-12)
		@@ -8,0 +19,0 @@

package.json

		{
		"name": "@lion/button",
		"version": "0.3.34",
		"version": "0.3.35",
		"description": "A button that is easily styleable and accessible in all contexts",
		@@ -35,8 +35,8 @@ "author": "ing-bank",
		"dependencies": {
		"@lion/core": "^0.2.1"
		"@lion/core": "^0.3.0"
		},
		"devDependencies": {
		"@lion/form": "^0.1.73",
		"@lion/icon": "^0.2.8",
		"@lion/input": "^0.1.66",
		"@lion/form": "^0.2.0",
		"@lion/icon": "^0.2.9",
		"@lion/input": "^0.2.0",
		"@open-wc/demoing-storybook": "^0.2.0",
		@@ -47,3 +47,3 @@ "@open-wc/testing": "^2.3.4",
		},
		"gitHead": "64b76de801dd7f7adb47fcc45b657336a34e9bab"
		"gitHead": "90e6b4ef36bb5c49cfe7e4b2b8a00128334c84ab"
		}

src/LionButton.js

		@@ -95,3 +95,3 @@ import { css, html, SlotMixin, DisabledWithTabIndexMixin, LitElement } from '@lion/core';

		:host(:focus) .btn {
		:host(:focus:not([disabled])) .btn {
		/* if you extend, please overwrite */
		@@ -141,2 +141,3 @@ outline: 2px solid #bde4ff;
		this.constructor._button.setAttribute('tabindex', '-1');
		this.constructor._button.setAttribute('aria-hidden', true);
		}
		@@ -143,0 +144,0 @@ return this.constructor._button.cloneNode();

stories/index.stories.js

		@@ -44,6 +44,6 @@ import { storiesOf, html } from '@open-wc/demoing-storybook';
		>
		<label>First name</label>
		<input name="firstName" />
		<label>Last name</label>
		<input name="lastName" />
		<label for="firstNameId">First name</label>
		<input id="firstNameId" name="firstName" />
		<label for="lastNameId">Last name</label>
		<input id="lastNameId" name="lastName" />
		<lion-button @click=${() => console.log('click handler')}>Submit</lion-button>
		@@ -50,0 +50,0 @@ </form>

test/lion-button.test.js

		@@ -225,2 +225,8 @@ import { expect, fixture, html, aTimeout, oneEvent } from '@open-wc/testing';
		});

		it('has a native button node with aria-hidden set to true', async () => {
		const el = await fixture('<lion-button></lion-button>');

		expect(el._nativeButtonNode.getAttribute('aria-hidden')).to.equal('true');
		});
		});
		@@ -227,0 +233,0 @@

New alerts