@lion/core - npm Package Compare versions

Comparing version 0.1.2 to 0.1.3

CHANGELOG.md

@@ -6,2 +6,13 @@ # Change Log
 
+## [0.1.3](https://github.com/ing-bank/lion/compare/@lion/core@0.1.2...@lion/core@0.1.3) (2019-04-28)
+
+
+### Bug Fixes
+
+* update storybook/linting; adjust story labels, eslint ignores ([8d96f84](https://github.com/ing-bank/lion/commit/8d96f84))
+
+
+
+
+
 ## [0.1.2](https://github.com/ing-bank/lion/compare/@lion/core@0.1.1...@lion/core@0.1.2) (2019-04-27)
@@ -8,0 +19,0 @@

package.json

 {
   "name": "@lion/core",
-  "version": "0.1.2",
+  "version": "0.1.3",
   "description": "Core functionality that is shared across all Lion Web Components",
@@ -36,7 +36,7 @@ "author": "ing-bank",
   "devDependencies": {
-    "@open-wc/storybook": "^0.1.5",
+    "@open-wc/demoing-storybook": "^0.2.0",
     "@open-wc/testing": "^0.11.1",
     "sinon": "^7.2.2"
   },
-  "gitHead": "6497db62d375612d691f00120daa0cdb2d899dc5"
+  "gitHead": "bb1d1448b59f5b6579880a521f0695578d09eb73"
 }

src/CssClassMixin.js

 import { dedupeMixin } from './dedupeMixin.js';
 
-/* eslint-disable no-underscore-dangle */
-
 /**
@@ -6,0 +4,0 @@ * # CssClassMixin

src/DelegateMixin.js

@@ -1,2 +0,2 @@
-/* eslint-disable no-underscore-dangle, class-methods-use-this */
+/* eslint-disable class-methods-use-this */
 
@@ -3,0 +3,0 @@ import { dedupeMixin } from './dedupeMixin.js';

src/DomHelpersMixin.js

@@ -1,3 +0,1 @@
-/* eslint-disable no-underscore-dangle */
-
 import { dedupeMixin } from './dedupeMixin.js';
@@ -4,0 +2,0 @@

src/ElementMixin.js

@@ -1,2 +0,1 @@
-/* eslint-disable no-underscore-dangle, class-methods-use-this */
 /* global ShadyCSS */
@@ -3,0 +2,0 @@ import { dedupeMixin } from './dedupeMixin.js';

src/EventMixin.js

@@ -1,2 +0,2 @@
-/* eslint-disable no-underscore-dangle, class-methods-use-this */
+/* eslint-disable class-methods-use-this */
 
@@ -3,0 +3,0 @@ import { dedupeMixin } from './dedupeMixin.js';

src/LionSingleton.js

@@ -1,3 +0,1 @@
-/* eslint-disable no-underscore-dangle */
-
 /**
@@ -4,0 +2,0 @@ * 'LionSingleton' provides an instance of the given class via .getInstance(foo, bar) and will

src/ObserverMixin.js

@@ -1,3 +0,1 @@
-/* eslint-disable no-underscore-dangle */
-
 import { dedupeMixin } from './dedupeMixin.js';
@@ -4,0 +2,0 @@

src/SlotMixin.js

@@ -0,6 +1,6 @@
+/* eslint-disable class-methods-use-this */
+
 import { dedupeMixin } from './dedupeMixin.js';
 import { DomHelpersMixin } from './DomHelpersMixin.js';
 
-/* eslint-disable class-methods-use-this, no-underscore-dangle */
-
 /**
@@ -7,0 +7,0 @@ * # SlotMixin

test/CssClassMixin.test.js

@@ -1,3 +0,1 @@
-/* eslint-env mocha */
-/* eslint-disable no-underscore-dangle, no-unused-expressions  */
 import { expect, fixture } from '@open-wc/testing';
@@ -4,0 +2,0 @@

test/dedupeMixin.test.js

@@ -1,2 +0,1 @@
-/* eslint-env mocha */
 import { expect } from '@open-wc/testing';
@@ -3,0 +2,0 @@

test/DelegateMixin.test.js

@@ -1,3 +0,1 @@
-/* eslint-env mocha */
-/* eslint-disable no-unused-expressions, class-methods-use-this */
 import { expect, fixture, defineCE, unsafeStatic, html } from '@open-wc/testing';
@@ -506,4 +504,4 @@ import sinon from 'sinon';
     // TODO: double check if we test the right thing here
-    expect(el.constructor._classProperties.get('size')).to.be.undefined; // eslint-disable-line no-underscore-dangle
+    expect(el.constructor._classProperties.get('size')).to.be.undefined;
   });
 });

test/DomHelpersMixin.test.js

@@ -1,3 +0,1 @@
-/* eslint-disable class-methods-use-this, no-underscore-dangle */
-/* eslint-env mocha */
 import { expect, fixture, defineCE } from '@open-wc/testing';
@@ -4,0 +2,0 @@ import { LionLitElement, html } from '../src/LionLitElement.js';

test/EventMixin.test.js

@@ -1,3 +0,1 @@
-/* eslint-env mocha */
-/* eslint-disable no-unused-expressions, class-methods-use-this */
 import { expect, fixture, html, defineCE } from '@open-wc/testing';
@@ -41,3 +39,2 @@ import { LionLitElement } from '../src/LionLitElement.js';
 
-      // eslint-disable-next-line class-methods-use-this
       render() {
@@ -112,3 +109,3 @@ return html`
     // this will clear it's state on window
-    delete window.__eventMixinProcessed; // eslint-disable-line no-underscore-dangle
+    delete window.__eventMixinProcessed;
   });
@@ -147,3 +144,3 @@
         this.lightDomInput = this.querySelector('input');
-        this.__registerEvents(); // eslint-disable-line
+        this.__registerEvents();
       }
@@ -183,3 +180,3 @@ }
         this.lightDomButton = this.querySelector('button');
-        this.__registerEvents(); // eslint-disable-line
+        this.__registerEvents();
       }
@@ -201,5 +198,5 @@ }
     const element = await fixture(`<event-mixin></event-mixin>`);
-    element.__registerEvents(); // eslint-disable-line
-    element.__registerEvents(); // eslint-disable-line
-    expect(element.__eventsCache.length).to.equal(4); // eslint-disable-line
+    element.__registerEvents();
+    element.__registerEvents();
+    expect(element.__eventsCache.length).to.equal(4);
   });
@@ -213,4 +210,4 @@
     const element = await fixture(`<event-mixin></event-mixin>`);
-    element.__unregisterEvents(); // eslint-disable-line
-    expect(element.__eventsCache.length).to.equal(0); // eslint-disable-line
+    element.__unregisterEvents();
+    expect(element.__eventsCache.length).to.equal(0);
   });
@@ -217,0 +214,0 @@

test/LionLitElement.test.js

@@ -1,3 +0,1 @@
-/* eslint-env mocha */
-/* eslint-disable no-underscore-dangle, no-unused-expressions, class-methods-use-this */
 import { expect, fixture, defineCE } from '@open-wc/testing';
@@ -4,0 +2,0 @@

test/LionSingleton.test.js

@@ -1,3 +0,1 @@
-/* eslint-env mocha */
-/* eslint-disable no-unused-expressions */
 import { expect } from '@open-wc/testing';
@@ -4,0 +2,0 @@

test/lit-html.test.js

@@ -1,2 +0,1 @@
-/* eslint-env mocha */
 import { expect, fixture } from '@open-wc/testing';
@@ -3,0 +2,0 @@

test/ObserverMixin.test.js

@@ -1,3 +0,1 @@
-/* eslint-env mocha */
-/* eslint-disable no-underscore-dangle, class-methods-use-this, no-unused-expressions */
 import { expect, fixture, defineCE } from '@open-wc/testing';
@@ -4,0 +2,0 @@ import sinon from 'sinon';

test/SlotMixin.test.js

@@ -1,3 +0,1 @@
-/* eslint-env mocha */
-/* eslint-disable no-underscore-dangle, no-unused-expressions */
 import { expect, fixture, defineCE } from '@open-wc/testing';
@@ -4,0 +2,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

90239

decreased by-1.24%

Lines of code

2503

decreased by-0.95%

No dependency changes