@lion/field - npm Package Compare versions

Comparing version 0.6.7 to 0.6.8

CHANGELOG.md

		@@ -6,2 +6,13 @@ # Change Log

		## [0.6.8](https://github.com/ing-bank/lion/compare/@lion/field@0.6.7...@lion/field@0.6.8) (2019-12-04)


		### Bug Fixes

		* field: support moving of a portal node ([6a57e8a](https://github.com/ing-bank/lion/commit/6a57e8a235adac85f5437d6879a2248973c2b6b5))





		## [0.6.7](https://github.com/ing-bank/lion/compare/@lion/field@0.6.6...@lion/field@0.6.7) (2019-12-03)
		@@ -8,0 +19,0 @@

package.json

		{
		"name": "@lion/field",
		"version": "0.6.7",
		"version": "0.6.8",
		"description": "Fields are the most fundamental building block of the Form System",
		@@ -45,3 +45,3 @@ "author": "ing-bank",
		},
		"gitHead": "37fd54a4218e59ce3a19cb5b07ff37279c3e6921"
		"gitHead": "d705a35edac09db0e36f40ac4fc5ec8de7828fd9"
		}

src/FormRegistrarPortalMixin.js

		@@ -24,2 +24,3 @@ import { dedupeMixin } from '@lion/core';
		this.registrationTarget = undefined;
		this.__hasBeenRendered = false;
		this.__readyForRegistration = false;
		@@ -38,2 +39,5 @@ this.registrationReady = new Promise(resolve => {
		formRegistrarManager.add(this);
		if (this.__hasBeenRendered) {
		formRegistrarManager.becomesReady();
		}

		@@ -72,2 +76,3 @@ this.__redispatchEventForFormRegistrarPortalMixin = ev => {
		formRegistrarManager.becomesReady(this);
		this.__hasBeenRendered = true;
		}
		@@ -74,0 +79,0 @@

test-suites/FormRegistrationMixins.suite.js

		@@ -224,2 +224,26 @@ import { expect, fixture, html, defineCE, unsafeStatic } from '@open-wc/testing';

		it('keeps working if moving the portal itself', async () => {
		const el = await fixture(html`<${parentTag}></${parentTag}>`);
		const portal = await fixture(html`
		<${portalTag} .registrationTarget=${el}>
		<${childTag}></${childTag}>
		</${portalTag}>
		`);
		const otherPlace = await fixture(html`
		<div></div>
		`);
		otherPlace.appendChild(portal);
		const newField = await fixture(html`
		<${childTag}></${childTag}>
		`);

		expect(el.formElements.length).to.equal(1);

		portal.appendChild(newField);
		expect(el.formElements.length).to.equal(2);

		portal.removeChild(newField);
		expect(el.formElements.length).to.equal(1);
		});

		it('works for portals that have a delayed render', async () => {
		@@ -226,0 +250,0 @@ const delayedPortalString = defineCE(

New alerts