@lion/field - npm Package Compare versions

Comparing version 0.8.9 to 0.9.0

CHANGELOG.md

@@ -6,2 +6,13 @@ # Change Log
 
+# [0.9.0](https://github.com/ing-bank/lion/compare/@lion/field@0.8.9...@lion/field@0.9.0) (2020-02-06)
+
+
+### Features
+
+* flatten modelValue and remove checkedValue ([848ff06](https://github.com/ing-bank/lion/commit/848ff06887c86532e60d33d2db67d1152910d9cb))
+
+
+
+
+
 ## [0.8.9](https://github.com/ing-bank/lion/compare/@lion/field@0.8.8...@lion/field@0.8.9) (2020-02-06)
@@ -8,0 +19,0 @@

package.json

 {
   "name": "@lion/field",
-  "version": "0.8.9",
+  "version": "0.9.0",
   "description": "Fields are the most fundamental building block of the Form System",
@@ -45,3 +45,3 @@ "author": "ing-bank",
   },
-  "gitHead": "3995eb839701c7839c001d4f5c09fc48a313e782"
+  "gitHead": "455923278e3a2e9da58fe71df02105ab3f40021c"
 }

src/FormRegistrarMixin.js

 import { dedupeMixin } from '@lion/core';
+import { FormRegisteringMixin } from './FormRegisteringMixin.js';
 import { formRegistrarManager } from './formRegistrarManager.js';
-import { FormRegisteringMixin } from './FormRegisteringMixin.js';
 
@@ -5,0 +5,0 @@ /**

test-suites/FormRegistrationMixins.suite.js

@@ -1,9 +0,8 @@
-import { expect, fixture, html, defineCE, unsafeStatic } from '@open-wc/testing';
 import { LitElement } from '@lion/core';
+import { defineCE, expect, fixture, html, unsafeStatic } from '@open-wc/testing';
 import sinon from 'sinon';
-
+import { FormRegisteringMixin } from '../src/FormRegisteringMixin.js';
+import { formRegistrarManager } from '../src/formRegistrarManager.js';
 import { FormRegistrarMixin } from '../src/FormRegistrarMixin.js';
-import { FormRegisteringMixin } from '../src/FormRegisteringMixin.js';
 import { FormRegistrarPortalMixin } from '../src/FormRegistrarPortalMixin.js';
-import { formRegistrarManager } from '../src/formRegistrarManager.js';
 
@@ -130,2 +129,21 @@ export const runRegistrationSuite = customConfig => {
 
+    it('adds elements to formElements in the right order (DOM)', async () => {
+      const el = await fixture(html`
+        <${parentTag}>
+          <${childTag}></${childTag}>
+          <${childTag}></${childTag}>
+          <${childTag}></${childTag}>
+        </${parentTag}>
+      `);
+      const newField = await fixture(html`
+        <${childTag}></${childTag}>
+      `);
+      newField.myProp = 'test';
+
+      el.children[1].insertAdjacentElement('beforebegin', newField);
+
+      expect(el.formElements.length).to.equal(4);
+      expect(el.children[1].myProp).to.equal('test');
+    });
+
     describe('FormRegistrarPortalMixin', () => {
@@ -132,0 +150,0 @@ it('throws if there is no .registrationTarget', async () => {

No alert changes

Improved metrics

Total package byte prevSize

160756

increased by0.53%

Lines of code

3216

increased by0.5%

No dependency changes