@lion/form-core - npm Package Compare versions

Comparing version 0.14.2 to 0.15.0

CHANGELOG.md

 # Change Log
 
+## 0.15.0
+
+### Minor Changes
+
+- 8a766644: Make ValidateMixin feedback message wait for localize loadingComplete, to ensure getting the right fieldName if this refers to a localized label.
+
+### Patch Changes
+
+- e87b6293: only preserve caret if value changed, which fixes a safari bug
+- Updated dependencies [9648d418]
+- Updated dependencies [8c06302e]
+- Updated dependencies [9b9d82fc]
+- Updated dependencies [8a766644]
+- Updated dependencies [c544af4e]
+  - @lion/localize@0.21.0
+  - @lion/core@0.18.2
+
 ## 0.14.2
@@ -4,0 +21,0 @@

docs/overview.md

@@ -7,4 +7,4 @@ # Systems >> Form >> Overview ||10
 
-- Built in [validate](https://github.com/ing-bank/lion/blob/0895af24d06146a1ccf9c3904ca18b8a9131efd6/docs/docs/systems/form/validate.md) for error/warning/info/success
+- Built in [validate](https://github.com/ing-bank/lion/blob/e03f8d2cc31563d46f910074d562ad68a2e41dfd/docs/docs/systems/form/validate.md) for error/warning/info/success
 - Formatting of values
 - Accessible

package.json

 {
   "name": "@lion/form-core",
-  "version": "0.14.2",
+  "version": "0.15.0",
   "description": "Form-core contains all essential building blocks for creating form fields and fieldsets",
@@ -41,4 +41,4 @@ "license": "MIT",
   "dependencies": {
-    "@lion/core": "0.18.1",
-    "@lion/localize": "0.20.2"
+    "@lion/core": "0.18.2",
+    "@lion/localize": "0.21.0"
   },
@@ -45,0 +45,0 @@ "keywords": [

README.md

@@ -7,4 +7,4 @@ # Systems >> Form >> Overview ||10
 
-- Built in [validate](https://github.com/ing-bank/lion/blob/0895af24d06146a1ccf9c3904ca18b8a9131efd6/docs/docs/systems/form/validate.md) for error/warning/info/success
+- Built in [validate](https://github.com/ing-bank/lion/blob/e03f8d2cc31563d46f910074d562ad68a2e41dfd/docs/docs/systems/form/validate.md) for error/warning/info/success
 - Formatting of values
 - Accessible

src/NativeTextFieldMixin.js

@@ -70,2 +70,6 @@ import { dedupeMixin } from '@lion/core';
 
+    /**
+     * The view value. Will be delegated to `._inputNode.value`
+     * @override FormatMixin
+     */
     get value() {
@@ -75,8 +79,13 @@ return (this._inputNode && this._inputNode.value) || this.__value || '';
 
-    // We don't delegate, because we want to preserve caret position via _setValueAndPreserveCaret
-    /** @param {string} value */
+    /**
+     * @param {string} value
+     * @override FormatMixin - We don't delegate, because we want to preserve caret position via _setValueAndPreserveCaret
+     */
     set value(value) {
       // if not yet connected to dom can't change the value
       if (this._inputNode) {
-        this._setValueAndPreserveCaret(value);
+        // Only set if newValue is new, fix for Safari bug: https://github.com/ing-bank/lion/issues/1415
+        if (this._inputNode.value !== value) {
+          this._setValueAndPreserveCaret(value);
+        }
         /** @type {string | undefined} */
@@ -83,0 +92,0 @@ this.__value = undefined;

test-helpers/getFormControlMembers.d.ts

@@ -10,3 +10,3 @@ /**
 export function getFormControlMembers(el: FormControlHost): {
-    _inputNode: HTMLInputElement | HTMLTextAreaElement | import("../types/FormControlMixinTypes").HTMLElementWithValue;
+    _inputNode: any;
     _helpTextNode: HTMLElement;
@@ -13,0 +13,0 @@ _labelNode: HTMLElement;

test-helpers/getFormControlMembers.js

@@ -15,3 +15,3 @@ /**
   return {
-    _inputNode,
+    _inputNode: /** @type {* & FormControlHost} */ (el)._inputNode,
     _helpTextNode,
@@ -18,0 +18,0 @@ _labelNode,

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

708958

increased by0.37%

Number of package files

130

increased by1.56%

Lines of code

20611

increased by0.33%

Dependency changes

• + Added@lion/core@0.18.2(transitive)

• + Added@lion/localize@0.21.0(transitive)

• - Removed@lion/core@0.18.1(transitive)

• - Removed@lion/localize@0.20.2(transitive)

• Updated@lion/core@0.18.2

• Updated@lion/localize@0.21.0