@lion/form-core - npm Package Compare versions

Comparing version 0.2.3 to 0.2.4

CHANGELOG.md

@@ -6,2 +6,10 @@ # Change Log
 
+## [0.2.4](https://github.com/ing-bank/lion/compare/@lion/form-core@0.2.3...@lion/form-core@0.2.4) (2020-07-09)
+
+**Note:** Version bump only for package @lion/form-core
+
+
+
+
+
 ## [0.2.3](https://github.com/ing-bank/lion/compare/@lion/form-core@0.2.2...@lion/form-core@0.2.3) (2020-07-09)
@@ -8,0 +16,0 @@

package.json

 {
   "name": "@lion/form-core",
-  "version": "0.2.3",
+  "version": "0.2.4",
   "description": "Form-core contains all essential building blocks for creating form fields and fieldsets",
@@ -45,3 +45,3 @@ "license": "MIT",
   },
-  "gitHead": "cfeb67c9133608be7c203e2ec5cbbee6c4de4f03"
+  "gitHead": "5b9f039457a2e42cfca59bc02620a792a447afc0"
 }

src/validate/ValidateMixin.js

@@ -426,3 +426,3 @@ /* eslint-disable class-methods-use-this, camelcase, no-param-reassign, max-classes-per-file */
           }
-          validationStates[v.type][v.constructor.name] = true;
+          validationStates[v.type][v.constructor.validatorName] = true;
         });
@@ -429,0 +429,0 @@ this.validationStates = validationStates;

test-suites/ValidateMixin.suite.js

@@ -297,3 +297,3 @@ import { LitElement } from '@lion/core';
         static get validatorName() {
-          return 'isCat';
+          return 'IsCat';
         }
@@ -300,0 +300,0 @@ }

test-suites/ValidateMixinFeedbackPart.suite.js

@@ -243,3 +243,3 @@ import { LitElement } from '@lion/core';
           render() {
-            return html`Custom for ${this.feedbackData[0].validator.constructor.name}`;
+            return html`Custom for ${this.feedbackData[0].validator.constructor.validatorName}`;
           }
@@ -246,0 +246,0 @@ },

test/lion-field.test.js

@@ -351,5 +351,4 @@ import { unsafeHTML } from '@lion/core';
       const HasX = class extends Validator {
-        constructor() {
-          super();
-          this.name = 'HasX';
+        static get validatorName() {
+          return 'HasX';
         }
@@ -389,5 +388,4 @@
       const HasX = class extends Validator {
-        constructor() {
-          super();
-          this.name = 'HasX';
+        static get validatorName() {
+          return 'HasX';
         }
@@ -394,0 +392,0 @@

test/validate/DateValidators.test.js

@@ -16,3 +16,3 @@ import { expect } from '@open-wc/testing';
     const validator = new IsDate();
-    expect(validator.constructor.name).to.equal('IsDate');
+    expect(validator.constructor.validatorName).to.equal('IsDate');
 
@@ -32,3 +32,3 @@ isEnabled = validator.execute(new Date());
     const validator = new MinDate(new Date('2018/02/02'));
-    expect(validator.constructor.name).to.equal('MinDate');
+    expect(validator.constructor.validatorName).to.equal('MinDate');
 
@@ -51,3 +51,3 @@ isEnabled = validator.execute(new Date('2018-02-03'));
     const validator = new MaxDate(new Date('2018/02/02'));
-    expect(validator.constructor.name).to.equal('MaxDate');
+    expect(validator.constructor.validatorName).to.equal('MaxDate');
 
@@ -73,3 +73,3 @@ isEnabled = validator.execute(new Date('2018-02-01'));
     });
-    expect(validator.constructor.name).to.equal('MinMaxDate');
+    expect(validator.constructor.validatorName).to.equal('MinMaxDate');
 
@@ -95,3 +95,3 @@ isEnabled = validator.execute(new Date('2018/02/03'));
     const validator = new IsDateDisabled(d => d.getDate() === 3);
-    expect(validator.constructor.name).to.equal('IsDateDisabled');
+    expect(validator.constructor.validatorName).to.equal('IsDateDisabled');
 
@@ -98,0 +98,0 @@ isDisabled = validator.execute(new Date('2018/02/04'));

test/validate/NumberValidators.test.js

@@ -14,3 +14,3 @@ import { expect } from '@open-wc/testing';
     const validator = new IsNumber();
-    expect(validator.constructor.name).to.equal('IsNumber');
+    expect(validator.constructor.validatorName).to.equal('IsNumber');
 
@@ -30,3 +30,3 @@ isEnabled = validator.execute(4);
     const validator = new MinNumber(3);
-    expect(validator.constructor.name).to.equal('MinNumber');
+    expect(validator.constructor.validatorName).to.equal('MinNumber');
 
@@ -43,3 +43,3 @@ isEnabled = validator.execute(3);
     const validator = new MaxNumber(3);
-    expect(validator.constructor.name).to.equal('MaxNumber');
+    expect(validator.constructor.validatorName).to.equal('MaxNumber');
 
@@ -56,3 +56,3 @@ isEnabled = validator.execute(3);
     const validator = new MinMaxNumber({ min: 2, max: 4 });
-    expect(validator.constructor.name).to.equal('MinMaxNumber');
+    expect(validator.constructor.validatorName).to.equal('MinMaxNumber');
 
@@ -59,0 +59,0 @@ isEnabled = validator.execute(2);

test/validate/StringValidators.test.js

@@ -17,3 +17,3 @@ import { expect } from '@open-wc/testing';
     const validator = new IsString();
-    expect(validator.constructor.name).to.equal('IsString');
+    expect(validator.constructor.validatorName).to.equal('IsString');
 
@@ -33,3 +33,3 @@ isEnabled = validator.execute('foo');
     const validator = new EqualsLength(3);
-    expect(validator.constructor.name).to.equal('EqualsLength');
+    expect(validator.constructor.validatorName).to.equal('EqualsLength');
 
@@ -49,3 +49,3 @@ isEnabled = validator.execute('foo');
     const validator = new MinLength(3);
-    expect(validator.constructor.name).to.equal('MinLength');
+    expect(validator.constructor.validatorName).to.equal('MinLength');
 
@@ -62,3 +62,3 @@ isEnabled = validator.execute('foo');
     const validator = new MaxLength(3);
-    expect(validator.constructor.name).to.equal('MaxLength');
+    expect(validator.constructor.validatorName).to.equal('MaxLength');
 
@@ -75,3 +75,3 @@ isEnabled = validator.execute('foo');
     const validator = new MinMaxLength({ min: 2, max: 4 });
-    expect(validator.constructor.name).to.equal('MinMaxLength');
+    expect(validator.constructor.validatorName).to.equal('MinMaxLength');
 
@@ -91,3 +91,3 @@ isEnabled = validator.execute('foo');
     const validator = new IsEmail();
-    expect(validator.constructor.name).to.equal('IsEmail');
+    expect(validator.constructor.validatorName).to.equal('IsEmail');
 
@@ -94,0 +94,0 @@ isEnabled = validator.execute('[e-mail]');

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

341580

increased by0.09%

Worsened metrics

Lines of code

8248

decreased by-0.02%

No dependency changes