@lion/form-core - npm Package Compare versions

Comparing version 0.6.7 to 0.6.8

CHANGELOG.md

 # Change Log
 
+## 0.6.8
+
+### Patch Changes
+
+- b222fd78: Always use CSSResultArray for styles getters and be consistent. This makes typing for subclassers significantly easier. Also added some fixes for missing types in mixins where the superclass was not typed properly. This highlighted some issues with incomplete mixin contracts
+
 ## 0.6.7
@@ -4,0 +10,0 @@

package.json

 {
   "name": "@lion/form-core",
-  "version": "0.6.7",
+  "version": "0.6.8",
   "description": "Form-core contains all essential building blocks for creating form fields and fieldsets",
@@ -5,0 +5,0 @@ "license": "MIT",

src/choice-group/ChoiceInputMixin.js

@@ -139,3 +139,5 @@ /* eslint-disable class-methods-use-this */
     static get styles() {
+      const superCtor = /** @type {typeof import('@lion/core').LitElement} */ (super.constructor);
       return [
+        superCtor.styles ? superCtor.styles : [],
         css`
@@ -142,0 +144,0 @@ :host {

src/FormControlMixin.js

@@ -616,56 +616,58 @@ import { css, dedupeMixin, html, nothing, SlotMixin } from '@lion/core';
      * - {element} .input-group__after (optional) :  a suffix that resides outside the container
-     *
-     * @return {CSSResult | CSSResult[]}
      */
     static get styles() {
-      return css`
-        /**********************
+      const superCtor = /** @type {typeof import('@lion/core').LitElement} */ (super.constructor);
+      return [
+        superCtor.styles ? superCtor.styles : [],
+        css`
+          /**********************
             {block} .form-field
-         ********************/
+           ********************/
 
-        :host {
-          display: block;
-        }
+          :host {
+            display: block;
+          }
 
-        :host([hidden]) {
-          display: none;
-        }
+          :host([hidden]) {
+            display: none;
+          }
 
-        :host([disabled]) {
-          pointer-events: none;
-        }
+          :host([disabled]) {
+            pointer-events: none;
+          }
 
-        :host([disabled]) .form-field__label ::slotted(*),
-        :host([disabled]) .form-field__help-text ::slotted(*) {
-          color: var(--disabled-text-color, #767676);
-        }
+          :host([disabled]) .form-field__label ::slotted(*),
+          :host([disabled]) .form-field__help-text ::slotted(*) {
+            color: var(--disabled-text-color, #767676);
+          }
 
-        /***********************
+          /***********************
             {block} .input-group
-         *********************/
+           *********************/
 
-        .input-group__container {
-          display: flex;
-        }
+          .input-group__container {
+            display: flex;
+          }
 
-        .input-group__input {
-          flex: 1;
-          display: flex;
-        }
+          .input-group__input {
+            flex: 1;
+            display: flex;
+          }
 
-        /***** {state} :disabled *****/
-        :host([disabled]) .input-group ::slotted(slot='input') {
-          color: var(--disabled-text-color, #767676);
-        }
+          /***** {state} :disabled *****/
+          :host([disabled]) .input-group ::slotted(slot='input') {
+            color: var(--disabled-text-color, #767676);
+          }
 
-        /***********************
+          /***********************
             {block} .form-control
-         **********************/
+           **********************/
 
-        .input-group__container > .input-group__input ::slotted(.form-control) {
-          flex: 1 1 auto;
-          margin: 0; /* remove input margin in Safari */
-          font-size: 100%; /* normalize default input font-size */
-        }
-      `;
+          .input-group__container > .input-group__input ::slotted(.form-control) {
+            flex: 1 1 auto;
+            margin: 0; /* remove input margin in Safari */
+            font-size: 100%; /* normalize default input font-size */
+          }
+        `,
+      ];
     }
@@ -672,0 +674,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

312748

increased by0.21%

Lines of code

7546

increased by0.05%

No dependency changes