@lion/form-core - npm Package Compare versions

Comparing version 0.8.3 to 0.8.4

CHANGELOG.md

 # Change Log
 
+## 0.8.4
+
+### Patch Changes
+
+- 6b91c92d: Remove .prototype accessor when accessing super.constructor from a constructor. This causes maximum call stack exceeded in latest chrome.
+- 701aadce: Fix types of mixins to include LitElement static props and methods, and use Pick generic type instead of fake constructors.
+- Updated dependencies [701aadce]
+  - @lion/core@0.14.1
+  - @lion/localize@0.16.1
+
 ## 0.8.3
@@ -4,0 +14,0 @@

package.json

 {
   "name": "@lion/form-core",
-  "version": "0.8.3",
+  "version": "0.8.4",
   "description": "Form-core contains all essential building blocks for creating form fields and fieldsets",
@@ -39,4 +39,4 @@ "license": "MIT",
   "dependencies": {
-    "@lion/core": "0.14.0",
-    "@lion/localize": "0.16.0"
+    "@lion/core": "0.14.1",
+    "@lion/localize": "0.16.1"
   },
@@ -43,0 +43,0 @@ "keywords": [

src/choice-group/ChoiceInputMixin.js

@@ -139,6 +139,4 @@ /* eslint-disable class-methods-use-this */
     static get styles() {
-      const superCtor = /** @type {typeof import('@lion/core').LitElement} */ (super.prototype
-        .constructor);
       return [
-        superCtor.styles ? superCtor.styles : [],
+        super.styles || [],
         css`
@@ -145,0 +143,0 @@ :host {

src/form-group/FormGroupMixin.js

@@ -391,5 +391,5 @@ import { dedupeMixin, html, SlotMixin, DisabledMixin } from '@lion/core';
         if (Array.isArray(this.formElements[name])) {
-          return this.formElements[name].some((/** @type {FormControl} */ el) => {
-            return Boolean(el.hasFeedbackFor && el.hasFeedbackFor.includes(state));
-          });
+          return this.formElements[name].some((/** @type {FormControl} */ el) =>
+            Boolean(el.hasFeedbackFor && el.hasFeedbackFor.includes(state)),
+          );
         }
@@ -396,0 +396,0 @@ return Boolean(

src/FormControlMixin.js

@@ -35,2 +35,3 @@ import { css, dedupeMixin, html, nothing, SlotMixin, DisabledMixin } from '@lion/core';
   class FormControlMixin extends FormRegisteringMixin(DisabledMixin(SlotMixin(superclass))) {
+    /** @type {any} */
     static get properties() {
@@ -620,6 +621,4 @@ return {
     static get styles() {
-      const superCtor = /** @type {typeof import('@lion/core').LitElement} */ (super.prototype
-        .constructor);
       return [
-        superCtor.styles ? superCtor.styles : [],
+        super.styles || [],
         css`
@@ -626,0 +625,0 @@ /**********************

src/LionField.d.ts

@@ -1,2 +0,5 @@
-declare const LionField_base: typeof LitElement & import("@open-wc/dedupe-mixin").Constructor<import("@lion/core/types/SlotMixinTypes").SlotHost> & typeof import("@lion/core/types/SlotMixinTypes").SlotHost & import("@open-wc/dedupe-mixin").Constructor<import("../types/validate/ValidateMixinTypes.js").ValidateHost> & typeof import("../types/validate/ValidateMixinTypes.js").ValidateHost & import("@open-wc/dedupe-mixin").Constructor<import("../types/FormControlMixinTypes.js").FormControlHost> & typeof import("../types/FormControlMixinTypes.js").FormControlHost & import("@open-wc/dedupe-mixin").Constructor<import("../types/utils/SyncUpdatableMixinTypes.js").SyncUpdatableHost> & typeof import("../types/utils/SyncUpdatableMixinTypes.js").SyncUpdatableHost & import("@open-wc/dedupe-mixin").Constructor<import("@lion/core/types/DisabledMixinTypes").DisabledHost> & typeof import("@lion/core/types/DisabledMixinTypes").DisabledHost & import("@open-wc/dedupe-mixin").Constructor<import("@open-wc/scoped-elements/src/types").ScopedElementsHost> & typeof import("@open-wc/scoped-elements/src/types").ScopedElementsHost & import("@open-wc/dedupe-mixin").Constructor<import("../types/FormatMixinTypes.js").FormatHost> & import("../types/FormatMixinTypes.js").FormatHost & import("@open-wc/dedupe-mixin").Constructor<import("../types/FocusMixinTypes.js").FocusHost> & import("../types/FocusMixinTypes.js").FocusHost & import("@open-wc/dedupe-mixin").Constructor<import("../types/InteractionStateMixinTypes.js").InteractionStateHost> & typeof import("../types/InteractionStateMixinTypes.js").InteractionStateHost & import("@open-wc/dedupe-mixin").Constructor<import("../types/registration/FormRegisteringMixinTypes.js").FormRegisteringHost> & typeof import("../types/registration/FormRegisteringMixinTypes.js").FormRegisteringHost;
+declare const LionField_base: typeof LitElement & import("@open-wc/dedupe-mixin").Constructor<import("@lion/core/types/SlotMixinTypes").SlotHost> & Pick<typeof import("@lion/core/types/SlotMixinTypes").SlotHost, "prototype"> & Pick<{
+    new (): HTMLElement;
+    prototype: HTMLElement;
+}, "prototype"> & import("@open-wc/dedupe-mixin").Constructor<import("../types/validate/ValidateMixinTypes.js").ValidateHost> & Pick<typeof import("../types/validate/ValidateMixinTypes.js").ValidateHost, "prototype" | "validationTypes"> & import("@open-wc/dedupe-mixin").Constructor<import("../types/FormControlMixinTypes.js").FormControlHost> & Pick<typeof import("../types/FormControlMixinTypes.js").FormControlHost, "prototype" | "styles" | "properties"> & import("@open-wc/dedupe-mixin").Constructor<import("../types/utils/SyncUpdatableMixinTypes.js").SyncUpdatableHost> & Pick<typeof import("../types/utils/SyncUpdatableMixinTypes.js").SyncUpdatableHost, "prototype" | "__syncUpdatableHasChanged"> & import("@open-wc/dedupe-mixin").Constructor<import("@lion/core/types/DisabledMixinTypes").DisabledHost> & Pick<typeof import("@lion/core/types/DisabledMixinTypes").DisabledHost, "prototype"> & import("@open-wc/dedupe-mixin").Constructor<import("@open-wc/scoped-elements/src/types").ScopedElementsHost> & Pick<typeof import("@open-wc/scoped-elements/src/types").ScopedElementsHost, "prototype" | "scopedElements" | "getScopedTagName"> & Pick<typeof LitElement, "prototype" | "render" | "styles" | "getStyles" | "properties" | "observedAttributes" | "createProperty"> & import("@open-wc/dedupe-mixin").Constructor<import("../types/FormatMixinTypes.js").FormatHost> & Pick<typeof import("../types/FormatMixinTypes.js").FormatHost, "prototype"> & import("@open-wc/dedupe-mixin").Constructor<import("../types/FocusMixinTypes.js").FocusHost> & Pick<typeof import("../types/FocusMixinTypes.js").FocusHost, "prototype"> & import("@open-wc/dedupe-mixin").Constructor<import("../types/InteractionStateMixinTypes.js").InteractionStateHost> & Pick<typeof import("../types/InteractionStateMixinTypes.js").InteractionStateHost, "prototype"> & import("@open-wc/dedupe-mixin").Constructor<import("../types/registration/FormRegisteringMixinTypes.js").FormRegisteringHost> & Pick<typeof import("../types/registration/FormRegisteringMixinTypes.js").FormRegisteringHost, "prototype">;
 /**
@@ -3,0 +6,0 @@ * `LionField`: wraps <input>, <textarea>, <select> and other interactable elements.

types/choice-group/ChoiceGroupMixinTypes.d.ts

@@ -8,3 +8,2 @@ import { Constructor } from '@open-wc/dedupe-mixin';
 export declare class ChoiceGroupHost {
-  constructor(...args: any[]);
   multipleChoice: boolean;
@@ -58,8 +57,9 @@
   Constructor<ChoiceGroupHost> &
-  ChoiceGroupHost &
+  Pick<typeof ChoiceGroupHost, keyof typeof ChoiceGroupHost> &
   Constructor<FormRegistrarHost> &
-  typeof FormRegistrarHost &
+  Pick<typeof FormRegistrarHost, keyof typeof FormRegistrarHost> &
   Constructor<InteractionStateHost> &
-  typeof InteractionStateHost;
+  Pick<typeof InteractionStateHost, keyof typeof InteractionStateHost> &
+  Pick<typeof LitElement, keyof typeof LitElement>;
 
 export type ChoiceGroupMixin = typeof ChoiceGroupImplementation;

types/choice-group/ChoiceInputMixinTypes.d.ts

@@ -18,3 +18,2 @@ import { Constructor } from '@open-wc/dedupe-mixin';
 export declare class ChoiceInputHost {
-  constructor(...args: any[]);
   modelValue: ChoiceInputModelValue;
@@ -83,7 +82,7 @@ serializedValue: ChoiceInputSerializedValue;
   Constructor<ChoiceInputHost> &
-  ChoiceInputHost &
+  Pick<typeof ChoiceInputHost, keyof typeof ChoiceInputHost> &
   Constructor<FormatHost> &
-  FormatHost &
-  HTMLElement;
+  Pick<typeof FormatHost, keyof typeof FormatHost> &
+  Pick<typeof LitElement, keyof typeof LitElement>;
 
 export type ChoiceInputMixin = typeof ChoiceInputImplementation;

types/FocusMixinTypes.d.ts

@@ -6,3 +6,2 @@ import { Constructor } from '@open-wc/dedupe-mixin';
 export declare class FocusHost {
-  constructor(...args: any[]);
   focused: boolean;
@@ -23,4 +22,9 @@
   superclass: T,
-): T & Constructor<FocusHost> & FocusHost & Constructor<FormControlHost> & typeof FormControlHost;
+): T &
+  Constructor<FocusHost> &
+  Pick<typeof FocusHost, keyof typeof FocusHost> &
+  Constructor<FormControlHost> &
+  Pick<typeof FormControlHost, keyof typeof FormControlHost> &
+  Pick<typeof LitElement, keyof typeof LitElement>;
 
 export type FocusMixin = typeof FocusImplementation;

types/form-group/FormGroupMixinTypes.d.ts

@@ -10,3 +10,2 @@ import { Constructor } from '@open-wc/dedupe-mixin';
 export declare class FormGroupHost {
-  constructor(...args: any[]);
   protected static _addDescriptionElementIdsToField(): void;
@@ -34,14 +33,15 @@ _inputNode: HTMLElement;
   Constructor<FormGroupHost> &
-  typeof FormGroupHost &
+  Pick<typeof FormGroupHost, keyof typeof FormGroupHost> &
   Constructor<FormRegistrarHost> &
-  typeof FormRegistrarHost &
+  Pick<typeof FormRegistrarHost, keyof typeof FormRegistrarHost> &
   Constructor<FormControlHost> &
-  typeof FormControlHost &
+  Pick<typeof FormControlHost, keyof typeof FormControlHost> &
   Constructor<ValidateHost> &
-  typeof ValidateHost &
+  Pick<typeof ValidateHost, keyof typeof ValidateHost> &
   Constructor<DisabledHost> &
-  typeof DisabledHost &
+  Pick<typeof DisabledHost, keyof typeof DisabledHost> &
   Constructor<SlotHost> &
-  typeof SlotHost;
+  Pick<typeof SlotHost, keyof typeof SlotHost> &
+  Pick<typeof LitElement, keyof typeof LitElement>;
 
 export type FormGroupMixin = typeof FormGroupImplementation;

types/FormatMixinTypes.d.ts

@@ -8,3 +8,2 @@ import { Constructor } from '@open-wc/dedupe-mixin';
 export declare class FormatHost {
-  constructor(...args: any[]);
   formattedValue: string;
@@ -45,8 +44,9 @@ serializedValue: string;
   Constructor<FormatHost> &
-  FormatHost &
+  Pick<typeof FormatHost, keyof typeof FormatHost> &
   Constructor<ValidateHost> &
-  typeof ValidateHost &
+  Pick<typeof ValidateHost, keyof typeof ValidateHost> &
   Constructor<FormControlHost> &
-  typeof FormControlHost;
+  Pick<typeof FormControlHost, keyof typeof FormControlHost> &
+  Pick<typeof LitElement, keyof typeof LitElement>;
 
 export type FormatMixin = typeof FormatImplementation;

types/FormControlMixinTypes.d.ts

@@ -39,3 +39,2 @@ import { LitElement, nothing, TemplateResult, CSSResultArray } from '@lion/core';
 export declare class FormControlHost {
-  constructor(...args: any[]);
   static get styles(): CSSResultArray;
@@ -180,10 +179,11 @@ static get properties(): {
   Constructor<FormControlHost> &
-  typeof FormControlHost &
+  Pick<typeof FormControlHost, keyof typeof FormControlHost> &
   Constructor<FormRegisteringHost> &
-  typeof FormRegisteringHost &
+  Pick<typeof FormRegisteringHost, keyof typeof FormRegisteringHost> &
   Constructor<DisabledHost> &
-  typeof DisabledHost &
+  Pick<typeof DisabledHost, keyof typeof DisabledHost> &
   Constructor<SlotHost> &
-  typeof SlotHost;
+  Pick<typeof SlotHost, keyof typeof SlotHost> &
+  Pick<typeof LitElement, keyof typeof LitElement>;
 
 export type FormControlMixin = typeof FormControlImplementation;

types/InteractionStateMixinTypes.d.ts

@@ -6,3 +6,2 @@ import { Constructor } from '@open-wc/dedupe-mixin';
 export declare class InteractionStateHost {
-  constructor(...args: any[]);
   prefilled: boolean;
@@ -31,6 +30,7 @@ filled: boolean;
   Constructor<InteractionStateHost> &
-  typeof InteractionStateHost &
+  Pick<typeof InteractionStateHost, keyof typeof InteractionStateHost> &
   Constructor<FormControlHost> &
-  typeof FormControlHost;
+  Pick<typeof FormControlHost, keyof typeof FormControlHost> &
+  Pick<typeof LitElement, keyof typeof LitElement>;
 
 export type InteractionStateMixin = typeof InteractionStateImplementation;

types/NativeTextFieldMixinTypes.d.ts

@@ -9,3 +9,2 @@ import { Constructor } from '@open-wc/dedupe-mixin';
 export declare class NativeTextFieldHost {
-  constructor(...args: any[]);
   get selectionStart(): number;
@@ -19,4 +18,7 @@ set selectionStart(value: number);
   superclass: T,
-): T & Constructor<NativeTextFieldHost> & NativeTextFieldHost & typeof NativeTextField;
+): T &
+  Constructor<NativeTextFieldHost> &
+  Pick<typeof NativeTextFieldHost, keyof typeof NativeTextFieldHost> &
+  Pick<typeof NativeTextField, keyof typeof NativeTextField>;
 
 export type NativeTextFieldMixin = typeof NativeTextFieldImplementation;

types/registration/FormRegisteringMixinTypes.d.ts

@@ -6,3 +6,2 @@ import { Constructor } from '@open-wc/dedupe-mixin';
 export declare class FormRegisteringHost {
-  constructor(...args: any[]);
   connectedCallback(): void;
@@ -15,4 +14,7 @@ disconnectedCallback(): void;
   superclass: T,
-): T & Constructor<FormRegisteringHost> & typeof FormRegisteringHost;
+): T &
+  Constructor<FormRegisteringHost> &
+  Pick<typeof FormRegisteringHost, keyof typeof FormRegisteringHost> &
+  Pick<typeof LitElement, keyof typeof LitElement>;
 
 export type FormRegisteringMixin = typeof FormRegisteringImplementation;

types/registration/FormRegistrarMixinTypes.d.ts

@@ -12,3 +12,2 @@ import { Constructor } from '@open-wc/dedupe-mixin';
 export declare class FormRegistrarHost {
-  constructor(...args: any[]);
   _isFormOrFieldset: boolean;
@@ -33,6 +32,7 @@ formElements: FormControlsCollection & { [x: string]: any };
   Constructor<FormRegistrarHost> &
-  typeof FormRegistrarHost &
+  Pick<typeof FormRegistrarHost, keyof typeof FormRegistrarHost> &
   Constructor<FormRegisteringHost> &
-  typeof FormRegisteringHost;
+  Pick<typeof FormRegisteringHost, keyof typeof FormRegisteringHost> &
+  Pick<typeof LitElement, keyof typeof LitElement>;
 
 export type FormRegistrarMixin = typeof FormRegistrarImplementation;

types/registration/FormRegistrarPortalMixinTypes.d.ts

@@ -5,3 +5,2 @@ import { Constructor } from '@open-wc/dedupe-mixin';
 export declare class FormRegistrarPortalHost {
-  constructor(...args: any[]);
   registrationTarget: HTMLElement;
@@ -13,4 +12,7 @@ __redispatchEventForFormRegistrarPortalMixin(ev: CustomEvent): void;
   superclass: T,
-): T & Constructor<FormRegistrarPortalHost> & FormRegistrarPortalHost;
+): T &
+  Constructor<FormRegistrarPortalHost> &
+  Pick<typeof FormRegistrarPortalHost, keyof typeof FormRegistrarPortalHost> &
+  Pick<typeof LitElement, keyof typeof LitElement>;
 
 export type FormRegistrarPortalMixin = typeof FormRegistrarPortalImplementation;

types/utils/SyncUpdatableMixinTypes.d.ts

@@ -13,3 +13,2 @@ import { LitElement } from '@lion/core';
 export declare class SyncUpdatableHost {
-  constructor(...args: any[]);
   static __syncUpdatableHasChanged(name: string, newValue: any, oldValue: any): boolean;
@@ -28,4 +27,7 @@ updateSync(name: string, oldValue: any): void;
   superclass: T,
-): T & Constructor<SyncUpdatableHost> & typeof SyncUpdatableHost;
+): T &
+  Constructor<SyncUpdatableHost> &
+  Pick<typeof SyncUpdatableHost, keyof typeof SyncUpdatableHost> &
+  Pick<typeof LitElement, keyof typeof LitElement>;
 
 export type SyncUpdatableMixin = typeof SyncUpdatableImplementation;

types/validate/ValidateMixinTypes.d.ts

@@ -22,3 +22,2 @@ import { LitElement } from '@lion/core';
 export declare class ValidateHost {
-  constructor(...args: any[]);
   validators: Validator[];
@@ -80,14 +79,15 @@ hasFeedbackFor: string[];
   Constructor<ValidateHost> &
-  typeof ValidateHost &
+  Pick<typeof ValidateHost, keyof typeof ValidateHost> &
   Constructor<FormControlHost> &
-  typeof FormControlHost &
+  Pick<typeof FormControlHost, keyof typeof FormControlHost> &
   Constructor<SyncUpdatableHost> &
-  typeof SyncUpdatableHost &
+  Pick<typeof SyncUpdatableHost, keyof typeof SyncUpdatableHost> &
   Constructor<DisabledHost> &
-  typeof DisabledHost &
+  Pick<typeof DisabledHost, keyof typeof DisabledHost> &
   Constructor<SlotHost> &
-  typeof SlotHost &
+  Pick<typeof SlotHost, keyof typeof SlotHost> &
   Constructor<ScopedElementsHost> &
-  typeof ScopedElementsHost;
+  Pick<typeof ScopedElementsHost, keyof typeof ScopedElementsHost> &
+  Pick<typeof LitElement, keyof typeof LitElement>;
 
 export type ValidateMixin = typeof ValidateImplementation;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

638341

increased by0.69%

Lines of code

18738

increased by0.14%

Dependency changes

• + Added@lion/core@0.14.1(transitive)

• + Added@lion/localize@0.16.1(transitive)

• - Removed@lion/core@0.14.0(transitive)

• - Removed@lion/localize@0.16.0(transitive)

• Updated@lion/core@0.14.1

• Updated@lion/localize@0.16.1