@lion/form-core - npm Package Compare versions

Comparing version 0.8.4 to 0.8.5

CHANGELOG.md

 # Change Log
 
+## 0.8.5
+
+### Patch Changes
+
+- dbacafa5: Type static get properties as {any} since the real class fields are typed separately and lit properties are just "configuring". Remove expect error.
+
 ## 0.8.4
@@ -4,0 +10,0 @@

package.json

 {
   "name": "@lion/form-core",
-  "version": "0.8.4",
+  "version": "0.8.5",
   "description": "Form-core contains all essential building blocks for creating form fields and fieldsets",
@@ -5,0 +5,0 @@ "license": "MIT",

src/choice-group/ChoiceGroupMixin.js

@@ -18,4 +18,4 @@ import { dedupeMixin } from '@lion/core';
 const ChoiceGroupMixinImplementation = superclass =>
-  // @ts-expect-error false positive for incompatible static get properties. Lit-element merges super properties already for you.
   class ChoiceGroupMixin extends FormRegistrarMixin(InteractionStateMixin(superclass)) {
+    /** @type {any} */
     static get properties() {
@@ -22,0 +22,0 @@ return {

src/choice-group/ChoiceInputMixin.js

@@ -24,4 +24,4 @@ /* eslint-disable class-methods-use-this */
 const ChoiceInputMixinImplementation = superclass =>
-  // @ts-expect-error false positive for incompatible static get properties. Lit-element merges super properties already for you.
   class ChoiceInputMixin extends FormatMixin(superclass) {
+    /** @type {any} */
     static get properties() {
@@ -28,0 +28,0 @@ return {

src/FocusMixin.js

@@ -9,5 +9,4 @@ import { dedupeMixin } from '@lion/core';
 const FocusMixinImplementation = superclass =>
-  // @ts-expect-error false positive for incompatible static get properties. Lit-element merges super properties already for you.
-  // eslint-disable-next-line no-unused-vars, max-len, no-shadow
   class FocusMixin extends FormControlMixin(superclass) {
+    /** @type {any} */
     static get properties() {
@@ -14,0 +13,0 @@ return {

src/form-group/FormGroupMixin.js

@@ -31,6 +31,6 @@ import { dedupeMixin, html, SlotMixin, DisabledMixin } from '@lion/core';
 const FormGroupMixinImplementation = superclass =>
-  // @ts-expect-error false positive for incompatible static get properties. Lit-element merges super properties already for you.
   class FormGroupMixin extends FormRegistrarMixin(
     FormControlMixin(ValidateMixin(DisabledMixin(SlotMixin(superclass)))),
   ) {
+    /** @type {any} */
     static get properties() {
@@ -37,0 +37,0 @@ return {

src/FormatMixin.js

@@ -61,4 +61,4 @@ /* eslint-disable class-methods-use-this */
 const FormatMixinImplementation = superclass =>
-  // @ts-expect-error false positive for incompatible static get properties. Lit-element merges super properties already for you.
   class FormatMixin extends ValidateMixin(FormControlMixin(superclass)) {
+    /** @type {any} */
     static get properties() {
@@ -65,0 +65,0 @@ return {

src/InteractionStateMixin.js

@@ -21,4 +21,4 @@ import { dedupeMixin } from '@lion/core';
 const InteractionStateMixinImplementation = superclass =>
-  // @ts-expect-error false positive for incompatible static get properties. Lit-element merges super properties already for you.
   class InteractionStateMixin extends FormControlMixin(superclass) {
+    /** @type {any} */
     static get properties() {
@@ -25,0 +25,0 @@ return {

src/LionField.d.ts

@@ -23,11 +23,4 @@ declare const LionField_base: typeof LitElement & import("@open-wc/dedupe-mixin").Constructor<import("@lion/core/types/SlotMixinTypes").SlotHost> & Pick<typeof import("@lion/core/types/SlotMixinTypes").SlotHost, "prototype"> & Pick<{
 export class LionField extends LionField_base {
-    static get properties(): {
-        autocomplete: {
-            type: StringConstructor;
-            reflect: boolean;
-        };
-        value: {
-            type: StringConstructor;
-        };
-    };
+    /** @type {any} */
+    static get properties(): any;
     /** @type {string | undefined} */
@@ -34,0 +27,0 @@ autocomplete: string | undefined;

src/LionField.js

@@ -25,6 +25,6 @@ import { LitElement, SlotMixin } from '@lion/core';
  */
-// @ts-expect-error lit properties false positive
 export class LionField extends FormControlMixin(
   InteractionStateMixin(FocusMixin(FormatMixin(ValidateMixin(SlotMixin(LitElement))))),
 ) {
+  /** @type {any} */
   static get properties() {
@@ -31,0 +31,0 @@ return {

src/validate/ValidateMixin.js

@@ -35,3 +35,2 @@ /* eslint-disable class-methods-use-this, camelcase, no-param-reassign, max-classes-per-file */
 export const ValidateMixinImplementation = superclass =>
-  // @ts-expect-error false positive for incompatible static get properties. Lit-element merges super properties already for you.
   class extends FormControlMixin(
@@ -49,2 +48,3 @@ SyncUpdatableMixin(DisabledMixin(SlotMixin(ScopedElementsMixin(superclass)))),
 
+    /** @type {any} */
     static get properties() {
@@ -51,0 +51,0 @@ return {

test/validate/Validator.test.js

@@ -137,4 +137,4 @@ import { LitElement } from '@lion/core';
     const lightDom = '';
-    // @ts-expect-error false positive for incompatible static get properties. Lit-element merges super properties already for you.
     class ValidateElement extends ValidateMixin(LitElement) {
+      /** @type {any} */
       static get properties() {
@@ -141,0 +141,0 @@ return { modelValue: String };

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Lines of code

18751

increased by0.07%

Worsened metrics

Total package byte prevSize

637931

decreased by-0.06%

No dependency changes