@lion/validate - npm Package Compare versions

Comparing version 0.7.1 to 0.8.0

CHANGELOG.md

@@ -6,2 +6,13 @@ # Change Log
 
+# [0.8.0](https://github.com/ing-bank/lion/compare/@lion/validate@0.7.1...@lion/validate@0.8.0) (2020-03-05)
+
+
+### Features
+
+* use Scoped Elements ([15b4a5e](https://github.com/ing-bank/lion/commit/15b4a5ebb388e158f6dc2529954ba6a23f325eb3))
+
+
+
+
+
 ## [0.7.1](https://github.com/ing-bank/lion/compare/@lion/validate@0.7.0...@lion/validate@0.7.1) (2020-03-04)
@@ -8,0 +19,0 @@

package.json

 {
   "name": "@lion/validate",
-  "version": "0.7.1",
+  "version": "0.8.0",
   "description": "Validate your form elements",
@@ -39,4 +39,5 @@ "author": "ing-bank",
   "dependencies": {
-    "@lion/core": "0.4.4",
-    "@lion/localize": "0.8.9"
+    "@lion/core": "0.4.5",
+    "@lion/localize": "0.8.10",
+    "@open-wc/scoped-elements": "^0.5.0"
   },
@@ -48,3 +49,3 @@ "devDependencies": {
   },
-  "gitHead": "52eeafa745328c3ea832ca117c662b2b731e22d2"
+  "gitHead": "54c4432b818cf1f6023557d0df5c461ae50412da"
 }

src/ValidateMixin.js

 /* eslint-disable class-methods-use-this, camelcase, no-param-reassign, max-classes-per-file */
 
-import { dedupeMixin, SlotMixin } from '@lion/core';
+import { dedupeMixin, SlotMixin, ScopedElementsMixin, getScopedTagName } from '@lion/core';
 import { localize } from '@lion/localize';
+import { LionValidationFeedback } from './LionValidationFeedback.js';
 import { ResultValidator } from './ResultValidator.js';
@@ -27,3 +28,10 @@ import { Unparseable } from './Unparseable.js';
     // eslint-disable-next-line no-unused-vars, no-shadow
-    class ValidateMixin extends SyncUpdatableMixin(SlotMixin(superclass)) {
+    class ValidateMixin extends ScopedElementsMixin(SyncUpdatableMixin(SlotMixin(superclass))) {
+      static get scopedElements() {
+        return {
+          ...super.scopedElements,
+          'lion-validation-feedback': LionValidationFeedback,
+        };
+      }
+
       static get properties() {
@@ -112,3 +120,6 @@ return {
           ...super.slots,
-          feedback: () => document.createElement('lion-validation-feedback'),
+          feedback: () =>
+            document.createElement(
+              getScopedTagName('lion-validation-feedback', this.constructor.scopedElements),
+            ),
         };
@@ -186,9 +197,2 @@ }
 
-      /**
-       * Should be overridden by subclasses if a different validation-feedback component is used
-       */
-      async _loadFeedbackComponent() {
-        await import('../lion-validation-feedback.js');
-      }
-
       firstUpdated(changedProperties) {
@@ -198,3 +202,2 @@ super.firstUpdated(changedProperties);
         this.validate();
-        this._loadFeedbackComponent();
       }
@@ -201,0 +204,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

212218

increased by0.2%

Lines of code

4436

increased by0.07%

Worsened metrics

Dependency count

3

increased by50%

Dependency changes

• + Added@open-wc/scoped-elements@^0.5.0

• + Added@lion/core@0.4.5(transitive)

• + Added@lion/localize@0.8.10(transitive)

• + Added@open-wc/dedupe-mixin@1.4.0(transitive)

• + Added@open-wc/scoped-elements@0.5.0(transitive)

• - Removed@lion/core@0.4.4(transitive)

• - Removed@lion/localize@0.8.9(transitive)

• Updated@lion/core@0.4.5

• Updated@lion/localize@0.8.10