@loomhq/loom-embed - npm Package Compare versions

Comparing version 1.2.5 to 1.2.6

dist/.types/oembed.d.ts

@@ -9,4 +9,4 @@ interface Option {
     title: string;
-    height: number;
-    width: number;
+    height: number | null;
+    width: number | null;
     provider_name: 'Loom';
@@ -13,0 +13,0 @@ provider_url: string;

dist/cjs/oembed.js

@@ -11,6 +11,19 @@ "use strict";
     const iframeStyles = 'position: absolute; top: 0; left: 0; width: 100%; height: 100%;';
-    return (`<div class="lo-emb-vid" style="${wrapperStyles}"><iframe src="${embedURL}" ` +
-        'frameborder="0" webkitallowfullscreen mozallowfullscreen ' +
-        `allowfullscreen style="${iframeStyles}"></iframe></div>`);
+    const staticAttributes = 'frameborder="0" webkitallowfullscreen mozallowfullscreen allowfullscreen';
+    return `
+<div class="lo-emb-vid" style="${wrapperStyles}">
+  <iframe src="${embedURL}" style="${iframeStyles}" ${staticAttributes}></iframe>
+</div>`
+        .split('\n')
+        .map(s => s.trim())
+        .join('');
 };
+const chooseAspectRatio = (data) => {
+    const { width, height } = data;
+    // Fallback to 16:9 ratio when width or height is null
+    if (width == null || height == null) {
+        return 1080 / 1920;
+    }
+    return height / width;
+};
 const enhanceEmbedCode = (videoData, options) => {
@@ -20,6 +33,5 @@ // If needed, we alter the embed code to
     const { width, height } = options;
-    const { width: videoWidth, height: videoHeight } = videoData;
     if (!width && !height) {
         const [, embedUrl] = videoData.html.match(SRC_URL_REGEX);
-        const aspectRatio = videoHeight / videoWidth;
+        const aspectRatio = chooseAspectRatio(videoData);
         return Object.assign(Object.assign({}, videoData), { html: getResponsiveEmbedCode(embedUrl, aspectRatio) });
@@ -26,0 +38,0 @@ }

dist/cjs/oembed.test.js

@@ -34,3 +34,3 @@ "use strict";
         const result = yield oembed_1.oembed('https://www.loom.com/share/0281766fa2d04bb788eaf19e65135184');
-        expect(result).toEqual(Object.assign(Object.assign({}, oembedProperties), { html: '<div class="lo-emb-vid" style="position: relative; padding-bottom: 100%; height: 0;"><iframe src="https://www.loom.com/embed/0281766fa2d04bb788eaf19e65135184" frameborder="0" webkitallowfullscreen mozallowfullscreen allowfullscreen style="position: absolute; top: 0; left: 0; width: 100%; height: 100%;"></iframe></div>' }));
+        expect(result).toEqual(Object.assign(Object.assign({}, oembedProperties), { html: '<div class="lo-emb-vid" style="position: relative; padding-bottom: 100%; height: 0;"><iframe src="https://www.loom.com/embed/0281766fa2d04bb788eaf19e65135184" style="position: absolute; top: 0; left: 0; width: 100%; height: 100%;" frameborder="0" webkitallowfullscreen mozallowfullscreen allowfullscreen></iframe></div>' }));
     }));
@@ -37,0 +37,0 @@ test('wth options', () => __awaiter(void 0, void 0, void 0, function* () {

dist/esm/oembed.js

@@ -8,6 +8,19 @@ import { isValidEmbedUrl } from './validate';
     const iframeStyles = 'position: absolute; top: 0; left: 0; width: 100%; height: 100%;';
-    return (`<div class="lo-emb-vid" style="${wrapperStyles}"><iframe src="${embedURL}" ` +
-        'frameborder="0" webkitallowfullscreen mozallowfullscreen ' +
-        `allowfullscreen style="${iframeStyles}"></iframe></div>`);
+    const staticAttributes = 'frameborder="0" webkitallowfullscreen mozallowfullscreen allowfullscreen';
+    return `
+<div class="lo-emb-vid" style="${wrapperStyles}">
+  <iframe src="${embedURL}" style="${iframeStyles}" ${staticAttributes}></iframe>
+</div>`
+        .split('\n')
+        .map(s => s.trim())
+        .join('');
 };
+const chooseAspectRatio = (data) => {
+    const { width, height } = data;
+    // Fallback to 16:9 ratio when width or height is null
+    if (width == null || height == null) {
+        return 1080 / 1920;
+    }
+    return height / width;
+};
 const enhanceEmbedCode = (videoData, options) => {
@@ -17,6 +30,5 @@ // If needed, we alter the embed code to
     const { width, height } = options;
-    const { width: videoWidth, height: videoHeight } = videoData;
     if (!width && !height) {
         const [, embedUrl] = videoData.html.match(SRC_URL_REGEX);
-        const aspectRatio = videoHeight / videoWidth;
+        const aspectRatio = chooseAspectRatio(videoData);
         return Object.assign(Object.assign({}, videoData), { html: getResponsiveEmbedCode(embedUrl, aspectRatio) });
@@ -23,0 +35,0 @@ }

dist/esm/oembed.test.js

@@ -32,3 +32,3 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
         const result = yield oembed('https://www.loom.com/share/0281766fa2d04bb788eaf19e65135184');
-        expect(result).toEqual(Object.assign(Object.assign({}, oembedProperties), { html: '<div class="lo-emb-vid" style="position: relative; padding-bottom: 100%; height: 0;"><iframe src="https://www.loom.com/embed/0281766fa2d04bb788eaf19e65135184" frameborder="0" webkitallowfullscreen mozallowfullscreen allowfullscreen style="position: absolute; top: 0; left: 0; width: 100%; height: 100%;"></iframe></div>' }));
+        expect(result).toEqual(Object.assign(Object.assign({}, oembedProperties), { html: '<div class="lo-emb-vid" style="position: relative; padding-bottom: 100%; height: 0;"><iframe src="https://www.loom.com/embed/0281766fa2d04bb788eaf19e65135184" style="position: absolute; top: 0; left: 0; width: 100%; height: 100%;" frameborder="0" webkitallowfullscreen mozallowfullscreen allowfullscreen></iframe></div>' }));
     }));
@@ -35,0 +35,0 @@ test('wth options', () => __awaiter(void 0, void 0, void 0, function* () {

package.json

 {
   "name": "@loomhq/loom-embed",
-  "version": "1.2.5",
+  "version": "1.2.6",
   "description": "SDK for easily embedding videos",
@@ -5,0 +5,0 @@ "main": "dist/cjs/index.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

43312

increased by1.31%

Lines of code

853

increased by2.9%

No dependency changes