@luma.gl/api - npm Package Compare versions

Comparing version 9.0.0-alpha.25 to 9.0.0-alpha.26

dist/adapter/device.js

@@ -67,5 +67,5 @@ import _defineProperty from "@babel/runtime/helpers/esm/defineProperty";
       if (props.data instanceof Uint32Array) {
-        props.indexType = 'uint32';
+        newProps.indexType = 'uint32';
       } else if (props.data instanceof Uint16Array) {
-        props.indexType = 'uint16';
+        newProps.indexType = 'uint16';
       }
@@ -72,0 +72,0 @@ }

dist/adapter/resources/render-pass.d.ts

@@ -7,6 +7,3 @@ import type { Device } from '../device';
 /**
- * - Framebuffer specifies which textures to render into
- * - parameters control viewport, scissor rect, blend constant and stencil ref
- * - clearColor, depthClearValue, stencilClearValue control clearing at beginning of render pass.
- * - discard disables rasterizer.
+ * Properties for a RenderPass instance is a required parameter to all draw calls.
  */
@@ -31,2 +28,10 @@ export type RenderPassProps = ResourceProps & {
 };
+/**
+ * A RenderPass instance is a required parameter to all draw calls.
+ *
+ * It holds a combination of
+ * - render targets (specified via a framebuffer)
+ * - clear colors, read/write, discard information for the framebuffer attachments
+ * - a couple of mutable parameters ()
+ */
 export declare abstract class RenderPass extends Resource<RenderPassProps> {
@@ -37,5 +42,9 @@ /** Default properties for RenderPass */
     constructor(device: Device, props: RenderPassProps);
-    /** A small set of parameters can be changed between every draw call (viewport, scissorRect, blendColor, stencilReference) */
+    /** Call when rendering is done in this pass. */
+    abstract end(): void;
+    /**
+     * A small set of parameters can be changed between every draw call
+     * (viewport, scissorRect, blendColor, stencilReference)
+     */
     abstract setParameters(parameters: RenderPassParameters): void;
-    abstract end(): void;
     abstract pushDebugGroup(groupLabel: string): void;
@@ -42,0 +51,0 @@ abstract popDebugGroup(): void;

package.json

 {
   "name": "@luma.gl/api",
-  "version": "9.0.0-alpha.25",
+  "version": "9.0.0-alpha.26",
   "description": "luma.gl API",
@@ -45,3 +45,3 @@ "license": "MIT",
   },
-  "gitHead": "a91e00399e59c1b5310bdfd842648238c5abf908"
+  "gitHead": "e255f78c1c0a4555808c6e9282bcecb6accd147b"
 }

src/adapter/device.ts

@@ -333,5 +333,5 @@ // luma.gl, MIT license
       if (props.data instanceof Uint32Array) {
-        props.indexType = 'uint32';
+        newProps.indexType = 'uint32';
       } else if (props.data instanceof Uint16Array) {
-        props.indexType = 'uint16';
+        newProps.indexType = 'uint16';
       }
@@ -338,0 +338,0 @@ }

src/adapter/resources/render-pass.ts

@@ -13,6 +13,3 @@ // luma.gl, MIT license
 /**
- * - Framebuffer specifies which textures to render into
- * - parameters control viewport, scissor rect, blend constant and stencil ref 
- * - clearColor, depthClearValue, stencilClearValue control clearing at beginning of render pass.
- * - discard disables rasterizer.
+ * Properties for a RenderPass instance is a required parameter to all draw calls.
  */
@@ -38,2 +35,10 @@ export type RenderPassProps = ResourceProps & {
 
+/**
+ * A RenderPass instance is a required parameter to all draw calls.
+ * 
+ * It holds a combination of 
+ * - render targets (specified via a framebuffer)
+ * - clear colors, read/write, discard information for the framebuffer attachments
+ * - a couple of mutable parameters ()
+ */
 export abstract class RenderPass extends Resource<RenderPassProps> {
@@ -62,7 +67,11 @@
 
-  /** A small set of parameters can be changed between every draw call (viewport, scissorRect, blendColor, stencilReference) */
+  /** Call when rendering is done in this pass. */
+  abstract end(): void;
+
+  /** 
+   * A small set of parameters can be changed between every draw call 
+   * (viewport, scissorRect, blendColor, stencilReference) 
+   */
   abstract setParameters(parameters: RenderPassParameters): void;
 
-  abstract end(): void;
-
   abstract pushDebugGroup(groupLabel: string): void;
@@ -69,0 +78,0 @@ abstract popDebugGroup(): void;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

721036

increased by0.09%

Lines of code

11344

increased by0.19%

No dependency changes