@manypkg/cli - npm Package Compare versions

Comparing version 0.21.1 to 0.21.2

CHANGELOG.md

 # @manypkg/cli
 
+## 0.21.2
+
+### Patch Changes
+
+- [#194](https://github.com/Thinkmill/manypkg/pull/194) [`56a64c5`](https://github.com/Thinkmill/manypkg/commit/56a64c5d29565195d0f5013425ee1e2e5fdbe754) Thanks [@KATT](https://github.com/KATT)! - fix: allow tags in `npm:x`-deps
+
 ## 0.21.1
@@ -4,0 +10,0 @@

dist/manypkg-cli.cjs.dev.js

@@ -208,3 +208,3 @@ 'use strict';
           let dependencyWorkspace = allWorkspaces.get(depName);
-          if (dependencyWorkspace !== undefined && !semver__namespace["default"].satisfies(dependencyWorkspace.packageJson.version, range)) {
+          if (dependencyWorkspace !== undefined && !range.startsWith("npm:") && !semver__namespace["default"].satisfies(dependencyWorkspace.packageJson.version, range)) {
             errors.push({
@@ -211,0 +211,0 @@ type: "INTERNAL_MISMATCH",

dist/manypkg-cli.cjs.prod.js

@@ -208,3 +208,3 @@ 'use strict';
           let dependencyWorkspace = allWorkspaces.get(depName);
-          if (dependencyWorkspace !== undefined && !semver__namespace["default"].satisfies(dependencyWorkspace.packageJson.version, range)) {
+          if (dependencyWorkspace !== undefined && !range.startsWith("npm:") && !semver__namespace["default"].satisfies(dependencyWorkspace.packageJson.version, range)) {
             errors.push({
@@ -211,0 +211,0 @@ type: "INTERNAL_MISMATCH",

dist/manypkg-cli.esm.js

@@ -175,3 +175,3 @@ import chalk from 'chalk';
           let dependencyWorkspace = allWorkspaces.get(depName);
-          if (dependencyWorkspace !== undefined && !semver__default.satisfies(dependencyWorkspace.packageJson.version, range)) {
+          if (dependencyWorkspace !== undefined && !range.startsWith("npm:") && !semver__default.satisfies(dependencyWorkspace.packageJson.version, range)) {
             errors.push({
@@ -178,0 +178,0 @@ type: "INTERNAL_MISMATCH",

package.json

 {
   "name": "@manypkg/cli",
-  "version": "0.21.1",
+  "version": "0.21.2",
   "repository": {
@@ -5,0 +5,0 @@ "type": "git",

src/checks/__tests__/INTERNAL_MISMATCH.ts

@@ -88,2 +88,18 @@ import makeCheck, { ErrorType } from "../INTERNAL_MISMATCH";
   });
+
+  // regression test for https://github.com/Thinkmill/manypkg/issues/193
+  it.each(["npm:pkg-1@sometag", "npm:@someorg/pkg-1@sometag"])(
+    "should not error when using tag %s",
+    (range) => {
+      let ws = getWS();
+      let dependsOnOne = getFakeWS("depends-on-one");
+      dependsOnOne.packageJson.dependencies = {
+        "pkg-1": range,
+      };
+      ws.set("depends-on-one", dependsOnOne);
+      let errors = makeCheck.validate(dependsOnOne, ws, rootWorkspace, {});
+      expect(errors.length).toEqual(0);
+    }
+  );
+  
 });

src/checks/INTERNAL_MISMATCH.ts

@@ -25,4 +25,6 @@ import {
           let dependencyWorkspace = allWorkspaces.get(depName);
+          
           if (
             dependencyWorkspace !== undefined &&
+            !range.startsWith("npm:") &&
             !semver.satisfies(dependencyWorkspace.packageJson.version, range)
@@ -29,0 +31,0 @@ ) {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

176773

increased by0.53%

Lines of code

4443

increased by0.34%

No dependency changes