@metamask/eth-ledger-bridge-keyring - npm Package Compare versions

Comparing version 4.0.0 to 4.1.0

CHANGELOG.md

@@ -9,2 +9,8 @@ # Changelog
 
+## [4.1.0]
+### Changed
+- Refactor error message in `LedgerKeyring` ([#232](https://github.com/MetaMask/eth-ledger-bridge-keyring/pull/232))
+- Extend `LedgerMobileBridge` type from `LedgerBridge` ([#233](https://github.com/MetaMask/eth-ledger-bridge-keyring/pull/233))
+- Create new `MetaMaskLedgerHwAppEth` instance instead of re-using previous instance ([#231](https://github.com/MetaMask/eth-ledger-bridge-keyring/pull/231))
+
 ## [4.0.0]
@@ -111,3 +117,4 @@ ### Added
 
-[Unreleased]: https://github.com/MetaMask/eth-ledger-bridge-keyring/compare/v4.0.0...HEAD
+[Unreleased]: https://github.com/MetaMask/eth-ledger-bridge-keyring/compare/v4.1.0...HEAD
+[4.1.0]: https://github.com/MetaMask/eth-ledger-bridge-keyring/compare/v4.0.0...v4.1.0
 [4.0.0]: https://github.com/MetaMask/eth-ledger-bridge-keyring/compare/v3.0.0...v4.0.0
@@ -114,0 +121,0 @@ [3.0.0]: https://github.com/MetaMask/eth-ledger-bridge-keyring/compare/v2.0.1...v3.0.0

dist/ledger-keyring.js

@@ -48,2 +48,3 @@ "use strict";
 const keyringType = 'Ledger Hardware';
+// This number causes one of our failing tests to run very slowly, as the for loop needs to iterate 1000 times.
 const MAX_INDEX = 1000;
@@ -158,3 +159,5 @@ var NetworkApiUrls;
         catch (error) {
-            throw error instanceof Error ? error : new Error('Unknown error');
+            throw error instanceof Error
+                ? error
+                : new Error('Ledger Ethereum app closed. Open it to unlock.');
         }
@@ -161,0 +164,0 @@ if (updateHdk && payload.chainCode) {

dist/ledger-mobile-bridge.d.ts

@@ -5,11 +5,11 @@ import type Transport from '@ledgerhq/hw-transport';
 import { GetAppNameAndVersionResponse, LedgerMobileBridgeOptions } from './type';
-export interface LedgerMobileBridge {
+export declare type MobileBridge = LedgerBridge<LedgerMobileBridgeOptions> & {
     getAppNameAndVersion(): Promise<GetAppNameAndVersionResponse>;
     openEthApp(): Promise<void>;
     closeApps(): Promise<void>;
-}
+};
 /**
  * LedgerMobileBridge is a bridge between the LedgerKeyring and the LedgerTransportMiddleware.
  */
-export declare class LedgerMobileBridge implements LedgerBridge<LedgerMobileBridgeOptions> {
+export declare class LedgerMobileBridge implements MobileBridge {
     #private;
@@ -91,2 +91,18 @@ isDeviceConnected: boolean;
     attemptMakeApp(): Promise<boolean>;
+    /**
+     * Method to open ethereum application on ledger device.
+     *
+     */
+    openEthApp(): Promise<void>;
+    /**
+     * Method to close all running application on ledger device.
+     *
+     */
+    closeApps(): Promise<void>;
+    /**
+     * Method to retrieve the name and version of the running application in ledger device.
+     *
+     * @returns An object contains appName and version.
+     */
+    getAppNameAndVersion(): Promise<GetAppNameAndVersionResponse>;
 }

dist/ledger-transport-middleware.js

@@ -13,3 +13,3 @@ "use strict";
 };
-var _LedgerTransportMiddleware_app, _LedgerTransportMiddleware_transport;
+var _LedgerTransportMiddleware_transport;
 Object.defineProperty(exports, "__esModule", { value: true });
@@ -26,3 +26,2 @@ exports.LedgerTransportMiddleware = void 0;
         this.transportEncoding = 'ascii';
-        _LedgerTransportMiddleware_app.set(this, void 0);
         _LedgerTransportMiddleware_transport.set(this, void 0);
@@ -63,10 +62,7 @@ }
     getEthApp() {
-        if (!__classPrivateFieldGet(this, _LedgerTransportMiddleware_app, "f")) {
-            __classPrivateFieldSet(this, _LedgerTransportMiddleware_app, new ledger_hw_app_1.MetaMaskLedgerHwAppEth(this.getTransport()), "f");
-        }
-        return __classPrivateFieldGet(this, _LedgerTransportMiddleware_app, "f");
+        return new ledger_hw_app_1.MetaMaskLedgerHwAppEth(this.getTransport());
     }
 }
 exports.LedgerTransportMiddleware = LedgerTransportMiddleware;
-_LedgerTransportMiddleware_app = new WeakMap(), _LedgerTransportMiddleware_transport = new WeakMap();
+_LedgerTransportMiddleware_transport = new WeakMap();
 //# sourceMappingURL=ledger-transport-middleware.js.map

package.json

 {
   "name": "@metamask/eth-ledger-bridge-keyring",
-  "version": "4.0.0",
+  "version": "4.1.0",
   "description": "A MetaMask compatible keyring, for ledger hardware wallets",
@@ -5,0 +5,0 @@ "keywords": [

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

154287

increased by0.48%

Lines of code

1432

increased by1.06%

No dependency changes