@mparticle/web-sdk - npm Package Compare versions

Comparing version 2.23.6 to 2.23.7

package.json

 {
     "name": "@mparticle/web-sdk",
-    "version": "2.23.6",
+    "version": "2.23.7",
     "description": "mParticle core SDK for web applications",
@@ -5,0 +5,0 @@ "license": "Apache-2.0",

src/forwarders.js

@@ -632,24 +632,30 @@ import Types from './types';
 
-    // Sideloaded kits are not configured in the UI and do not have kit configurations
-    // They are automatically added to active forwarders.
+    // Unlike UI enabled kits, sideloaded kits are always added to active forwarders.
 
-    // TODO: Sideloading kits currently requires the use of a register method
+    // TODO: Sideloading kits currently require the use of a register method
     // which requires an object on which to be registered.
-    // In the future, when all kits are moved to the config rather than
+    // In the future, when all kits are moved to the mpConfig rather than
     // there being a separate process for MP configured kits and
     // sideloaded kits, this will need to be refactored.
-    this.processSideloadedKits = function(config) {
+    this.processSideloadedKits = function(mpConfig) {
         try {
-            if (Array.isArray(config.sideloadedKits)) {
-                const sideloadedKits = { kits: {} };
-                // First register each kit's constructor onto sideloadedKits,
-                // which is typed { kits: Dictionary<constructor> }.
-                // The constructors are keyed by the name of the kit.
-                config.sideloadedKits.forEach(function(sideloadedKit) {
+            if (Array.isArray(mpConfig.sideloadedKits)) {
+                const registeredSideloadedKits = { kits: {} };
+                const unregisteredSideloadedKits = mpConfig.sideloadedKits;
+
+                unregisteredSideloadedKits.forEach(function(unregisteredKit) {
                     try {
-                        sideloadedKit.kitInstance.register(sideloadedKits);
+                        // Register each sideloaded kit, which adds a key of the sideloaded kit name
+                        // and a value of the sideloaded kit constructor.
+                        unregisteredKit.kitInstance.register(
+                            registeredSideloadedKits
+                        );
+                        const kitName = unregisteredKit.kitInstance.name;
+                        // Then add the kit filters to each registered kit.
+                        registeredSideloadedKits.kits[kitName].filters =
+                            unregisteredKit.filterDictionary;
                     } catch (e) {
                         console.error(
                             'Error registering sideloaded kit ' +
-                                sideloadedKit.kitInstance.name
+                                unregisteredKit.kitInstance.name
                         );
@@ -659,7 +665,7 @@ }
 
-                // Then configure each kit
-                for (const registeredKitKey in sideloadedKits.kits) {
-                    const kitConstructor =
-                        sideloadedKits.kits[registeredKitKey];
-                    self.configureSideloadedKit(kitConstructor);
+                // Then configure each registered kit
+                for (const registeredKitKey in registeredSideloadedKits.kits) {
+                    const registeredKit =
+                        registeredSideloadedKits.kits[registeredKitKey];
+                    self.configureSideloadedKit(registeredKit);
                 }
@@ -669,4 +675,4 @@
                 // record this in the Store.
-                if (!isEmpty(sideloadedKits.kits)) {
-                    const kitKeys = Object.keys(sideloadedKits.kits);
+                if (!isEmpty(registeredSideloadedKits.kits)) {
+                    const kitKeys = Object.keys(registeredSideloadedKits.kits);
                     mpInstance._Store.sideloadedKitsCount = kitKeys.length;
@@ -686,3 +692,3 @@ }
         mpInstance._Store.configuredForwarders.push(
-            this.returnConfiguredKit(kitConstructor)
+            this.returnConfiguredKit(kitConstructor, kitConstructor.filters)
         );
@@ -689,0 +695,0 @@ };

src/types.js

@@ -20,3 +20,2 @@ var MessageType = {
     [MessageType.Commerce]: 1,
-    [MessageType.UserAttributeChange]: 1,
     [MessageType.UserIdentityChange]: 1,
@@ -23,0 +22,0 @@ };

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1459366

increased by0.02%

Worsened metrics

Lines of code

26147

decreased by-0.01%

No dependency changes