@nesk/puphpeteer - npm Package Compare versions

Comparing version 1.1.0 to 1.2.0

.github/contributing.md

 # Contributing to PuPHPeteer
 
+Please, be sure to read this document _before_ creating an issue or a pull-request.
+
+## Where to ask a question or report a bug
+
+First, be sure to differentiate the original project [Puppeteer ![#40b5a4](https://placehold.it/10/40b5a4/000000?text=+)](https://github.com/GoogleChrome/puppeteer), developed by Google to interact with Chromium, from [PuPHPeteer ![#8846F0](https://placehold.it/10/8846F0/000000?text=+)](https://github.com/nesk/puphpeteer), an unofficial PHP bridge to call Puppeteer methods in PHP.
+
+Here are some cases to help you choosing where to ask a question or report a bug. The first list item matching your case should be used:
+
+1. You don't know how to do _[something]_ with **Puppeteer ![#40b5a4](https://placehold.it/10/40b5a4/000000?text=+)**: ask your question [on StackOverflow with the _puppeteer_ tag](https://stackoverflow.com/questions/tagged/puppeteer?sort=newest).
+2. You don't know how to do _[something]_ with **PuPHPeteer ![#8846F0](https://placehold.it/10/8846F0/000000?text=+)**: ask your question [in PuPHPeteer's issues](https://github.com/nesk/puphpeteer/issues).
+3. You encountered a bug:
+    1. It is reproducible with **Puppeteer ![#40b5a4](https://placehold.it/10/40b5a4/000000?text=+)**: report the bug [in Puppeteer's issues](https://github.com/GoogleChrome/puppeteer/issues).
+    2. it is reproducible only with **PuPHPeteer ![#8846F0](https://placehold.it/10/8846F0/000000?text=+)**: report the bug [in PuPHPeteer's issues](https://github.com/nesk/puphpeteer/issues).
+
 ## Provide logs with your bug report
@@ -4,0 +18,0 @@

.vscode/launch.json

@@ -8,2 +8,8 @@ {
         {
+            "type": "node",
+            "request": "attach",
+            "name": "Attach Node.js",
+            "port": 9229
+        },
+        {
             "name": "Listen for XDebug",
@@ -10,0 +16,0 @@ "type": "php",

composer.json

 {
     "name": "nesk/puphpeteer",
-    "description": "A Puppeteer bridge for PHP, supporting the full API.",
+    "description": "A Puppeteer bridge for PHP, supporting the entire API.",
     "keywords": [
@@ -23,3 +23,3 @@ "php",
         "php": ">=7.1",
-        "nesk/rialto": "^1.0.0",
+        "nesk/rialto": "^1.1.0",
         "vierbergenlars/php-semver": "^3.0"
@@ -26,0 +26,0 @@ },

package.json

 {
   "name": "@nesk/puphpeteer",
-  "version": "1.1.0",
-  "description": "A Puppeteer bridge for PHP, supporting the full API.",
+  "version": "1.2.0",
+  "description": "A Puppeteer bridge for PHP, supporting the entire API.",
   "keywords": [
@@ -25,5 +25,5 @@ "php",
   "dependencies": {
-    "@nesk/rialto": "^1.0.0",
-    "puppeteer": "~1.5.0"
+    "@nesk/rialto": "^1.1.0",
+    "puppeteer": "~1.6.0"
   }
 }

README.md

 # PuPHPeteer
 
+<img src="https://user-images.githubusercontent.com/817508/41925638-6f1b9dde-796d-11e8-8f87-3646f0c89750.png" style="max-width:100%;" width="190px" align="right">
+
 [![PHP Version](https://img.shields.io/packagist/php-v/nesk/puphpeteer.svg?style=flat-square)](http://php.net/)
@@ -9,3 +11,3 @@ [![Composer Version](https://img.shields.io/packagist/v/nesk/puphpeteer.svg?style=flat-square&label=Composer)](https://packagist.org/packages/nesk/puphpeteer)
 
-A [Puppeteer](https://github.com/GoogleChrome/puppeteer/) bridge for PHP, supporting the full API. Based on [Rialto](https://github.com/nesk/rialto/), a package to manage Node resources from PHP.
+A [Puppeteer](https://github.com/GoogleChrome/puppeteer/) bridge for PHP, supporting the entire API. Based on [Rialto](https://github.com/nesk/rialto/), a package to manage Node resources from PHP.
 
@@ -42,3 +44,3 @@ Here are some examples [borrowed from Puppeteer's documentation](https://github.com/GoogleChrome/puppeteer/blob/master/README.md#usage) and adapted to PHP's syntax:
 // Get the "viewport" of the page, as reported by the page.
-$dimensions = $page->evaluate(JsFunction::create("
+$dimensions = $page->evaluate(JsFunction::createWithBody("
     return {
@@ -126,5 +128,4 @@ width: document.documentElement.clientWidth,
 
-$pageFunction = JsFunction::create(['element'], "
-    return element.textContent;
-");
+$pageFunction = JsFunction::createWithParameters(['element'])
+    ->body("return element.textContent");
 ```
@@ -153,1 +154,10 @@
 The MIT License (MIT). Please see [License File](LICENSE) for more information.
+
+## Logo attribution
+
+PuPHPeteer's logo is composed of:
+
+- [Puppet](https://thenounproject.com/search/?q=puppet&i=52120) by Luis Prado from [the Noun Project](http://thenounproject.com/).
+- [Elephant](https://thenounproject.com/search/?q=elephant&i=954119) by Lluisa Iborra from [the Noun Project](http://thenounproject.com/).
+
+Thanks to [Laravel News](https://laravel-news.com/) for picking the icons and colors of the logo.

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

36189

increased by14.18%

Number of package files

45

increased by2.27%

Lines of code

152

increased by4.11%

Number of lines in readme file

160

increased by6.67%

Dependency changes

• + Addedpuppeteer@1.6.2(transitive)

• - Removedpuppeteer@1.5.0(transitive)

• Updated@nesk/rialto@^1.1.0

• Updatedpuppeteer@~1.6.0