@norskvideo/webrtc-client - npm Package Compare versions

Comparing version 0.1.1 to 0.1.2

lib/cjs/webrtc.js

@@ -50,3 +50,4 @@ "use strict";
             const localOffer = yield client.createOffer();
-            yield client.setLocalDescription(localOffer);
+            // Previously set local description here, starting ICE candidate gathering earlier.
+            // Could potentially still do this when ICE servers are explicitly configured.
             console.debug("received local offer, sending to server", localOffer);
@@ -72,2 +73,4 @@ let response = yield fetch(this.endpointUrl, {
             console.log("Got response", { remoteOffer, sessionUrl });
+            // Set local description after configuring ICE servers returned in Link header
+            yield client.setLocalDescription(localOffer);
             const remoteResponse = yield client.setRemoteDescription({
@@ -79,2 +82,3 @@ type: "answer",
             console.log("Peer connection state", client);
+            // Currently there should be no cached candidates
             this.sendCachedCandidates();
@@ -81,0 +85,0 @@ });

lib/esm/webrtc.js

@@ -47,3 +47,4 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
             const localOffer = yield client.createOffer();
-            yield client.setLocalDescription(localOffer);
+            // Previously set local description here, starting ICE candidate gathering earlier.
+            // Could potentially still do this when ICE servers are explicitly configured.
             console.debug("received local offer, sending to server", localOffer);
@@ -69,2 +70,4 @@ let response = yield fetch(this.endpointUrl, {
             console.log("Got response", { remoteOffer, sessionUrl });
+            // Set local description after configuring ICE servers returned in Link header
+            yield client.setLocalDescription(localOffer);
             const remoteResponse = yield client.setRemoteDescription({
@@ -76,2 +79,3 @@ type: "answer",
             console.log("Peer connection state", client);
+            // Currently there should be no cached candidates
             this.sendCachedCandidates();
@@ -78,0 +82,0 @@ });

package.json

 {
   "name": "@norskvideo/webrtc-client",
-  "version": "0.1.1",
+  "version": "0.1.2",
   "description": "WHIP/WHEP/duplex WebRTC client for Norsk integration",
@@ -5,0 +5,0 @@ "main": "lib/cjs/webrtc.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

60169

increased by1.32%

Lines of code

841

increased by0.96%

No dependency changes