@nrwl/workspace - npm Package Compare versions

Comparing version 8.4.10 to 8.4.11-beta.1

package.json

 {
   "name": "@nrwl/workspace",
-  "version": "8.4.10",
+  "version": "8.4.11-beta.1",
   "description": "Extensible Dev Tools for Monorepos",
@@ -63,4 +63,4 @@ "repository": {
     "chalk": "2.4.2",
-    "@nrwl/cli": "8.4.10"
+    "@nrwl/cli": "8.4.11-beta.1"
   }
 }

src/utils/lint.d.ts

@@ -24,7 +24,15 @@ import { Rule } from '@angular-devkit/schematics';
 };
-export declare function addLintFiles(projectRoot: string, linter: Linter, onlyGlobal?: boolean): Rule;
-/**
- * CONFIG FOR REACT WORKSPACES
- *
- * ADAPTED FROM https://github.com/facebook/create-react-app/blob/567f36c9235f1e1fd4a76dc6d1ae00be754ca047/packages/eslint-config-react-app/index.js
- */
+interface AddLintFileOptions {
+    onlyGlobal?: boolean;
+    localConfig?: any;
+    extraPackageDeps?: {
+        dependencies: {
+            [key: string]: string;
+        };
+        devDependencies: {
+            [key: string]: string;
+        };
+    };
+}
+export declare function addLintFiles(projectRoot: string, linter: Linter, options?: AddLintFileOptions): Rule;
+export {};

src/utils/lint.js

 "use strict";
+var __assign = (this && this.__assign) || function () {
+    __assign = Object.assign || function(t) {
+        for (var s, i = 1, n = arguments.length; i < n; i++) {
+            s = arguments[i];
+            for (var p in s) if (Object.prototype.hasOwnProperty.call(s, p))
+                t[p] = s[p];
+        }
+        return t;
+    };
+    return __assign.apply(this, arguments);
+};
 Object.defineProperty(exports, "__esModule", { value: true });
@@ -33,5 +44,8 @@ var core_1 = require("@angular-devkit/core");
 exports.generateProjectLint = generateProjectLint;
-function addLintFiles(projectRoot, linter, onlyGlobal) {
-    if (onlyGlobal === void 0) { onlyGlobal = false; }
+function addLintFiles(projectRoot, linter, options) {
+    if (options === void 0) { options = {}; }
     return function (host, context) {
+        if (options.onlyGlobal && options.localConfig) {
+            throw new Error('onlyGlobal and localConfig cannot be used at the same time');
+        }
         if (linter === 'tslint') {
@@ -41,3 +55,3 @@ if (!host.exists('/tslint.json')) {
             }
-            if (!onlyGlobal) {
+            if (!options.onlyGlobal) {
                 host.create(core_1.join(projectRoot, "tslint.json"), JSON.stringify({
@@ -53,25 +67,26 @@ extends: common_1.offsetFromRoot(projectRoot) + "tslint.json",
                 host.create('/.eslintrc', globalESLint);
-                ast_utils_1.addDepsToPackageJson({}, {
-                    '@nrwl/eslint-plugin-nx': versions_1.nxVersion,
-                    '@typescript-eslint/parser': versions_1.typescriptESLintVersion,
-                    '@typescript-eslint/eslint-plugin': versions_1.typescriptESLintVersion,
-                    eslint: versions_1.eslintVersion,
-                    'eslint-config-prettier': versions_1.eslintConfigPrettierVersion
-                    /**
-                     * REACT SPECIFIC PLUGINS USED IN CONFIG REACT SPECIFIC CONFIG BELOW
-                     *
-                     * NOTE: They will also need adding to the root package.json of this repo
-                     * when the time comes
-                     */
-                    // "eslint-plugin-import": "2.18.2",
-                    // "eslint-plugin-jsx-a11y": "6.2.3",
-                    // "eslint-plugin-react": "7.14.3",
-                    // "eslint-plugin-react-hooks": "1.6.1",
-                })(host, context);
+                ast_utils_1.addDepsToPackageJson(__assign({}, (options.extraPackageDeps
+                    ? options.extraPackageDeps.dependencies
+                    : {})), __assign({ '@nrwl/eslint-plugin-nx': versions_1.nxVersion, '@typescript-eslint/parser': versions_1.typescriptESLintVersion, '@typescript-eslint/eslint-plugin': versions_1.typescriptESLintVersion, eslint: versions_1.eslintVersion, 'eslint-config-prettier': versions_1.eslintConfigPrettierVersion }, (options.extraPackageDeps
+                    ? options.extraPackageDeps.devDependencies
+                    : {})))(host, context);
             }
-            if (!onlyGlobal) {
-                host.create(core_1.join(projectRoot, ".eslintrc"), JSON.stringify({
-                    extends: common_1.offsetFromRoot(projectRoot) + ".eslintrc",
-                    rules: {}
-                }));
+            if (!options.onlyGlobal) {
+                var configJson = void 0;
+                var rootConfig = common_1.offsetFromRoot(projectRoot) + ".eslintrc";
+                if (options.localConfig) {
+                    var extendsOption = options.localConfig.extends
+                        ? Array.isArray(options.localConfig.extends)
+                            ? options.localConfig.extends
+                            : [options.localConfig.extends]
+                        : [];
+                    configJson = __assign({}, options.localConfig, { extends: extendsOption.concat([rootConfig]) });
+                }
+                else {
+                    configJson = {
+                        extends: rootConfig,
+                        rules: {}
+                    };
+                }
+                host.create(core_1.join(projectRoot, ".eslintrc"), JSON.stringify(configJson));
             }
@@ -83,327 +98,2 @@ }
 var globalTsLint = "\n{\n  \"rulesDirectory\": [\"node_modules/@nrwl/workspace/src/tslint\"],\n  \"rules\": {\n    \"arrow-return-shorthand\": true,\n    \"callable-types\": true,\n    \"class-name\": true,\n    \"deprecation\": {\n      \"severity\": \"warn\"\n    },\n    \"forin\": true,\n    \"import-blacklist\": [true, \"rxjs/Rx\"],\n    \"interface-over-type-literal\": true,\n    \"member-access\": false,\n    \"member-ordering\": [\n      true,\n      {\n        \"order\": [\n          \"static-field\",\n          \"instance-field\",\n          \"static-method\",\n          \"instance-method\"\n        ]\n      }\n    ],\n    \"no-arg\": true,\n    \"no-bitwise\": true,\n    \"no-console\": [true, \"debug\", \"info\", \"time\", \"timeEnd\", \"trace\"],\n    \"no-construct\": true,\n    \"no-debugger\": true,\n    \"no-duplicate-super\": true,\n    \"no-empty\": false,\n    \"no-empty-interface\": true,\n    \"no-eval\": true,\n    \"no-inferrable-types\": [true, \"ignore-params\"],\n    \"no-misused-new\": true,\n    \"no-non-null-assertion\": true,\n    \"no-shadowed-variable\": true,\n    \"no-string-literal\": false,\n    \"no-string-throw\": true,\n    \"no-switch-case-fall-through\": true,\n    \"no-unnecessary-initializer\": true,\n    \"no-unused-expression\": true,\n    \"no-var-keyword\": true,\n    \"object-literal-sort-keys\": false,\n    \"prefer-const\": true,\n    \"radix\": true,\n    \"triple-equals\": [true, \"allow-null-check\"],\n    \"unified-signatures\": true,\n    \"variable-name\": false,\n\n    \"nx-enforce-module-boundaries\": [\n      true,\n      {\n        \"allow\": [],\n        \"depConstraints\": [\n          { \"sourceTag\": \"*\", \"onlyDependOnLibsWithTags\": [\"*\"] }\n        ]\n      }\n    ]\n  }\n}\n";
-var globalESLint = "\n{\n  \"root\": true,\n  \"parser\": \"@typescript-eslint/parser\",\n  \"parserOptions\": {\n    \"ecmaVersion\": 2018,\n    \"sourceType\": \"module\",\n    \"project\": \"./tsconfig.json\"\n  },\n  \"plugins\": [\"@typescript-eslint\", \"@nrwl/nx\"],\n  \"extends\": [\n    \"eslint:recommended\",\n    \"plugin:@typescript-eslint/eslint-recommended\",\n    \"plugin:@typescript-eslint/recommended\",\n    \"prettier\",\n    \"prettier/@typescript-eslint\"\n  ],\n  \"rules\": {\n    \"@typescript-eslint/explicit-member-accessibility\": \"off\",\n    \"@typescript-eslint/explicit-function-return-type\": \"off\",\n    \"@typescript-eslint/no-parameter-properties\": \"off\",\n    \"@nrwl/nx/enforce-module-boundaries\": [\n      \"error\",\n      {\n        \"allow\": [],\n        \"depConstraints\": [\n          { \"sourceTag\": \"*\", \"onlyDependOnLibsWithTags\": [\"*\"] }\n        ]\n      }\n    ]\n  },\n  \"overrides\": [\n    {\n      \"files\": [\"*.tsx\"],\n      \"rules\": {\n        \"@typescript-eslint/no-unused-vars\": \"off\"\n      }\n    }\n  ]\n}\n";
-/**
- * CONFIG FOR REACT WORKSPACES
- *
- * ADAPTED FROM https://github.com/facebook/create-react-app/blob/567f36c9235f1e1fd4a76dc6d1ae00be754ca047/packages/eslint-config-react-app/index.js
- */
-// {
-//   "parser": "@typescript-eslint/parser",
-//   "parserOptions": {
-//     "ecmaVersion": 2018,
-//     "sourceType": "module",
-//     "project": "./tsconfig.json"
-//   },
-//   "env": {
-//     "browser": true,
-//     "commonjs": true,
-//     "es6": true,
-//     "jest": true,
-//     "node": true
-//   },
-//   "settings": {
-//     "react": {
-//       "version": "detect"
-//     }
-//   },
-//   "plugins": ["@typescript-eslint", "@nrwl/nx", "import", "jsx-a11y", "react", "react-hooks"],
-//   "extends": [
-//     "eslint:recommended",
-//     "plugin:@typescript-eslint/eslint-recommended",
-//     "plugin:@typescript-eslint/recommended",
-//     "prettier",
-//     "prettier/@typescript-eslint"
-//   ],
-//   /**
-//   * Inspired by configuration originally found in create-react-app
-//   * https://github.com/facebook/create-react-app
-//   */
-//   "rules": {
-//     "@nrwl/nx/enforce-module-boundaries": [
-//       "error",
-//       {
-//         "allow": [],
-//         "depConstraints": [
-//           { "sourceTag": "*", "onlyDependOnLibsWithTags": ["*"] }
-//         ]
-//       }
-//     ],
-//     /**
-//      * Standard ESLint rule configurations
-//      * https://eslint.org/docs/rules
-//      */
-//     "array-callback-return": "warn",
-//     "dot-location": ["warn", "property"],
-//     "eqeqeq": ["warn", "smart"],
-//     "new-parens": "warn",
-//     "no-caller": "warn",
-//     "no-cond-assign": ["warn", "except-parens"],
-//     "no-const-assign": "warn",
-//     "no-control-regex": "warn",
-//     "no-delete-var": "warn",
-//     "no-dupe-args": "warn",
-//     "no-dupe-keys": "warn",
-//     "no-duplicate-case": "warn",
-//     "no-empty-character-class": "warn",
-//     "no-empty-pattern": "warn",
-//     "no-eval": "warn",
-//     "no-ex-assign": "warn",
-//     "no-extend-native": "warn",
-//     "no-extra-bind": "warn",
-//     "no-extra-label": "warn",
-//     "no-fallthrough": "warn",
-//     "no-func-assign": "warn",
-//     "no-implied-eval": "warn",
-//     "no-invalid-regexp": "warn",
-//     "no-iterator": "warn",
-//     "no-label-var": "warn",
-//     "no-labels": ["warn", { "allowLoop": true, "allowSwitch": false }],
-//     "no-lone-blocks": "warn",
-//     "no-loop-func": "warn",
-//     "no-mixed-operators": [
-//       "warn",
-//       {
-//         "groups": [
-//           ["&", "|", "^", "~", "<<", ">>", ">>>"],
-//           ["==", "!=", "===", "!==", ">", ">=", "<", "<="],
-//           ["&&", "||"],
-//           ["in", "instanceof"],
-//         ],
-//         "allowSamePrecedence": false,
-//       },
-//     ],
-//     "no-multi-str": "warn",
-//     "no-native-reassign": "warn",
-//     "no-negated-in-lhs": "warn",
-//     "no-new-func": "warn",
-//     "no-new-object": "warn",
-//     "no-new-symbol": "warn",
-//     "no-new-wrappers": "warn",
-//     "no-obj-calls": "warn",
-//     "no-octal": "warn",
-//     "no-octal-escape": "warn",
-//     "no-redeclare": "warn",
-//     "no-regex-spaces": "warn",
-//     "no-restricted-syntax": ["warn", "WithStatement"],
-//     "no-script-url": "warn",
-//     "no-self-assign": "warn",
-//     "no-self-compare": "warn",
-//     "no-sequences": "warn",
-//     "no-shadow-restricted-names": "warn",
-//     "no-sparse-arrays": "warn",
-//     "no-template-curly-in-string": "warn",
-//     "no-this-before-super": "warn",
-//     "no-throw-literal": "warn",
-//     "no-restricted-globals": [
-//       "error",
-//       [
-//         "addEventListener",
-//         "blur",
-//         "close",
-//         "closed",
-//         "confirm",
-//         "defaultStatus",
-//         "defaultstatus",
-//         "event",
-//         "external",
-//         "find",
-//         "focus",
-//         "frameElement",
-//         "frames",
-//         "history",
-//         "innerHeight",
-//         "innerWidth",
-//         "length",
-//         "location",
-//         "locationbar",
-//         "menubar",
-//         "moveBy",
-//         "moveTo",
-//         "name",
-//         "onblur",
-//         "onerror",
-//         "onfocus",
-//         "onload",
-//         "onresize",
-//         "onunload",
-//         "open",
-//         "opener",
-//         "opera",
-//         "outerHeight",
-//         "outerWidth",
-//         "pageXOffset",
-//         "pageYOffset",
-//         "parent",
-//         "print",
-//         "removeEventListener",
-//         "resizeBy",
-//         "resizeTo",
-//         "screen",
-//         "screenLeft",
-//         "screenTop",
-//         "screenX",
-//         "screenY",
-//         "scroll",
-//         "scrollbars",
-//         "scrollBy",
-//         "scrollTo",
-//         "scrollX",
-//         "scrollY",
-//         "self",
-//         "status",
-//         "statusbar",
-//         "stop",
-//         "toolbar",
-//         "top",
-//       ]
-//     ],
-//     "no-unexpected-multiline": "warn",
-//     "no-unreachable": "warn",
-//     "no-unused-expressions": [
-//       "error",
-//       {
-//         "allowShortCircuit": true,
-//         "allowTernary": true,
-//         "allowTaggedTemplates": true,
-//       },
-//     ],
-//     "no-unused-labels": "warn",
-//     "no-useless-computed-key": "warn",
-//     "no-useless-concat": "warn",
-//     "no-useless-escape": "warn",
-//     "no-useless-rename": [
-//       "warn",
-//       {
-//         "ignoreDestructuring": false,
-//         "ignoreImport": false,
-//         "ignoreExport": false,
-//       },
-//     ],
-//     "no-with": "warn",
-//     "no-whitespace-before-property": "warn",
-//     "react-hooks/exhaustive-deps": "warn",
-//     "require-yield": "warn",
-//     "rest-spread-spacing": ["warn", "never"],
-//     "strict": ["warn", "never"],
-//     "unicode-bom": ["warn", "never"],
-//     "use-isnan": "warn",
-//     "valid-typeof": "warn",
-//     "no-restricted-properties": [
-//       "error",
-//       {
-//         "object": "require",
-//         "property": "ensure",
-//         "message":
-//           "Please use import() instead. More info: https://facebook.github.io/create-react-app/docs/code-splitting",
-//       },
-//       {
-//         "object": "System",
-//         "property": "import",
-//         "message":
-//           "Please use import() instead. More info: https://facebook.github.io/create-react-app/docs/code-splitting",
-//       },
-//     ],
-//     "getter-return": "warn",
-//     /**
-//      * Import rule configurations
-//      * https://github.com/benmosher/eslint-plugin-import
-//      */
-//     "import/first": "error",
-//     "import/no-amd": "error",
-//     "import/no-webpack-loader-syntax": "error",
-//     /**
-//      * React-specific rule configurations
-//      * https://github.com/yannickcr/eslint-plugin-react
-//      */
-//     "react/forbid-foreign-prop-types": ["warn", { "allowInPropTypes": true }],
-//     "react/jsx-no-comment-textnodes": "warn",
-//     "react/jsx-no-duplicate-props": "warn",
-//     "react/jsx-no-target-blank": "warn",
-//     "react/jsx-no-undef": "error",
-//     "react/jsx-pascal-case": [
-//       "warn",
-//       {
-//         "allowAllCaps": true,
-//         "ignore": [],
-//       },
-//     ],
-//     "react/jsx-uses-react": "warn",
-//     "react/jsx-uses-vars": "warn",
-//     "react/no-danger-with-children": "warn",
-//     "react/no-direct-mutation-state": "warn",
-//     "react/no-is-mounted": "warn",
-//     "react/no-typos": "error",
-//     "react/react-in-jsx-scope": "error",
-//     "react/require-render-return": "error",
-//     "react/style-prop-object": "warn",
-//     /**
-//      * JSX Accessibility rule configurations
-//      * https://github.com/evcohen/eslint-plugin-jsx-a11y
-//      */
-//     "jsx-a11y/accessible-emoji": "warn",
-//     "jsx-a11y/alt-text": "warn",
-//     "jsx-a11y/anchor-has-content": "warn",
-//     "jsx-a11y/anchor-is-valid": [
-//       "warn",
-//       {
-//         "aspects": ["noHref", "invalidHref"],
-//       },
-//     ],
-//     "jsx-a11y/aria-activedescendant-has-tabindex": "warn",
-//     "jsx-a11y/aria-props": "warn",
-//     "jsx-a11y/aria-proptypes": "warn",
-//     "jsx-a11y/aria-role": "warn",
-//     "jsx-a11y/aria-unsupported-elements": "warn",
-//     "jsx-a11y/heading-has-content": "warn",
-//     "jsx-a11y/iframe-has-title": "warn",
-//     "jsx-a11y/img-redundant-alt": "warn",
-//     "jsx-a11y/no-access-key": "warn",
-//     "jsx-a11y/no-distracting-elements": "warn",
-//     "jsx-a11y/no-redundant-roles": "warn",
-//     "jsx-a11y/role-has-required-aria-props": "warn",
-//     "jsx-a11y/role-supports-aria-props": "warn",
-//     "jsx-a11y/scope": "warn",
-//     /**
-//      * React Hooks rule configurations
-//      * https://github.com/facebook/react/tree/master/packages/eslint-plugin-react-hooks
-//      */
-//     "react-hooks/rules-of-hooks": "error",
-//     /**
-//      * TypeScript-specific rule configurations (in addition to @typescript-eslint:recommended)
-//      * https://github.com/typescript-eslint/typescript-eslint
-//      */
-//     // TypeScript"s `noFallthroughCasesInSwitch` option is more robust (#6906)
-//     "default-case": "off",
-//     // "tsc" already handles this (https://github.com/typescript-eslint/typescript-eslint/issues/291)
-//     "no-dupe-class-members": "off",
-//     // "tsc" already handles this (https://github.com/typescript-eslint/typescript-eslint/issues/477)
-//     "no-undef": "off",
-//     // Add TypeScript specific rules (and turn off ESLint equivalents)
-//     "@typescript-eslint/consistent-type-assertions": "warn",
-//     "no-array-constructor": "off",
-//     "@typescript-eslint/no-array-constructor": "warn",
-//     "@typescript-eslint/no-namespace": "error",
-//     "no-use-before-define": "off",
-//     "@typescript-eslint/no-use-before-define": [
-//       "warn",
-//       {
-//         "functions": false,
-//         "classes": false,
-//         "variables": false,
-//         "typedefs": false,
-//       },
-//     ],
-//     "no-unused-vars": "off",
-//     "@typescript-eslint/no-unused-vars": [
-//       "warn",
-//       {
-//         "args": "none",
-//         "ignoreRestSiblings": true,
-//       },
-//     ],
-//     "no-useless-constructor": "off",
-//     "@typescript-eslint/no-useless-constructor": "warn",
-//     "@typescript-eslint/explicit-member-accessibility": "off",
-//     "@typescript-eslint/explicit-function-return-type": "off"
-//   }
-// }
+var globalESLint = "\n{\n  \"root\": true,\n  \"parser\": \"@typescript-eslint/parser\",\n  \"parserOptions\": {\n    \"ecmaVersion\": 2018,\n    \"sourceType\": \"module\",\n    \"project\": \"./tsconfig.json\"\n  },\n  \"plugins\": [\"@typescript-eslint\", \"@nrwl/nx\"],\n  \"extends\": [\n    'eslint:recommended',\n    'plugin:@typescript-eslint/eslint-recommended',\n    'plugin:@typescript-eslint/recommended',\n    'prettier',\n    'prettier/@typescript-eslint'\n  ],\n  \"rules\": {\n    \"@typescript-eslint/explicit-member-accessibility\": \"off\",\n    \"@typescript-eslint/explicit-function-return-type\": \"off\",\n    \"@typescript-eslint/no-parameter-properties\": \"off\",\n    \"@nrwl/nx/enforce-module-boundaries\": [\n      \"error\",\n      {\n        \"allow\": [],\n        \"depConstraints\": [\n          { \"sourceTag\": \"*\", \"onlyDependOnLibsWithTags\": [\"*\"] }\n        ]\n      }\n    ]\n  },\n  \"overrides\": [\n    {\n      \"files\": [\"*.tsx\"],\n      \"rules\": {\n        \"@typescript-eslint/no-unused-vars\": \"off\"\n      }\n    }\n  ]\n}\n";

src/utils/versions.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.nxVersion = '8.4.10';
+exports.nxVersion = '8.4.11-beta.1';
 exports.angularCliVersion = '8.1.1';
@@ -5,0 +5,0 @@ exports.typescriptVersion = '~3.4.5';

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

491887

decreased by-1.89%

Lines of code

11375

decreased by-2.58%

Number of low quality alerts

1

increased byInfinity%

Dependency changes

• + Added@nrwl/cli@8.4.11-beta.1(transitive)

• + Added@nrwl/tao@8.4.11-beta.1(transitive)

• - Removed@nrwl/cli@8.4.10(transitive)

• - Removed@nrwl/tao@8.4.10(transitive)

• Updated@nrwl/cli@8.4.11-beta.1