@octokit/oauth-app - npm Package Compare versions

Comparing version 2.0.4 to 2.0.5

dist-node/index.js

@@ -16,3 +16,3 @@ 'use strict';
 
-const VERSION = "2.0.4";
+const VERSION = "2.0.5";
 
@@ -131,7 +131,27 @@ function addEventHandler(state, eventName, eventHandler) {
 function getAuthorizationUrlWithState(state, options) {
-  return getAuthorizationUrl(_objectSpread2(_objectSpread2({}, options), {}, {
-    clientId: options.clientId || state.clientId,
-    allowSignup: options.allowSignup || state.allowSignup,
-    baseUrl: options.baseUrl || state.baseUrl,
-    scopes: options.scopes || state.defaultScopes
+  const {
+    clientId = state.clientId,
+    allowSignup = state.allowSignup,
+    baseUrl = state.baseUrl,
+    scopes = state.defaultScopes,
+    // TODO: https://github.com/octokit/oauth-app.js/pull/203#issuecomment-799683991
+    clientType = /^lv1\./.test(clientId) ? "github-app" : "oauth-app"
+  } = options,
+        otherOptions = _objectWithoutProperties(options, ["clientId", "allowSignup", "baseUrl", "scopes", "clientType"]);
+
+  if (clientType === "oauth-app") {
+    return getAuthorizationUrl(_objectSpread2(_objectSpread2({}, otherOptions), {}, {
+      clientType: "oauth-app",
+      clientId,
+      allowSignup,
+      baseUrl,
+      scopes
+    }));
+  }
+
+  return getAuthorizationUrl(_objectSpread2(_objectSpread2({}, otherOptions), {}, {
+    clientType: "github-app",
+    clientId,
+    allowSignup,
+    baseUrl
   }));
@@ -138,0 +158,0 @@ }

dist-src/methods/get-authorization-url.js

@@ -7,9 +7,22 @@ import { oauthAuthorizationUrl } from "@octokit/oauth-authorization-url";
 export function getAuthorizationUrlWithState(state, options) {
+    const { clientId = state.clientId, allowSignup = state.allowSignup, baseUrl = state.baseUrl, scopes = state.defaultScopes, 
+    // TODO: https://github.com/octokit/oauth-app.js/pull/203#issuecomment-799683991
+    clientType = /^lv1\./.test(clientId) ? "github-app" : "oauth-app", ...otherOptions } = options;
+    if (clientType === "oauth-app") {
+        return getAuthorizationUrl({
+            ...otherOptions,
+            clientType: "oauth-app",
+            clientId,
+            allowSignup,
+            baseUrl,
+            scopes,
+        });
+    }
     return getAuthorizationUrl({
-        ...options,
-        clientId: options.clientId || state.clientId,
-        allowSignup: options.allowSignup || state.allowSignup,
-        baseUrl: options.baseUrl || state.baseUrl,
-        scopes: options.scopes || state.defaultScopes,
+        ...otherOptions,
+        clientType: "github-app",
+        clientId,
+        allowSignup,
+        baseUrl,
     });
 }

dist-src/version.js

@@ -1,1 +0,1 @@
-export const VERSION = "2.0.4";
+export const VERSION = "2.0.5";

dist-types/methods/delete-authorization.d.ts

@@ -10,5 +10,5 @@ import { State } from "../types";
 };
-export declare function deleteAuthorization(options: Options): Promise<unknown>;
-export declare function deleteAuthorizationWithState(state: State, options: StateOptions): Promise<unknown>;
+export declare function deleteAuthorization(options: Options): Promise<never>;
+export declare function deleteAuthorizationWithState(state: State, options: StateOptions): Promise<never>;
 export declare type AppDeleteAuthorization = (options: StateOptions) => ReturnType<typeof deleteAuthorizationWithState>;
 export {};

dist-types/methods/delete-token.d.ts

@@ -10,5 +10,5 @@ import { State } from "../types";
 };
-export declare function deleteToken(options: Options): Promise<unknown>;
-export declare function deleteTokenWithState(state: State, options: StateOptions): Promise<unknown>;
+export declare function deleteToken(options: Options): Promise<never>;
+export declare function deleteTokenWithState(state: State, options: StateOptions): Promise<never>;
 export declare type AppDeleteToken = (options: StateOptions) => ReturnType<typeof deleteTokenWithState>;
 export {};

dist-types/version.d.ts

@@ -1,1 +0,1 @@
-export declare const VERSION = "2.0.4";
+export declare const VERSION = "2.0.5";

package.json

 {
   "name": "@octokit/oauth-app",
   "description": "GitHub OAuth toolset for Node.js",
-  "version": "2.0.4",
+  "version": "2.0.5",
   "license": "MIT",
@@ -18,3 +18,3 @@ "files": [
   ],
-  "repository": "https://github.com/octokit/oauth-app.js",
+  "repository": "github:octokit/oauth-app.js",
   "dependencies": {
@@ -24,3 +24,3 @@ "@octokit/auth-oauth-app": "^3.0.0",
     "@octokit/core": "^3.0.0",
-    "@octokit/oauth-authorization-url": "^4.1.0",
+    "@octokit/oauth-authorization-url": "^4.2.1",
     "@types/btoa-lite": "^1.0.0",
@@ -27,0 +27,0 @@ "btoa-lite": "^1.0.0",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No repository

Supply chain risk

Package does not have a linked source code repository. Without this field, a package will have no reference to the location of the source code use to generate the package.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No repository

Supply chain risk

Package does not have a linked source code repository. Without this field, a package will have no reference to the location of the source code use to generate the package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

129609

increased by1.38%

Lines of code

1703

increased by1.85%

Dependency changes

• Updated@octokit/oauth-authorization-url@^4.2.1