@pager/minion-army - npm Package Compare versions

Comparing version 0.4.1 to 0.5.0

lib/index.js

@@ -6,6 +6,16 @@ 'use strict'
 const Jackrabbit = require('@pager/jackrabbit')
-const joi = require('joi')
-const Validation = require('@pager/minion-joi')
+const joi = require('@hapi/joi')
 const schema = require('./schema')
 
+const validatorFactory = (handler, schema) => (payload) => {
+
+  const { error, value } = joi.validate(payload, schema, { stripUnknown: true })
+
+  if (error) {
+    throw error
+  }
+
+  return handler(value)
+}
+
 module.exports = (_manifest) => {
@@ -29,4 +39,3 @@ const { error, value: validatedManifest } = joi.validate(_manifest, schema)
   const minions = manifest.workers.reduce((minionsByName, worker) => {
-    const validator = Validation(worker.validate || joi.any(), { stripUnknown: true })
-    const handlerWithValidation = validator(worker.handler)
+    const handlerWithValidation = validatorFactory(worker.handler, worker.validate || joi.any())
 
@@ -33,0 +42,0 @@ const minion = Minion(handlerWithValidation, {

lib/schema.js

@@ -1,2 +0,2 @@
-const Joi = require('joi')
+const Joi = require('@hapi/joi')
 
@@ -3,0 +3,0 @@ const rabbit = Joi.object() // TODO: validate that rabbit object complies with jackrabbit interface

package.json

 {
   "name": "@pager/minion-army",
-  "version": "0.4.1",
+  "version": "0.5.0",
   "description": "Microservice Framework for RabbitMQ Workers",
   "main": "lib/index.js",
   "scripts": {
-    "test": "nyc ava --timeout=2m"
+    "test": "nyc ava --timeout=10s"
   },
@@ -23,8 +23,8 @@ "keywords": [
   "dependencies": {
+    "@hapi/joi": "15.x.x",
     "@pager/jackrabbit": "4.x.x",
-    "@pager/minion": "3.x.x",
-    "@pager/minion-joi": "1.x.x"
+    "@pager/minion": "3.x.x"
   },
   "devDependencies": {
-    "ava": "1.x.x",
+    "ava": "2.x.x",
     "eslint": "5.x.x",
@@ -37,3 +37,8 @@ "eslint-config-standard": "12.x.x",
     "nyc": "14.x.x"
+  },
+  "renovate": {
+    "extends": [
+      "github>pagerinc/renovate-config"
+    ]
   }
 }

README.md

@@ -8,2 +8,3 @@ # minion-army
 const Army = require('@pager/minion-army');
+const Joi = require('@hapi/joi');
 
@@ -25,4 +26,4 @@ // Refer to lib/schema.js to see valid options
             },
-            validate: joi.object({ // set a joi schema to validate handler input (optional)
-                id: joi.string().required()
+            validate: Joi.object({ // set a joi schema to validate handler input (optional)
+                id: Joi.string().required()
             })
@@ -29,0 +30,0 @@ },

test/index.js

 const test = require('ava')
 const Army = require('../lib/index')
-const joi = require('joi')
+const joi = require('@hapi/joi')
 
@@ -5,0 +5,0 @@ test('Creates army from manifest and workers work', async t => {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

8931

increased by16.64%

Number of lines in readme file

42

increased by2.44%

Worsened metrics

Number of package files

8

decreased by-11.11%

Dependency changes

• + Added@hapi/joi@15.x.x

• + Added@hapi/address@2.1.4(transitive)

• + Added@hapi/bourne@1.3.2(transitive)

• + Added@hapi/hoek@8.5.1(transitive)

• + Added@hapi/joi@15.1.1(transitive)

• + Added@hapi/topo@3.1.6(transitive)

• - Removed@pager/minion-joi@1.x.x

• - Removed@pager/minion-joi@1.1.0(transitive)

• - Removedhoek@5.0.46.1.3(transitive)

• - Removedisemail@3.2.0(transitive)

• - Removedjoi@13.7.0(transitive)

• - Removedpunycode@2.3.1(transitive)

• - Removedtopo@3.0.3(transitive)