@percy/core - npm Package Compare versions

Comparing version 1.28.1-alpha.3 to 1.28.1-alpha.4

dist/config.js

@@ -255,6 +255,2 @@ // Common config options used in Percy commands
       },
-      retry: {
-        type: 'boolean',
-        default: false
-      },
       launchOptions: {
@@ -261,0 +257,0 @@ type: 'object',

dist/discovery.js

 import logger from '@percy/logger';
 import Queue from './queue.js';
-import { normalizeURL, hostnameMatches, createResource, createRootResource, createPercyCSSResource, createLogResource, yieldAll, snapshotLogName, withRetries } from './utils.js';
+import { normalizeURL, hostnameMatches, createResource, createRootResource, createPercyCSSResource, createLogResource, yieldAll, snapshotLogName } from './utils.js';
 
@@ -282,4 +282,3 @@ // Logs verbose debug logs detailing various snapshot options.
   let {
-    concurrency,
-    retry
+    concurrency
   } = percy.config.discovery;
@@ -323,44 +322,35 @@ let queue = new Queue('discovery');
     percy.log.debug(`Asset discovery Browser Page enable JS: ${assetDiscoveryPageEnableJS}`);
-    await withRetries(async function* () {
-      // create a new browser page
-      let page = yield percy.browser.page({
-        enableJavaScript: assetDiscoveryPageEnableJS,
-        networkIdleTimeout: snapshot.discovery.networkIdleTimeout,
-        requestHeaders: snapshot.discovery.requestHeaders,
-        authorization: snapshot.discovery.authorization,
-        userAgent: snapshot.discovery.userAgent,
-        captureMockedServiceWorker: snapshot.discovery.captureMockedServiceWorker,
-        meta: snapshot.meta,
-        // enable network inteception
-        intercept: {
-          enableJavaScript: snapshot.enableJavaScript,
-          disableCache: snapshot.discovery.disableCache,
-          allowedHostnames: snapshot.discovery.allowedHostnames,
-          disallowedHostnames: snapshot.discovery.disallowedHostnames,
-          getResource: u => snapshot.resources.get(u) || cache.get(u),
-          saveResource: r => {
-            snapshot.resources.set(r.url, r);
-            if (!r.root) {
-              cache.set(r.url, r);
-            }
+    // create a new browser page
+    let page = yield percy.browser.page({
+      enableJavaScript: assetDiscoveryPageEnableJS,
+      networkIdleTimeout: snapshot.discovery.networkIdleTimeout,
+      requestHeaders: snapshot.discovery.requestHeaders,
+      authorization: snapshot.discovery.authorization,
+      userAgent: snapshot.discovery.userAgent,
+      captureMockedServiceWorker: snapshot.discovery.captureMockedServiceWorker,
+      meta: snapshot.meta,
+      // enable network inteception
+      intercept: {
+        enableJavaScript: snapshot.enableJavaScript,
+        disableCache: snapshot.discovery.disableCache,
+        allowedHostnames: snapshot.discovery.allowedHostnames,
+        disallowedHostnames: snapshot.discovery.disallowedHostnames,
+        getResource: u => snapshot.resources.get(u) || cache.get(u),
+        saveResource: r => {
+          snapshot.resources.set(r.url, r);
+          if (!r.root) {
+            cache.set(r.url, r);
           }
         }
-      });
-      try {
-        yield* captureSnapshotResources(page, snapshot, {
-          captureWidths: !snapshot.domSnapshot && percy.deferUploads,
-          capture: callback
-        });
-      } finally {
-        // always close the page when done
-        await page.close();
       }
-    }, {
-      count: retry ? 3 : 1,
-      onRetry: () => {
-        percy.log.info(`Retrying snapshot: ${snapshotLogName(snapshot.name, snapshot.meta)}`, snapshot.meta);
-      },
-      signal: snapshot._ctrl.signal,
-      throwOn: ['AbortError']
     });
+    try {
+      yield* captureSnapshotResources(page, snapshot, {
+        captureWidths: !snapshot.domSnapshot && percy.deferUploads,
+        capture: callback
+      });
+    } finally {
+      // always close the page when done
+      await page.close();
+    }
   }).handle('error', ({
@@ -367,0 +357,0 @@ name,

dist/network.js

@@ -31,3 +31,2 @@ import { request as makeRequest } from '@percy/client/utils';
   #aborted = new Set();
-  #finishedUrls = new Set();
   constructor(page, options) {
@@ -83,8 +82,2 @@ this.page = page;
       requests = Array.from(this.#requests.values()).filter(filter);
-      // remove requests which are finished at least once
-      // this happens when same request is made multiple times by browser in parallel and one of
-      // them gets stuck in pending state in browser [ need to debug why ]. So we dont receive
-      // loadingFinished event, causing it to show up in Active requests, but we can only store one
-      // response per url so as long as we have captured one, we dont care about other such requests
-      requests = requests.filter(req => !this.#finishedUrls.has(req.url));
       return requests.length === 0;
@@ -132,8 +125,6 @@ }, {
     requestId,
-    interceptId,
-    url
+    interceptId
   }, keepPending) {
     this.#requests.delete(requestId);
     this.#authentications.delete(interceptId);
-    this.#finishedUrls.add(url);
     if (!keepPending) {
@@ -140,0 +131,0 @@ this.#pending.delete(requestId);

dist/queue.js

@@ -125,11 +125,5 @@ function _classPrivateMethodInitSpec(obj, privateSet) { _checkPrivateRedeclaration(obj, privateSet); privateSet.add(obj); }
     let exists = this.cancel(item);
-    task.ctrl = new AbortController();
-    // duplicate abortion controller on task, so it can can be used in further
-    // generators and can be cancelled internally
-    // TODO fix this for non object item usecase
-    if (typeof item === 'object' && !Array.isArray(item) && item !== null) {
-      item._ctrl = task.ctrl;
-    }
     task.item = item = _classPrivateFieldGet(this, _handlers).push ? _classPrivateFieldGet(this, _handlers).push(item, exists) : item;
     task.handler = () => _classPrivateFieldGet(this, _handlers).task ? _classPrivateFieldGet(this, _handlers).task(item, ...args) : item;
+    task.ctrl = new AbortController();
 
@@ -136,0 +130,0 @@ // queue this task & maybe dequeue the next task

dist/utils.js

@@ -331,25 +331,2 @@ import EventEmitter from 'events';
 }
-export async function withRetries(fn, {
-  count,
-  onRetry,
-  signal,
-  throwOn
-}) {
-  count || (count = 1); // default a single try
-  let run = 0;
-  while (true) {
-    run += 1;
-    try {
-      return await generatePromise(fn, signal);
-    } catch (e) {
-      // if this error should not be retried on, we want to skip errors
-      let throwError = throwOn === null || throwOn === void 0 ? void 0 : throwOn.includes(e.name);
-      if (!throwError && run < count) {
-        await (onRetry === null || onRetry === void 0 ? void 0 : onRetry());
-        continue;
-      }
-      throw e;
-    }
-  }
-}
 export function snapshotLogName(name, meta) {
@@ -356,0 +333,0 @@ var _meta$snapshot;

package.json

 {
   "name": "@percy/core",
-  "version": "1.28.1-alpha.3",
+  "version": "1.28.1-alpha.4",
   "license": "MIT",
@@ -12,3 +12,3 @@ "repository": {
     "access": "public",
-    "tag": "alpha"
+    "tag": "beta"
   },
@@ -47,7 +47,7 @@ "engines": {
   "dependencies": {
-    "@percy/client": "1.28.1-alpha.3",
-    "@percy/config": "1.28.1-alpha.3",
-    "@percy/dom": "1.28.1-alpha.3",
-    "@percy/logger": "1.28.1-alpha.3",
-    "@percy/webdriver-utils": "1.28.1-alpha.3",
+    "@percy/client": "1.28.1-alpha.4",
+    "@percy/config": "1.28.1-alpha.4",
+    "@percy/dom": "1.28.1-alpha.4",
+    "@percy/logger": "1.28.1-alpha.4",
+    "@percy/webdriver-utils": "1.28.1-alpha.4",
     "content-disposition": "^0.5.4",
@@ -63,3 +63,3 @@ "cross-spawn": "^7.0.3",
   },
-  "gitHead": "46d1e874e1092fee45899d70cd97cf793db17de5"
+  "gitHead": "90d1c1135441a631d5fdbbce0a7e2efbe8ab4e21"
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

200549

decreased by-0.96%

Lines of code

4843

decreased by-1.06%

Dependency changes

• + Added@percy/client@1.28.1-alpha.4(transitive)

• + Added@percy/config@1.28.1-alpha.4(transitive)

• + Added@percy/dom@1.28.1-alpha.4(transitive)

• + Added@percy/env@1.28.1-alpha.4(transitive)

• + Added@percy/logger@1.28.1-alpha.4(transitive)

• + Added@percy/sdk-utils@1.28.1-alpha.4(transitive)

• + Added@percy/webdriver-utils@1.28.1-alpha.4(transitive)

• - Removed@percy/client@1.28.1-alpha.3(transitive)

• - Removed@percy/config@1.28.1-alpha.3(transitive)

• - Removed@percy/dom@1.28.1-alpha.3(transitive)

• - Removed@percy/env@1.28.1-alpha.3(transitive)

• - Removed@percy/logger@1.28.1-alpha.3(transitive)

• - Removed@percy/sdk-utils@1.28.1-alpha.3(transitive)

• - Removed@percy/webdriver-utils@1.28.1-alpha.3(transitive)

• Updated@percy/client@1.28.1-alpha.4

• Updated@percy/config@1.28.1-alpha.4

• Updated@percy/dom@1.28.1-alpha.4

• Updated@percy/logger@1.28.1-alpha.4

• Updated@percy/webdriver-utils@1.28.1-alpha.4