@push-rpc/core - npm Package Compare versions

Comparing version 1.2.0 to 1.2.5

dist/RpcSession.js

@@ -270,3 +270,3 @@ "use strict";
                     name: name,
-                    params: p,
+                    params: cloneParams(p),
                     resolve: resolve,
@@ -401,3 +401,3 @@ reject: reject,
                         r = _a.sent();
-                        this.send(rpc_1.MessageType.Data, messageId, topic.getTopicName(), params, r);
+                        this.send(rpc_1.MessageType.Data, messageId, topic.getTopicName(), cloneParams(params), r);
                         this.subscriptions.push({ topic: topic, params: params });
@@ -447,1 +447,11 @@ this.listeners.subscribed(this.subscriptions.length);
 exports.PONG_MESSAGE = "PONG";
+function cloneParams(p) {
+    if (!p)
+        return p;
+    if (typeof p == "object") {
+        if (p instanceof Date)
+            return p;
+        return __assign({}, p);
+    }
+    return p;
+}

package.json

 {
   "name": "@push-rpc/core",
-  "version": "1.2.0",
+  "version": "1.2.5",
   "main": "dist/index.js",
@@ -20,3 +20,3 @@ "types": "dist/index.d.ts",
   },
-  "gitHead": "ea55b58bf0f022332eea31d2e1987b76cd351ea9"
+  "gitHead": "5f0bfc47365d0a6e47d807d3cece5d86a7333bd2"
 }

src/RpcSession.ts

 import {LocalTopicImpl} from "./local"
 import {log} from "./logger"
 import {createRemote, RemoteTopicImpl} from "./remote"
-import {getServiceItem, MessageType, Method, Middleware, RpcConnectionContext, RpcContext,} from "./rpc"
+import {
+  getServiceItem,
+  MessageType,
+  Method,
+  Middleware,
+  RpcConnectionContext,
+  RpcContext,
+} from "./rpc"
 import {Socket} from "./transport"
@@ -252,3 +259,3 @@ import {createMessageId, message} from "./utils"
           name: name,
-          params: p,
+          params: cloneParams(p),
           resolve,
@@ -360,3 +367,3 @@ reject,
 
-      this.send(MessageType.Data, messageId, topic.getTopicName(), params, r)
+      this.send(MessageType.Data, messageId, topic.getTopicName(), cloneParams(params), r)
 
@@ -407,1 +414,10 @@ this.subscriptions.push({topic, params})
 export const PONG_MESSAGE = "PONG"
+
+function cloneParams(p) {
+  if (!p) return p
+  if (typeof p == "object") {
+    if (p instanceof Date) return p
+    return {...p}
+  }
+  return p
+}

tests/middleware.ts

 import {assert} from "chai"
 import {composeMiddleware, LocalTopicImpl, MessageType} from "../src"
 import {Middleware} from "../src/rpc"
-import {message} from "../src/utils"
 import {createTestClient, startTestServer} from "./testUtils"
@@ -52,7 +51,5 @@
 
-    await startTestServer(
-      {
-        item: new LocalTopicImpl(async () => "1"),
-      }
-    )
+    await startTestServer({
+      item: new LocalTopicImpl(async () => "1"),
+    })
 
@@ -89,3 +86,3 @@ const client = await createTestClient(0, {
     const client = await createTestClient(0)
-    await client.item.subscribe(data => r = data)
+    await client.item.subscribe(data => (r = data))
 
@@ -101,7 +98,5 @@ await new Promise(r => setTimeout(r, 50))
 
-    await startTestServer(
-      {
-        item: new LocalTopicImpl(async () => "1"),
-      }
-    )
+    await startTestServer({
+      item: new LocalTopicImpl(async () => "1"),
+    })
 
@@ -116,3 +111,3 @@ let r = null
     })
-    await client.item.subscribe(data => r = data)
+    await client.item.subscribe(data => (r = data))
 
@@ -119,0 +114,0 @@ await new Promise(r => setTimeout(r, 50))

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

145292

increased by0.54%

Number of package files

45

increased by2.27%

Lines of code

3862

increased by0.97%

No dependency changes