@react-aria/menu - npm Package Compare versions

Comparing version 3.14.2-nightly.4701 to 3.14.2-nightly.4704

dist/types.d.ts

 import { AriaMenuProps, MenuTriggerType } from "@react-types/menu";
-import { DOMAttributes, KeyboardDelegate, KeyboardEvents, DOMProps, FocusableElement, FocusEvents, HoverEvents, Key, PressEvents, Node } from "@react-types/shared";
-import { RefObject, ReactNode } from "react";
+import { DOMAttributes, KeyboardDelegate, KeyboardEvents, RefObject, DOMProps, FocusableElement, FocusEvents, HoverEvents, Key, PressEvents, Node } from "@react-types/shared";
 import { TreeState } from "@react-stately/tree";
 import { AriaButtonProps } from "@react-types/button";
 import { MenuTriggerState, SubmenuTriggerState } from "@react-stately/menu";
+import { ReactNode } from "react";
 import { AriaPopoverProps, OverlayProps } from "@react-aria/overlays";
@@ -8,0 +8,0 @@ export interface MenuAria {

dist/useMenuItem.main.js

@@ -43,4 +43,7 @@ var $a3815f0132802737$exports = require("./useMenu.main.js");
         if (item === null || item === void 0 ? void 0 : (_item_props = item.props) === null || _item_props === void 0 ? void 0 : _item_props.onAction) item.props.onAction();
-        if (props.onAction) props.onAction(key);
-        else if (data.onAction) data.onAction(key);
+        if (data.onAction) {
+            // Must reassign to variable otherwise `this` binding gets messed up. Something to do with WeakMap.
+            let onAction = data.onAction;
+            onAction(key);
+        }
         if (e.target instanceof HTMLAnchorElement) router.open(e.target, e, item.props.href, item.props.routerOptions);
@@ -47,0 +50,0 @@ };

dist/useMenuItem.module.js

@@ -37,4 +37,7 @@ import {menuData as $d5336fe17ce95402$export$6f49b4016bfc8d56} from "./useMenu.module.js";
         if (item === null || item === void 0 ? void 0 : (_item_props = item.props) === null || _item_props === void 0 ? void 0 : _item_props.onAction) item.props.onAction();
-        if (props.onAction) props.onAction(key);
-        else if (data.onAction) data.onAction(key);
+        if (data.onAction) {
+            // Must reassign to variable otherwise `this` binding gets messed up. Something to do with WeakMap.
+            let onAction = data.onAction;
+            onAction(key);
+        }
         if (e.target instanceof HTMLAnchorElement) router.open(e.target, e, item.props.href, item.props.routerOptions);
@@ -41,0 +44,0 @@ };

dist/useMenuTrigger.main.js

 var $d1742ec2644a0949$exports = require("./intlStrings.main.js");
+require("react");
 var $jo7gW$reactariautils = require("@react-aria/utils");
@@ -32,2 +33,3 @@ var $jo7gW$reactariai18n = require("@react-aria/i18n");
 
+
 function $7211ab9328763fb9$export$dc9c12ed27dd1b49(props, state, ref) {
@@ -34,0 +36,0 @@ let { type: type = 'menu', isDisabled: isDisabled, trigger: trigger = 'press' } = props;

dist/useMenuTrigger.module.js

 import $czs6v$intlStringsmodulejs from "./intlStrings.module.js";
+import "react";
 import {useId as $czs6v$useId} from "@react-aria/utils";
@@ -26,2 +27,3 @@ import {useLocalizedStringFormatter as $czs6v$useLocalizedStringFormatter} from "@react-aria/i18n";
 
+
 function $168583247155ddda$export$dc9c12ed27dd1b49(props, state, ref) {
@@ -28,0 +30,0 @@ let { type: type = 'menu', isDisabled: isDisabled, trigger: trigger = 'press' } = props;

package.json

 {
   "name": "@react-aria/menu",
-  "version": "3.14.2-nightly.4701+76365df43",
+  "version": "3.14.2-nightly.4704+546ffa41f",
   "description": "Spectrum UI components in React",
@@ -25,14 +25,14 @@ "license": "Apache-2.0",
   "dependencies": {
-    "@react-aria/focus": "3.0.0-nightly.2989+76365df43",
-    "@react-aria/i18n": "3.0.0-nightly.2989+76365df43",
-    "@react-aria/interactions": "3.0.0-nightly.2989+76365df43",
-    "@react-aria/overlays": "3.0.0-nightly.2989+76365df43",
-    "@react-aria/selection": "3.0.0-nightly.2989+76365df43",
-    "@react-aria/utils": "3.0.0-nightly.2989+76365df43",
-    "@react-stately/collections": "3.0.0-nightly.2989+76365df43",
-    "@react-stately/menu": "3.7.2-nightly.4701+76365df43",
-    "@react-stately/tree": "3.0.0-nightly.2989+76365df43",
-    "@react-types/button": "3.9.5-nightly.4701+76365df43",
-    "@react-types/menu": "3.9.10-nightly.4701+76365df43",
-    "@react-types/shared": "3.0.0-nightly.2989+76365df43",
+    "@react-aria/focus": "3.0.0-nightly.2992+546ffa41f",
+    "@react-aria/i18n": "3.0.0-nightly.2992+546ffa41f",
+    "@react-aria/interactions": "3.0.0-nightly.2992+546ffa41f",
+    "@react-aria/overlays": "3.0.0-nightly.2992+546ffa41f",
+    "@react-aria/selection": "3.0.0-nightly.2992+546ffa41f",
+    "@react-aria/utils": "3.0.0-nightly.2992+546ffa41f",
+    "@react-stately/collections": "3.0.0-nightly.2992+546ffa41f",
+    "@react-stately/menu": "3.7.2-nightly.4704+546ffa41f",
+    "@react-stately/tree": "3.0.0-nightly.2992+546ffa41f",
+    "@react-types/button": "3.9.5-nightly.4704+546ffa41f",
+    "@react-types/menu": "3.9.10-nightly.4704+546ffa41f",
+    "@react-types/shared": "3.0.0-nightly.2992+546ffa41f",
     "@swc/helpers": "^0.5.0"
@@ -47,3 +47,3 @@ },
   },
-  "gitHead": "76365df434b6f65b137113557ba14a32ea466c8f"
+  "gitHead": "546ffa41f7d1d3a566950a14d8f46cf726891220"
 }

src/useMenu.ts

@@ -14,5 +14,4 @@ /*
 import {AriaMenuProps} from '@react-types/menu';
-import {DOMAttributes, Key, KeyboardDelegate, KeyboardEvents} from '@react-types/shared';
+import {DOMAttributes, Key, KeyboardDelegate, KeyboardEvents, RefObject} from '@react-types/shared';
 import {filterDOMProps, mergeProps} from '@react-aria/utils';
-import {RefObject} from 'react';
 import {TreeState} from '@react-stately/tree';
@@ -19,0 +18,0 @@ import {useSelectableList} from '@react-aria/selection';

src/useMenuItem.ts

@@ -13,3 +13,3 @@ /*
 
-import {DOMAttributes, DOMProps, FocusableElement, FocusEvents, HoverEvents, Key, KeyboardEvents, PressEvent, PressEvents, RouterOptions} from '@react-types/shared';
+import {DOMAttributes, DOMProps, FocusableElement, FocusEvents, HoverEvents, Key, KeyboardEvents, PressEvent, PressEvents, RefObject, RouterOptions} from '@react-types/shared';
 import {filterDOMProps, mergeProps, useLinkProps, useRouter, useSlotId} from '@react-aria/utils';
@@ -19,3 +19,2 @@ import {getItemCount} from '@react-stately/collections';
 import {menuData} from './useMenu';
-import {RefObject} from 'react';
 import {TreeState} from '@react-stately/tree';
@@ -141,6 +140,6 @@ import {useSelectableItem} from '@react-aria/selection';
 
-    if (props.onAction) {
-      props.onAction(key);
-    } else if (data.onAction) {
-      data.onAction(key);
+    if (data.onAction) {
+      // Must reassign to variable otherwise `this` binding gets messed up. Something to do with WeakMap.
+      let onAction = data.onAction;
+      onAction(key);
     }
@@ -147,0 +146,0 @@

src/useMenuTrigger.ts

@@ -19,3 +19,4 @@ /*
 import {MenuTriggerType} from '@react-types/menu';
-import {RefObject} from 'react';
+import {} from 'react';
+import {RefObject} from '@react-types/shared';
 import {useId} from '@react-aria/utils';
@@ -22,0 +23,0 @@ import {useLocalizedStringFormatter} from '@react-aria/i18n';

src/useSafelyMouseToSubmenu.ts

@@ -1,2 +0,4 @@
-import {RefObject, useEffect, useRef, useState} from 'react';
+
+import {RefObject} from '@react-types/shared';
+import {useEffect, useRef, useState} from 'react';
 import {useInteractionModality} from '@react-aria/interactions';
@@ -3,0 +5,0 @@ import {useResizeObserver} from '@react-aria/utils';

src/useSubmenuTrigger.ts

@@ -16,5 +16,5 @@ /*
 import type {AriaPopoverProps, OverlayProps} from '@react-aria/overlays';
-import {FocusableElement, FocusStrategy, KeyboardEvent, Node, PressEvent} from '@react-types/shared';
-import {RefObject, useCallback, useRef} from 'react';
+import {FocusableElement, FocusStrategy, KeyboardEvent, Node, PressEvent, RefObject} from '@react-types/shared';
 import type {SubmenuTriggerState} from '@react-stately/menu';
+import {useCallback, useRef} from 'react';
 import {useEffectEvent, useId, useLayoutEffect} from '@react-aria/utils';
@@ -21,0 +21,0 @@ import {useLocale} from '@react-aria/i18n';

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Manifest confusion

Supply chain risk

This package has inconsistent metadata. This could be malicious or caused by an error when publishing the package.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Manifest confusion

Supply chain risk

This package has inconsistent metadata. This could be malicious or caused by an error when publishing the package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

317144

increased by0.23%

Lines of code

3811

increased by0.32%

Dependency changes

• Updated@react-aria/focus@3.0.0-nightly.2992+546ffa41f

• Updated@react-aria/i18n@3.0.0-nightly.2992+546ffa41f

• Updated@react-aria/interactions@3.0.0-nightly.2992+546ffa41f

• Updated@react-aria/overlays@3.0.0-nightly.2992+546ffa41f

• Updated@react-aria/selection@3.0.0-nightly.2992+546ffa41f

• Updated@react-aria/utils@3.0.0-nightly.2992+546ffa41f

• Updated@react-stately/collections@3.0.0-nightly.2992+546ffa41f

• Updated@react-stately/menu@3.7.2-nightly.4704+546ffa41f

• Updated@react-stately/tree@3.0.0-nightly.2992+546ffa41f

• Updated@react-types/button@3.9.5-nightly.4704+546ffa41f

• Updated@react-types/menu@3.9.10-nightly.4704+546ffa41f

• Updated@react-types/shared@3.0.0-nightly.2992+546ffa41f