@ribajs/bs4 - npm Package Compare versions

Comparing version 1.2.1 to 1.2.2

package.json

 {
   "name": "@ribajs/bs4",
   "description": "Bootstrap 4 module for Riba.js",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "author": "Pascal Garber <[e-mail]>",
@@ -28,8 +28,8 @@ "contributors": [],
   "devDependencies": {
-    "@babel/cli": "^7.6.2",
-    "@babel/core": "^7.6.2",
+    "@babel/cli": "^7.6.4",
+    "@babel/core": "^7.6.4",
     "@babel/plugin-proposal-class-properties": "^7.5.5",
     "@babel/plugin-proposal-object-rest-spread": "^7.6.2",
     "@babel/plugin-transform-runtime": "^7.6.2",
-    "@babel/preset-env": "^7.6.2",
+    "@babel/preset-env": "^7.6.3",
     "@babel/preset-typescript": "^7.6.0",
@@ -40,8 +40,8 @@ "@types/jquery": "^3.3.28",
     "tslint": "^5.20.0",
-    "typescript": "^3.6.3",
-    "webpack": "^4.41.0",
+    "typescript": "^3.6.4",
+    "webpack": "^4.41.1",
     "webpack-cli": "^3.3.9"
   },
   "dependencies": {
-    "@ribajs/core": "^1.2.1",
+    "@ribajs/core": "^1.2.2",
     "@types/jquery": "^3.3.31",
@@ -56,2 +56,2 @@ "bootstrap": "^4.3.1",
   "homepage": "https://github.com/ribajs/riba#readme"
-}
+}

src/binders/index.ts

@@ -5,3 +5,4 @@ export { collapseOnUrlBinder } from './collapse-on-url.binder';
 export { expanOnUrlBinder } from './expan-on-url.binder';
-export { scrollspyStarBinder } from './scrollspy-star.binder';
+export { scrollspyClassBinder } from './scrollspy-class.binder';
 export { tooltipBinder } from './tooltip.binder';
+export { scrollToOnEventBinder } from './scroll-to-on-event.binder';

src/components/dropdown/dropdown.component.ts

@@ -21,3 +21,2 @@ import { Component, Debug, JQuery as $, IBinder } from '@ribajs/core';
     super(element);
-    const self = this;
     const $el = $(this.el);
@@ -24,0 +23,0 @@ this.dropdownService = new DropdownService($el.find('.dropdown-toggle')[0] as HTMLButtonElement);

src/components/index.ts

@@ -0,3 +1,4 @@
+export { Bs4ScrollspyComponent } from './bs4-scrollspy/bs4-scrollspy.component';
 export { TabsComponent } from './tabs/tabs.component';
 export { DropdownComponent } from './dropdown/dropdown.component';
 export { NavbarComponent } from './navbar/navbar.component';

src/components/navbar/navbar.component.ts

@@ -22,3 +22,2 @@ import { Component, Debug, JQuery as $, EventDispatcher, IBinder } from '@ribajs/core';
     super(element);
-    const self = this;
     const $el = $(this.el);
@@ -25,0 +24,0 @@ const $collapse = $el.find('.navbar-collapse');

src/components/tabs/tabs.component.ts

 import { Component, Debug, Binding, handleizeFormatter } from '@ribajs/core';
 import template from './tabs.component.html';
 
-interface Tab {
+export interface Tab {
   title: string;
@@ -9,5 +9,6 @@ content: string;
   active: boolean;
+  type?: string;
 }
 
-interface Scope {
+export interface Scope {
   tabs: Tab[];
@@ -208,17 +209,22 @@ activate: TabsComponent['activate'];
 
+  protected addTabByTemplate(tpl: HTMLTemplateElement) {
+    const title = tpl.getAttribute('title');
+    if (!title) {
+      console.error(new Error('template "title" attribute is required"'));
+      return;
+    }
+    const handle = tpl.getAttribute('handle') || handleizeFormatter.read(title);
+    if (!handle) {
+      console.error(new Error('template "handle" attribute is required"'));
+      return;
+    }
+    const type = tpl.getAttribute('type') || undefined;
+    const content = tpl.innerHTML;
+    this.scope.tabs.push({title, handle, content, active: false, type });
+  }
+
   protected addTabsByTemplate() {
     const templates = this.el.querySelectorAll<HTMLTemplateElement>('template');
     templates.forEach((tpl) => {
-      const title = tpl.getAttribute('title');
-      if (!title) {
-        console.error(new Error('template "title" attribute is required"'));
-        return;
-      }
-      const handle = tpl.getAttribute('handle') || handleizeFormatter.read(title);
-      if (!handle) {
-        console.error(new Error('template "handle" attribute is required"'));
-        return;
-      }
-      const content = tpl.innerHTML;
-      this.scope.tabs.push({title, handle, content, active: false});
+      this.addTabByTemplate(tpl);
     });
@@ -225,0 +231,0 @@ }

tsconfig.json

 {
-  "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "baseUrl": "./src/",
-    "outDir": "./lib/",
-    "types": ["jquery"],
+    "module": "commonjs",
+    "target": "es2017",
+    "typeRoots": ["./node_modules/@ribajs/core/src/types", "./node_modules/@types"],
+    "outDir": "dist",
+    "declaration": true,
+    "inlineSourceMap": true,
+    "noUnusedLocals": true,
+    "esModuleInterop": true
   },
-  "include": ["*.ts", "**/*.ts"]
-}
+  "include": ["src"],
+  "types": ["jest"]
+}

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No README

Quality

Package does not have a README. This may indicate a failed publish or a low quality package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

62427

increased by56.69%

Number of package files

38

increased by65.22%

Lines of code

1364

increased by22.44%

Number of medium quality alerts

1

decreased by-50%

Number of lines in readme file

23

increased byInfinity%

Dependency changes

• Updated@ribajs/core@^1.2.2