@rushstack/node-core-library - npm Package Compare versions

Comparing version 3.34.3 to 3.34.4

CHANGELOG.json

@@ -5,2 +5,14 @@ {
     {
+      "version": "3.34.4",
+      "tag": "@rushstack/node-core-library_v3.34.4",
+      "date": "Tue, 27 Oct 2020 15:10:13 GMT",
+      "comments": {
+        "patch": [
+          {
+            "comment": "Fix an issue where the TextAttribute.Bold ANSI escape was not rendered correctly by Linux"
+          }
+        ]
+      }
+    },
+    {
       "version": "3.34.3",
@@ -7,0 +19,0 @@ "tag": "@rushstack/node-core-library_v3.34.3",

CHANGELOG.md

 # Change Log - @rushstack/node-core-library
 
-This log was last generated on Tue, 06 Oct 2020 00:24:06 GMT and should not be manually modified.
+This log was last generated on Tue, 27 Oct 2020 15:10:13 GMT and should not be manually modified.
 
+## 3.34.4
+Tue, 27 Oct 2020 15:10:13 GMT
+
+### Patches
+
+- Fix an issue where the TextAttribute.Bold ANSI escape was not rendered correctly by Linux
+
 ## 3.34.3
@@ -6,0 +13,0 @@ Tue, 06 Oct 2020 00:24:06 GMT

lib/Terminal/AnsiEscape.js

@@ -99,4 +99,2 @@ "use strict";
                 return 'bold';
-            case Colors_1.ConsoleColorCodes.BoldOff:
-                return 'bold-off';
             case Colors_1.ConsoleColorCodes.Dim:
@@ -103,0 +101,0 @@ return 'dim';

lib/Terminal/Colors.d.ts

@@ -61,3 +61,2 @@ /**
     Bold = 1,
-    BoldOff = 21,
     Dim = 2,
@@ -64,0 +63,0 @@ NormalColorOrIntensity = 22,

lib/Terminal/Colors.js

@@ -61,3 +61,6 @@ "use strict";
     ConsoleColorCodes[ConsoleColorCodes["Bold"] = 1] = "Bold";
-    ConsoleColorCodes[ConsoleColorCodes["BoldOff"] = 21] = "BoldOff";
+    // On Linux, the "BoldOff" code instead causes the text to be double-underlined:
+    // https://en.wikipedia.org/wiki/Talk:ANSI_escape_code#SGR_21%E2%80%94%60Bold_off%60_not_widely_supported
+    // Use "NormalColorOrIntensity" instead
+    // BoldOff = 21,
     ConsoleColorCodes[ConsoleColorCodes["Dim"] = 2] = "Dim";
@@ -64,0 +67,0 @@ ConsoleColorCodes[ConsoleColorCodes["NormalColorOrIntensity"] = 22] = "NormalColorOrIntensity";

lib/Terminal/Terminal.js

@@ -241,3 +241,3 @@ "use strict";
                                     startColorCodes.push(Colors_1.ConsoleColorCodes.Bold);
-                                    endColorCodes.push(Colors_1.ConsoleColorCodes.BoldOff);
+                                    endColorCodes.push(Colors_1.ConsoleColorCodes.NormalColorOrIntensity);
                                     break;
@@ -244,0 +244,0 @@ }

package.json

 {
 	"name": "@rushstack/node-core-library",
-	"version": "3.34.3",
+	"version": "3.34.4",
 	"description": "Core libraries that every NodeJS toolchain project should use",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

895507

increased by0.09%

Lines of code

12514

increased by0.1%

No dependency changes