@ryohey/wavelet - npm Package Compare versions

Comparing version 0.7.2 to 0.7.3

dist/index.js

@@ -58,3 +58,6 @@ const audioDataToAudioBuffer = (audioData) => {
     getSamples(bank, instrument, pitch, velocity) {
-        const parameters = this.sampleParameters?.[bank]?.[instrument]?.[pitch]?.filter((s) => velocity >= s.velRange[0] && velocity <= s.velRange[1]) ?? [];
+        const instrumentParameters = this.sampleParameters[bank]?.[instrument] ??
+            this.sampleParameters[0]?.[instrument] ?? // fallback to bank 0
+            null;
+        const parameters = instrumentParameters?.[pitch]?.filter((s) => velocity >= s.velRange[0] && velocity <= s.velRange[1]) ?? [];
         const samples = [];
@@ -61,0 +64,0 @@ for (const parameter of parameters) {

dist/processor.js

@@ -50,3 +50,6 @@ (function () {
         getSamples(bank, instrument, pitch, velocity) {
-            const parameters = this.sampleParameters?.[bank]?.[instrument]?.[pitch]?.filter((s) => velocity >= s.velRange[0] && velocity <= s.velRange[1]) ?? [];
+            const instrumentParameters = this.sampleParameters[bank]?.[instrument] ??
+                this.sampleParameters[0]?.[instrument] ?? // fallback to bank 0
+                null;
+            const parameters = instrumentParameters?.[pitch]?.filter((s) => velocity >= s.velRange[0] && velocity <= s.velRange[1]) ?? [];
             const samples = [];
@@ -53,0 +56,0 @@ for (const parameter of parameters) {

dist/rendererWorker.js

@@ -68,3 +68,6 @@ (function () {
         getSamples(bank, instrument, pitch, velocity) {
-            const parameters = this.sampleParameters?.[bank]?.[instrument]?.[pitch]?.filter((s) => velocity >= s.velRange[0] && velocity <= s.velRange[1]) ?? [];
+            const instrumentParameters = this.sampleParameters[bank]?.[instrument] ??
+                this.sampleParameters[0]?.[instrument] ?? // fallback to bank 0
+                null;
+            const parameters = instrumentParameters?.[pitch]?.filter((s) => velocity >= s.velRange[0] && velocity <= s.velRange[1]) ?? [];
             const samples = [];
@@ -71,0 +74,0 @@ for (const parameter of parameters) {

package.json

 {
   "name": "@ryohey/wavelet",
-  "version": "0.7.2",
+  "version": "0.7.3",
   "description": "A wavetable synthesizer that never stops the UI thread created by AudioWorklet.",
@@ -20,13 +20,13 @@ "main": "dist/index.js",
   "devDependencies": {
-    "@rollup/plugin-commonjs": "^24.0.0",
-    "@rollup/plugin-node-resolve": "^15.0.1",
-    "@rollup/plugin-typescript": "^10.0.1",
-    "@types/audioworklet": "^0.0.36",
-    "@types/jest": "^29.2.4",
-    "jest": "^29.3.1",
-    "rollup": "^3.7.5",
-    "ts-jest": "^29.0.3",
-    "tslib": "^2.4.1",
-    "typescript": "^4.9.4"
+    "@rollup/plugin-commonjs": "^26.0.1",
+    "@rollup/plugin-node-resolve": "^15.2.3",
+    "@rollup/plugin-typescript": "^11.1.6",
+    "@types/audioworklet": "^0.0.55",
+    "@types/jest": "^29.5.12",
+    "jest": "^29.7.0",
+    "rollup": "^4.18.0",
+    "ts-jest": "^29.1.4",
+    "tslib": "^2.6.3",
+    "typescript": "^5.4.5"
   }
 }

src/processor/SampleTable.ts

@@ -51,4 +51,9 @@ import { SampleParameter, SampleRange } from "../SynthEvent"
   ): Sample[] {
+    const instrumentParameters =
+      this.sampleParameters[bank]?.[instrument] ??
+      this.sampleParameters[0]?.[instrument] ?? // fallback to bank 0
+      null
+
     const parameters =
-      this.sampleParameters?.[bank]?.[instrument]?.[pitch]?.filter(
+      instrumentParameters?.[pitch]?.filter(
         (s) => velocity >= s.velRange[0] && velocity <= s.velRange[1]
@@ -55,0 +60,0 @@ ) ?? []

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

503884

decreased by-0.13%

Number of package files

57

decreased by-5%

Lines of code

4977

decreased by-0.14%

No dependency changes