@sap/instance-manager - npm Package Compare versions

Comparing version 3.4.0 to 3.5.1

CHANGELOG.md

@@ -8,2 +8,12 @@ # Change Log
 
+## 3.5.1 - 2022-12-02
+
+### Changed
+- Fixing Errors responses from Instance Manager
+
+## 3.5.0 - 2022-12-01
+
+### Changed
+- Fixing Errors responses from Service Manager
+
 ## 3.4.0 - 2022-10-27
@@ -10,0 +20,0 @@

lib/instance-manager/Backend.js

@@ -27,3 +27,3 @@ 'use strict';
     if (err) {
-      return callback(err);
+      return callback(ErrorInfo(err));
     }
@@ -62,3 +62,3 @@
     if (err) {
-      return callback(err);
+      return callback(ErrorInfo(err));
     }
@@ -115,1 +115,11 @@
 
+function ErrorInfo(err){
+  if (err.responseError !== undefined){
+    return err;
+  }
+  var errorInfo = new Error(err.name);
+  errorInfo.responseError = err.name;
+  errorInfo.responseStatusCode = err.statusCode;
+  errorInfo.responseDescription = err.message;
+  return errorInfo;
+}

lib/MigrationManager.js

@@ -112,6 +112,11 @@ 'use strict';
       if (imErr && smErr) {
-        let message  = `${smErr.message} *** ${imErr.message}`;
+        let message  = `${smErr.responseDescription} *** ${imErr.responseDescription}`;
         let error = new Error(message);
-        // Maybe reconsider this, since 404 might mean deletion was already completed.
+        // Maybe reconsider this, since 404 might mean deletion was already completed.       
+        if (smErr.responseStatusCode === undefined){
+          smErr.statusCode = 404;
+          smErr.responseStatusCode = 404;
+        }
         error.statusCode = smErr.statusCode < imErr.statusCode ? imErr.statusCode : smErr.statusCode;
+        error.responseStatusCode = smErr.statusCode < imErr.statusCode ? imErr.statusCode : smErr.statusCode;
         return callback(error);
@@ -118,0 +123,0 @@ } else if (imErr) {

lib/service-manager/Backend.js

@@ -57,3 +57,3 @@ 'use strict';
     if (err) {
-      return cb(err);
+      return cb(ErrorInfo(err));
     }
@@ -78,3 +78,3 @@
         if (err) {
-          return cb(err);
+          return cb(ErrorInfo(err));
         }
@@ -94,3 +94,3 @@
     if (err) {
-      return cb(err);
+      return cb(ErrorInfo(err));
     }
@@ -102,3 +102,3 @@
       if (err) {
-        return cb(err);
+        return cb(ErrorInfo(err));
       }
@@ -120,3 +120,3 @@
       debug('Unable to retrieve all instances, error: %s', err);
-      return cb(err);
+      return cb(ErrorInfo(err));
     }
@@ -209,3 +209,3 @@ self._getBindings(null, function(err2, bindings) {
     if (err) {
-      return cb(err);
+      return cb(ErrorInfo(err));
     }
@@ -247,3 +247,3 @@
           if (err) {
-            return cb(err);
+            return cb(ErrorInfo(err));
           }
@@ -253,3 +253,3 @@
             if (err) {
-              return cb(err);
+              return cb(ErrorInfo(err));
             }
@@ -302,3 +302,3 @@
     if (err) {
-      return cb(err);
+      return cb(ErrorInfo(err));
     }
@@ -335,3 +335,3 @@
     if (err) {
-      return cb(err);
+      return cb(ErrorInfo(err));
     }
@@ -347,3 +347,3 @@
     if (err) {
-      return cb(err);
+      return cb(ErrorInfo(err));
     }
@@ -357,2 +357,4 @@
       error.statusCode = HTTP.NOT_FOUND;
+      error.responseDescription = 'Missing managed service instance for tenant ' + tenant;
+      error.responseStatusCode = 404;
       return cb(error);
@@ -418,3 +420,3 @@ }
     if (err) {
-      return cb(err);
+      return cb(ErrorInfo(err));
     }
@@ -514,2 +516,14 @@
   return instanceTenantsWithoutBinding;
-}
+}
+
+function ErrorInfo(err){
+  if (err.responseError !== undefined){
+    return err;
+  }
+  var errorInfo = new Error(err.name);
+  errorInfo.responseError = err.name;
+  errorInfo.responseStatusCode = err.statusCode;
+  errorInfo.responseDescription = err.message;
+  return errorInfo;
+}
+

npm-shrinkwrap.json

 {
   "name": "@sap/instance-manager",
-  "version": "3.4.0",
+  "version": "3.5.1",
   "lockfileVersion": 1,
@@ -5,0 +5,0 @@ "requires": true,

package.json

 {
   "name": "@sap/instance-manager",
-  "version": "3.4.0",
+  "version": "3.5.1",
   "main": "index.js",
@@ -5,0 +5,0 @@ "license": "SEE LICENSE IN LICENSE file",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

94465

increased by1.39%

Lines of code

1797

increased by1.58%

No dependency changes