@sap/xsenv - npm Package Compare versions

Comparing version 4.2.0 to 5.0.0

lib/k8sservice.js

@@ -24,3 +24,3 @@ 'use strict';
 function readFileContent(filePath) {
-  let content = fs.readFileSync(filePath, 'utf8');
+  let content = fs.readFileSync(filePath).toString('utf-8');
 
@@ -27,0 +27,0 @@ const parseAllJson = process.env.XSENV_PARSE_ALL_JSON === 'true' || false;

lib/serviceBindingService.js

@@ -70,3 +70,3 @@ 'use strict';
     const text = properties[name];
-    if (name && typeof text !== undefined) {
+    if (name && typeof text !== 'undefined') {
       switch (metaDataProperty.format) {
@@ -73,0 +73,0 @@ case 'text':{

lib/xsservices.js

@@ -86,14 +86,13 @@ 'use strict';
 function filterServices(arg1, arg2) {
-  const path = (arguments.length === 1) ? undefined : arg1;
-  const filter = (arguments.length === 1) ? arg1 : arg2;
+  const path = arguments.length === 1 ? undefined : arg1;
+  const filter = arguments.length === 1 ? arg1 : arg2;
 
-  let filterResults = serviceFilter.apply(readCFServices(), filter);
-  debug('CF Service filter with filter: %s, returned: %s.', filter, filterResults);
-  if (!filterResults || (filterResults && Array.isArray(filterResults) && !filterResults.length)) {
-    filterResults = serviceFilter.apply(readServiceBindingServices(path), filter);
-    debug('Service Binding Services filter with filter: %s and path: %s, returned: %s.', filter, (path ? path : 'default'), filterResults);
+  let filterResults = filterCFServices(path, filter);
+
+  if (!hasResults(filterResults)) {
+    filterResults = filterServiceBindingServices(path, filter);
   }
-  if (!filterResults || (filterResults && Array.isArray(filterResults) && !filterResults.length)) {
-    filterResults = serviceFilter.apply(readK8SServices(path), filter);
-    debug('K8s Service filter with filter: %s and path: %s, returned: %s.', filter, (path ? path : 'default'), filterResults);
+
+  if (!hasResults(filterResults)) {
+    filterResults = filterK8SServices(path, filter);
   }
@@ -104,2 +103,28 @@
 
+function filterCFServices(path, filter) {
+  const results = serviceFilter.apply(readCFServices(), filter);
+  logFilterResults('CF', filter, path, results);
+  return results;
+}
+
+function filterServiceBindingServices(path, filter) {
+  const results = serviceFilter.apply(readServiceBindingServices(path), filter);
+  logFilterResults('Service Binding', filter, path || 'default', results);
+  return results;
+}
+
+function filterK8SServices(path, filter) {
+  const results = serviceFilter.apply(readK8SServices(path), filter);
+  logFilterResults('K8s', filter, path || 'default', results);
+  return results;
+}
+
+function hasResults(results) {
+  return results && Array.isArray(results) && results.length > 0;
+}
+
+function logFilterResults(serviceType, filter, path, results) {
+  debug('%s Service filter with filter: %s and path: %s, returned: %s.', serviceType, filter, path, results);
+}
+
 /**
@@ -119,4 +144,4 @@ * Reads service credentials configuration from CloudFoundry environment variable <code>VCAP_SERVICES</code>
   var matches = path
-      ? filterServices(path, filter)
-      : filterServices(filter);
+    ? filterServices(path, filter)
+    : filterServices(filter);
 
@@ -123,0 +148,0 @@ if (matches.length !== 1) {

package.json

 {
   "name": "@sap/xsenv",
-  "version": "4.2.0",
+  "version": "5.0.0",
   "description": "Utility for easy setup and access of SAP HANA XS Advanced environment variables",
@@ -9,3 +9,3 @@ "repository": {},
   "engines": {
-    "node": "^12.0.0 || ^14.0.0 || ^16.0.0 || ^18.0.0 || ^20.0.0"
+    "node": "^18.0.0 || ^20.0.0"
   },
@@ -27,12 +27,12 @@ "files": [
   "devDependencies": {
-    "eslint": "3.2.2",
-    "filter-node-package": "2.2.0",
-    "c8": "7.10.0",
+    "eslint": "8.56.0",
+    "filter-node-package": "3.2.0",
+    "c8": "9.1.0",
     "lodash": "4.17.21",
-    "mocha": "7.1.1",
-    "mock-fs": "^4.10.1",
+    "mocha": "10.3.0",
+    "mock-fs": "5.2.0",
     "node-build": "^2.0.1",
     "node-style": "^2.0.0",
     "proxyquire": "^2.1.3",
-    "should": "10.0.0"
+    "should": "13.2.3"
   },
@@ -39,0 +39,0 @@ "dependencies": {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

140533

increased by148.58%

Lines of code

2652

increased by391.11%

Worsened metrics

Number of package files

13

decreased by-7.14%

Number of medium supply chain risk alerts

1

increased byInfinity%

No dependency changes