@schibsted/niche-ads - npm Package Compare versions

Comparing version 5.1.2 to 5.1.3

lib/Ads.d.ts

@@ -25,3 +25,3 @@ import type { AdsConfig, Device, EidsConfig, GlimrConfig, LoadAdsArguments, Placement, PlacementConfig, Ppids, WallpaperConfig, invCodeBuilderSignature } from './types';
     get adBlockerDetected(): boolean | null;
-    set ppids(newPpids: Ppids);
+    set ppids(newPpids: Ppids | null);
     private _invCodeBuilder;
@@ -28,0 +28,0 @@ constructor({ adsConfig, cdn, cogwheelCdn, wallpaper, eids, glimr, invCodeBuilder, }: {

lib/types.d.ts

@@ -25,6 +25,6 @@ export declare enum Device {
 type KeywordPerPageType = {
-    common: Keywords;
-    front: Keywords;
-    article: Keywords;
-    other: Keywords;
+    common?: Keywords;
+    front?: Keywords;
+    article?: Keywords;
+    other?: Keywords;
 };
@@ -62,2 +62,8 @@ export type PlacementConfig = {
         title: string;
+        video: {
+            duration: number;
+            playbackMethods: string[];
+            frameworks: any[];
+            content: string;
+        };
     }>;
@@ -64,0 +70,0 @@ nobid: boolean;

package.json

 {
     "name": "@schibsted/niche-ads",
-    "version": "5.1.2",
+    "version": "5.1.3",
     "description": "Package containing ads logic reappearing across our projects",
@@ -30,3 +30,3 @@ "main": "lib/index.js",
     },
-    "gitHead": "ae51183e8bb79ff2bd5bcbf30510a8e0fe8ed643"
+    "gitHead": "025e726d87093617838ab3214e7f9d662753dc15"
 }

src/Ads.ts

@@ -108,3 +108,3 @@ import { script, eventTarget } from '@schibsted/niche-utils';
 
-    private _ppids: Ppids | undefined;
+    private _ppids: Ppids | undefined | null;
 
@@ -117,3 +117,3 @@ private _adBlockerDetected: boolean | null = null;
 
-    set ppids(newPpids: Ppids) {
+    set ppids(newPpids: Ppids | null) {
         this._ppids = newPpids;
@@ -120,0 +120,0 @@

src/types.ts

@@ -28,6 +28,6 @@ export enum Device {
 type KeywordPerPageType = {
-    common: Keywords;
-    front: Keywords;
-    article: Keywords;
-    other: Keywords;
+    common?: Keywords;
+    front?: Keywords;
+    article?: Keywords;
+    other?: Keywords;
 };
@@ -67,2 +67,8 @@
         title: string;
+        video: {
+            duration: number;
+            playbackMethods: string[];
+            frameworks: any[];
+            content: string;
+        };
     }>;
@@ -69,0 +75,0 @@ nobid: boolean;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

61599

increased by0.56%

Lines of code

1272

increased by0.95%

No dependency changes