@segment/analytics.js-core - npm Package Compare versions

Comparing version 3.1.3 to 3.2.2

HISTORY.md

@@ -0,1 +1,19 @@
+
+3.2.2 / 2017-11-05
+==================
+
+ * Build updates on CI.
+ * This release has no application changes - it's an attempt to fix release commits on CI.
+
+
+3.2.1 / 2017-11-03
+==================
+
+ * Fix release commit in 3.2.0
+
+3.2.0 / 2017-11-03
+==================
+
+  * Send disabled events to Segment.
+
 3.1.3 / 2017-11-01
@@ -80,3 +98,3 @@ ==================
  * Pull integrations from individual repositories, located in the [segment-integrations GitHub organization](https://github.com/segment-integrations/). This change should be unnoticeable from a user perspective, but has huge benefits in that excluding integrations from custom builds is now much, much easier, and one integration's test failures will no longer prevent another integration's tests from running.
-  
+
   A noteworthy part of this change: All integrations are now pulled into Analytics.js in `component.json`, using an explicit version number.
@@ -222,3 +240,3 @@ In the future this part of the build process is very likely to change to be more of an automatic process, but for now--baby steps.
   * dist: rebuild
-  
+
 2.7.1 / 2015-03-05
@@ -225,0 +243,0 @@ ==================

karma.conf.ci.js

@@ -73,2 +73,6 @@ /* eslint-env node */
 
+    concurrency: 2,
+
+    retryLimit: 5,
+
     reporters: ['progress', 'junit'],
@@ -75,0 +79,0 @@

lib/analytics.js

@@ -308,4 +308,8 @@ 'use strict';
     this.log('plan %o - %o', event, plan);
-    if (plan.enabled === false) return this._callback(fn);
-    defaults(msg.integrations, plan.integrations || {});
+    if (plan.enabled === false) {
+      // Disabled events should always be sent to Segment.
+      defaults(msg.integrations, { All: false, 'Segment.io': true });
+    } else {
+      defaults(msg.integrations, plan.integrations || {});
+    }
   }
@@ -312,0 +316,0 @@

package.json

 {
   "name": "@segment/analytics.js-core",
   "author": "Segment <[e-mail]>",
-  "version": "3.1.3",
+  "version": "3.2.2",
   "description": "The hassle-free way to integrate analytics into any web application.",
@@ -6,0 +6,0 @@ "keywords": [

README.md

@@ -14,3 +14,7 @@ # analytics.js-core
 
+[analytics.js]: https://segment.com/docs/libraries/analytics.js/
 
-[analytics.js]: https://segment.com/docs/libraries/analytics.js/
+## Releasing
+
+1. Update the version in `package.json`.
+2. Run `robo release x.y.z` where `x.y.z` is the new version.

test/analytics.test.js

@@ -1127,3 +1127,3 @@ 'use strict';
 
-    it('should not call #_invoke if the event is disabled', function() {
+    it('should call #_invoke for Segment if the event is disabled', function() {
       analytics.options.plan = {
@@ -1135,3 +1135,5 @@ track: {
       analytics.track('event');
-      assert(!analytics._invoke.called);
+      assert(analytics._invoke.called);
+      var track = analytics._invoke.args[0][1];
+      assert.deepEqual({ All: false, 'Segment.io': true }, track.obj.integrations);
     });
@@ -1138,0 +1140,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

173226

increased by0.42%

Lines of code

3917

increased by0.2%

Number of lines in readme file

20

increased by25%

No dependency changes