@semantic-release/github - npm Package Compare versions

Comparing version 10.1.4 to 10.1.5

lib/definitions/errors.js

@@ -142,2 +142,15 @@ import { inspect } from "node:util";
 
+export function EMISMATCHGITHUBURL({ repositoryUrl, clone_url }) {
+  return {
+    message: "The git repository URL mismatches the GitHub URL.",
+    details: `The **semantic-release** \`repositoryUrl\` option must have the same repository name and owner as the GitHub repo.
+
+Your configuration for the \`repositoryUrl\` option is \`${stringify(repositoryUrl)}\` and the \`clone_url\` of your GitHub repo is \`${stringify(clone_url)}\`.
+
+By default the \`repositoryUrl\` option is retrieved from the \`repository\` property of your \`package.json\` or the [git origin url](https://git-scm.com/book/en/v2/Git-Basics-Working-with-Remotes) of the repository cloned by your CI environment.
+
+Note: If you have recently changed your GitHub repository name or owner, update the value in **semantic-release** \`repositoryUrl\` option and the \`repository\` property of your \`package.json\` respectively to match the new GitHub URL.`,
+  };
+}
+
 export function EINVALIDPROXY({ proxy }) {
@@ -144,0 +157,0 @@ return {

lib/verify.js

@@ -106,18 +106,19 @@ import {
     );
-
-    // https://github.com/semantic-release/github/issues/182
-    // Do not check for permissions in GitHub actions, as the provided token is an installation access token.
-    // octokit.request("GET /repos/{owner}/{repo}", {repo, owner}) does not return the "permissions" key in that case.
-    // But GitHub Actions have all permissions required for @semantic-release/github to work
-    if (env.GITHUB_ACTION) {
-      return;
-    }
-
     try {
       const {
-        data: {
-          permissions: { push },
-        },
+        data: { permissions, clone_url },
       } = await octokit.request("GET /repos/{owner}/{repo}", { repo, owner });
-      if (!push) {
+      // Verify if Repository Name wasn't changed
+      const parsedCloneUrl = parseGithubUrl(clone_url);
+      if (owner !== parsedCloneUrl.owner || repo !== parsedCloneUrl.repo) {
+        errors.push(
+          getError("EMISMATCHGITHUBURL", { repositoryUrl, clone_url }),
+        );
+      }
+
+      // https://github.com/semantic-release/github/issues/182
+      // Do not check for permissions in GitHub actions, as the provided token is an installation access token.
+      // octokit.request("GET /repos/{owner}/{repo}", {repo, owner}) does not return the "permissions" key in that case.
+      // But GitHub Actions have all permissions required for @semantic-release/github to work
+      if (!env.GITHUB_ACTION && !permissions?.push) {
         // If authenticated as GitHub App installation, `push` will always be false.
@@ -128,10 +129,8 @@ // We send another request to check if current authentication is an installation.
         if (
-          await octokit
+          !(await octokit
             .request("HEAD /installation/repositories", { per_page: 1 })
-            .catch(() => false)
+            .catch(() => false))
         ) {
-          return;
+          errors.push(getError("EGHNOPERMISSION", { owner, repo }));
         }
-
-        errors.push(getError("EGHNOPERMISSION", { owner, repo }));
       }
@@ -138,0 +137,0 @@ } catch (error) {

package.json

 {
   "name": "@semantic-release/github",
   "description": "semantic-release plugin to publish a GitHub release and comment on released Pull Requests/Issues",
-  "version": "10.1.4",
+  "version": "10.1.5",
   "type": "module",
@@ -6,0 +6,0 @@ "author": "Pierre Vanduynslager (https://twitter.com/@pvdlg_)",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

78107

increased by1.54%

Lines of code

1337

increased by0.75%

No dependency changes