@sentry-internal/feedback - npm Package Compare versions

Comparing version 7.88.0 to 7.89.0

cjs/index.js

@@ -119,4 +119,3 @@ Object.defineProperty(exports, '__esModule', { value: true });
 ) {
-  const hub = core.getCurrentHub();
-  const client = hub.getClient();
+  const client = core.getClient();
   const transport = client && client.getTransport();
@@ -142,63 +141,54 @@ const dsn = client && client.getDsn();
 
-  return new Promise((resolve, reject) => {
-    hub.withScope(async scope => {
-      // No use for breadcrumbs in feedback
-      scope.clearBreadcrumbs();
+  return core.withScope(async scope => {
+    // No use for breadcrumbs in feedback
+    scope.clearBreadcrumbs();
 
-      if ([FEEDBACK_API_SOURCE, FEEDBACK_WIDGET_SOURCE].includes(String(source))) {
-        scope.setLevel('info');
-      }
+    if ([FEEDBACK_API_SOURCE, FEEDBACK_WIDGET_SOURCE].includes(String(source))) {
+      scope.setLevel('info');
+    }
 
-      const feedbackEvent = await prepareFeedbackEvent({
-        scope,
-        client,
-        event: baseEvent,
-      });
+    const feedbackEvent = await prepareFeedbackEvent({
+      scope,
+      client,
+      event: baseEvent,
+    });
 
-      if (feedbackEvent === null) {
-        resolve();
-        return;
-      }
+    if (!feedbackEvent) {
+      return;
+    }
 
-      if (client && client.emit) {
-        client.emit('beforeSendFeedback', feedbackEvent, { includeReplay: Boolean(includeReplay) });
-      }
+    if (client.emit) {
+      client.emit('beforeSendFeedback', feedbackEvent, { includeReplay: Boolean(includeReplay) });
+    }
 
-      const envelope = core.createEventEnvelope(
-        feedbackEvent,
-        dsn,
-        client.getOptions()._metadata,
-        client.getOptions().tunnel,
-      );
+    const envelope = core.createEventEnvelope(feedbackEvent, dsn, client.getOptions()._metadata, client.getOptions().tunnel);
 
-      let response;
+    let response;
 
+    try {
+      response = await transport.send(envelope);
+    } catch (err) {
+      const error = new Error('Unable to send Feedback');
+
       try {
-        response = await transport.send(envelope);
-      } catch (err) {
-        const error = new Error('Unable to send Feedback');
-
-        try {
-          // In case browsers don't allow this property to be writable
-          // @ts-expect-error This needs lib es2022 and newer
-          error.cause = err;
-        } catch (e) {
-          // nothing to do
-        }
-        reject(error);
+        // In case browsers don't allow this property to be writable
+        // @ts-expect-error This needs lib es2022 and newer
+        error.cause = err;
+      } catch (e) {
+        // nothing to do
       }
+      throw error;
+    }
 
-      // TODO (v8): we can remove this guard once transport.send's type signature doesn't include void anymore
-      if (!response) {
-        resolve(response);
-        return;
-      }
+    // TODO (v8): we can remove this guard once transport.send's type signature doesn't include void anymore
+    if (!response) {
+      return;
+    }
 
-      // Require valid status codes, otherwise can assume feedback was not sent successfully
-      if (typeof response.statusCode === 'number' && (response.statusCode < 200 || response.statusCode >= 300)) {
-        reject(new Error('Unable to send Feedback'));
-      }
+    // Require valid status codes, otherwise can assume feedback was not sent successfully
+    if (typeof response.statusCode === 'number' && (response.statusCode < 200 || response.statusCode >= 300)) {
+      throw new Error('Unable to send Feedback');
+    }
 
-      resolve(response);
-    });
+    return response;
   });
@@ -1466,3 +1456,3 @@ }
       const userKey = options.useSentryUser;
-      const scope = core.getCurrentHub().getScope();
+      const scope = core.getCurrentScope();
       const user = scope && scope.getUser();
@@ -1469,0 +1459,0 @@

esm/index.js

 import { GLOBAL_OBJ, getLocationHref, logger, isBrowser } from '@sentry/utils';
-import { prepareEvent, getCurrentHub, createEventEnvelope } from '@sentry/core';
+import { prepareEvent, getClient, withScope, createEventEnvelope, getCurrentScope } from '@sentry/core';
 
@@ -117,4 +117,3 @@ // exporting a separate copy of `WINDOW` rather than exporting the one from `@sentry/browser`
 ) {
-  const hub = getCurrentHub();
-  const client = hub.getClient();
+  const client = getClient();
   const transport = client && client.getTransport();
@@ -140,63 +139,54 @@ const dsn = client && client.getDsn();
 
-  return new Promise((resolve, reject) => {
-    hub.withScope(async scope => {
-      // No use for breadcrumbs in feedback
-      scope.clearBreadcrumbs();
+  return withScope(async scope => {
+    // No use for breadcrumbs in feedback
+    scope.clearBreadcrumbs();
 
-      if ([FEEDBACK_API_SOURCE, FEEDBACK_WIDGET_SOURCE].includes(String(source))) {
-        scope.setLevel('info');
-      }
+    if ([FEEDBACK_API_SOURCE, FEEDBACK_WIDGET_SOURCE].includes(String(source))) {
+      scope.setLevel('info');
+    }
 
-      const feedbackEvent = await prepareFeedbackEvent({
-        scope,
-        client,
-        event: baseEvent,
-      });
+    const feedbackEvent = await prepareFeedbackEvent({
+      scope,
+      client,
+      event: baseEvent,
+    });
 
-      if (feedbackEvent === null) {
-        resolve();
-        return;
-      }
+    if (!feedbackEvent) {
+      return;
+    }
 
-      if (client && client.emit) {
-        client.emit('beforeSendFeedback', feedbackEvent, { includeReplay: Boolean(includeReplay) });
-      }
+    if (client.emit) {
+      client.emit('beforeSendFeedback', feedbackEvent, { includeReplay: Boolean(includeReplay) });
+    }
 
-      const envelope = createEventEnvelope(
-        feedbackEvent,
-        dsn,
-        client.getOptions()._metadata,
-        client.getOptions().tunnel,
-      );
+    const envelope = createEventEnvelope(feedbackEvent, dsn, client.getOptions()._metadata, client.getOptions().tunnel);
 
-      let response;
+    let response;
 
+    try {
+      response = await transport.send(envelope);
+    } catch (err) {
+      const error = new Error('Unable to send Feedback');
+
       try {
-        response = await transport.send(envelope);
-      } catch (err) {
-        const error = new Error('Unable to send Feedback');
-
-        try {
-          // In case browsers don't allow this property to be writable
-          // @ts-expect-error This needs lib es2022 and newer
-          error.cause = err;
-        } catch (e) {
-          // nothing to do
-        }
-        reject(error);
+        // In case browsers don't allow this property to be writable
+        // @ts-expect-error This needs lib es2022 and newer
+        error.cause = err;
+      } catch (e) {
+        // nothing to do
       }
+      throw error;
+    }
 
-      // TODO (v8): we can remove this guard once transport.send's type signature doesn't include void anymore
-      if (!response) {
-        resolve(response);
-        return;
-      }
+    // TODO (v8): we can remove this guard once transport.send's type signature doesn't include void anymore
+    if (!response) {
+      return;
+    }
 
-      // Require valid status codes, otherwise can assume feedback was not sent successfully
-      if (typeof response.statusCode === 'number' && (response.statusCode < 200 || response.statusCode >= 300)) {
-        reject(new Error('Unable to send Feedback'));
-      }
+    // Require valid status codes, otherwise can assume feedback was not sent successfully
+    if (typeof response.statusCode === 'number' && (response.statusCode < 200 || response.statusCode >= 300)) {
+      throw new Error('Unable to send Feedback');
+    }
 
-      resolve(response);
-    });
+    return response;
   });
@@ -1464,3 +1454,3 @@ }
       const userKey = options.useSentryUser;
-      const scope = getCurrentHub().getScope();
+      const scope = getCurrentScope();
       const user = scope && scope.getUser();
@@ -1467,0 +1457,0 @@

package.json

 {
   "name": "@sentry-internal/feedback",
-  "version": "7.88.0",
+  "version": "7.89.0",
   "description": "Sentry SDK integration for user feedback",
@@ -26,7 +26,7 @@ "repository": "git://github.com/getsentry/sentry-javascript.git",
   "dependencies": {
-    "@sentry/core": "7.88.0",
-    "@sentry/types": "7.88.0",
-    "@sentry/utils": "7.88.0"
+    "@sentry/core": "7.89.0",
+    "@sentry/types": "7.89.0",
+    "@sentry/utils": "7.89.0"
   },
   "sideEffects": false
 }

README.md

@@ -76,12 +76,11 @@ <p align="center">
 Sentry.setUser({
-    email: '[e-mail]',
+    userEmail: '[e-mail]',
     fullName: 'Jane Doe',
 });
 
-
 new Feedback({
-    useSentryUser({
-        email: 'email',
-        name: 'fullName',
-    }),
+  useSentryUser: {
+    email: 'userEmail',
+    name: 'fullName',
+  },
 })
@@ -88,0 +87,0 @@ ```

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

362730

decreased by-0.45%

Lines of code

4801

decreased by-0.41%

Number of lines in readme file

281

decreased by-0.35%

Dependency changes

• + Added@sentry/core@7.89.0(transitive)

• + Added@sentry/types@7.89.0(transitive)

• + Added@sentry/utils@7.89.0(transitive)

• - Removed@sentry/core@7.88.0(transitive)

• - Removed@sentry/types@7.88.0(transitive)

• - Removed@sentry/utils@7.88.0(transitive)

• Updated@sentry/core@7.89.0

• Updated@sentry/types@7.89.0

• Updated@sentry/utils@7.89.0