@sentry-internal/feedback - npm Package Compare versions

Comparing version 8.0.0-alpha.1 to 8.0.0-alpha.2

cjs/index.js

@@ -127,3 +127,3 @@ Object.defineProperty(exports, '__esModule', { value: true });
   if (!client || !transport || !dsn) {
-    return;
+    return utils.resolvedSyncPromise({});
   }
@@ -159,3 +159,3 @@
     if (!feedbackEvent) {
-      return;
+      return utils.resolvedSyncPromise({});
     }
@@ -184,7 +184,2 @@
 
-    // TODO (v8): we can remove this guard once transport.send's type signature doesn't include void anymore
-    if (!response) {
-      return;
-    }
-
     // Require valid status codes, otherwise can assume feedback was not sent successfully
@@ -670,3 +665,3 @@ if (typeof response.statusCode === 'number' && (response.statusCode < 200 || response.statusCode >= 300)) {
     // Not sure when this would happen
-    return;
+    return utils.resolvedSyncPromise({});
   }
@@ -692,2 +687,4 @@
   }
+
+  return utils.resolvedSyncPromise({});
 }
@@ -1411,3 +1408,3 @@
     // Error submitting feedback
-    if (!result) {
+    if (!result || Object.keys(result).length === 0) {
       if (options.onSubmitError) {
@@ -1414,0 +1411,0 @@ options.onSubmitError();

esm/index.js

@@ -1,2 +0,2 @@
-import { GLOBAL_OBJ, getLocationHref, logger, isBrowser } from '@sentry/utils';
+import { GLOBAL_OBJ, resolvedSyncPromise, getLocationHref, logger, isBrowser } from '@sentry/utils';
 import { prepareEvent, getIsolationScope, getClient, withScope, createEventEnvelope, getCurrentScope } from '@sentry/core';
@@ -125,3 +125,3 @@
   if (!client || !transport || !dsn) {
-    return;
+    return resolvedSyncPromise({});
   }
@@ -157,3 +157,3 @@
     if (!feedbackEvent) {
-      return;
+      return resolvedSyncPromise({});
     }
@@ -182,7 +182,2 @@
 
-    // TODO (v8): we can remove this guard once transport.send's type signature doesn't include void anymore
-    if (!response) {
-      return;
-    }
-
     // Require valid status codes, otherwise can assume feedback was not sent successfully
@@ -668,3 +663,3 @@ if (typeof response.statusCode === 'number' && (response.statusCode < 200 || response.statusCode >= 300)) {
     // Not sure when this would happen
-    return;
+    return resolvedSyncPromise({});
   }
@@ -690,2 +685,4 @@
   }
+
+  return resolvedSyncPromise({});
 }
@@ -1409,3 +1406,3 @@
     // Error submitting feedback
-    if (!result) {
+    if (!result || Object.keys(result).length === 0) {
       if (options.onSubmitError) {
@@ -1412,0 +1409,0 @@ options.onSubmitError();

package.json

 {
   "name": "@sentry-internal/feedback",
-  "version": "8.0.0-alpha.1",
+  "version": "8.0.0-alpha.2",
   "description": "Sentry SDK integration for user feedback",
@@ -32,7 +32,7 @@ "repository": "git://github.com/getsentry/sentry-javascript.git",
   "dependencies": {
-    "@sentry/core": "8.0.0-alpha.1",
-    "@sentry/types": "8.0.0-alpha.1",
-    "@sentry/utils": "8.0.0-alpha.1"
+    "@sentry/core": "8.0.0-alpha.2",
+    "@sentry/types": "8.0.0-alpha.2",
+    "@sentry/utils": "8.0.0-alpha.2"
   },
   "sideEffects": false
 }

types-ts3.8/util/handleFeedbackSubmit.d.ts

@@ -8,3 +8,3 @@ import { TransportMakeRequestResponse } from '@sentry/types';
  */
-export declare function handleFeedbackSubmit(dialog: DialogComponent | null, feedback: FeedbackFormData, options?: SendFeedbackOptions): Promise<TransportMakeRequestResponse | void>;
+export declare function handleFeedbackSubmit(dialog: DialogComponent | null, feedback: FeedbackFormData, options?: SendFeedbackOptions): Promise<TransportMakeRequestResponse>;
 //# sourceMappingURL=handleFeedbackSubmit.d.ts.map

types-ts3.8/util/sendFeedbackRequest.d.ts

@@ -6,3 +6,3 @@ import { TransportMakeRequestResponse } from '@sentry/types';
  */
-export declare function sendFeedbackRequest({ feedback: { message, email, name, source, url } }: SendFeedbackData, { includeReplay }?: SendFeedbackOptions): Promise<void | TransportMakeRequestResponse>;
+export declare function sendFeedbackRequest({ feedback: { message, email, name, source, url } }: SendFeedbackData, { includeReplay }?: SendFeedbackOptions): Promise<TransportMakeRequestResponse>;
 //# sourceMappingURL=sendFeedbackRequest.d.ts.map

types/util/handleFeedbackSubmit.d.ts

@@ -8,3 +8,3 @@ import type { TransportMakeRequestResponse } from '@sentry/types';
  */
-export declare function handleFeedbackSubmit(dialog: DialogComponent | null, feedback: FeedbackFormData, options?: SendFeedbackOptions): Promise<TransportMakeRequestResponse | void>;
+export declare function handleFeedbackSubmit(dialog: DialogComponent | null, feedback: FeedbackFormData, options?: SendFeedbackOptions): Promise<TransportMakeRequestResponse>;
 //# sourceMappingURL=handleFeedbackSubmit.d.ts.map

types/util/sendFeedbackRequest.d.ts

@@ -6,3 +6,3 @@ import type { TransportMakeRequestResponse } from '@sentry/types';
  */
-export declare function sendFeedbackRequest({ feedback: { message, email, name, source, url } }: SendFeedbackData, { includeReplay }?: SendFeedbackOptions): Promise<void | TransportMakeRequestResponse>;
+export declare function sendFeedbackRequest({ feedback: { message, email, name, source, url } }: SendFeedbackData, { includeReplay }?: SendFeedbackOptions): Promise<TransportMakeRequestResponse>;
 //# sourceMappingURL=sendFeedbackRequest.d.ts.map

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

358751

increased by0.09%

Worsened metrics

Lines of code

4886

decreased by-0.12%

Dependency changes

• + Added@sentry/core@8.0.0-alpha.2(transitive)

• + Added@sentry/types@8.0.0-alpha.2(transitive)

• + Added@sentry/utils@8.0.0-alpha.2(transitive)

• - Removed@sentry/core@8.0.0-alpha.1(transitive)

• - Removed@sentry/types@8.0.0-alpha.1(transitive)

• - Removed@sentry/utils@8.0.0-alpha.1(transitive)

• Updated@sentry/core@8.0.0-alpha.2

• Updated@sentry/types@8.0.0-alpha.2

• Updated@sentry/utils@8.0.0-alpha.2