@serenity-js/core - npm Package Compare versions

Comparing version 3.11.0 to 3.11.1

CHANGELOG.md

@@ -6,2 +6,13 @@ # Change Log
 
+## [3.11.1](https://github.com/serenity-js/serenity-js/compare/v3.11.0...v3.11.1) (2023-10-04)
+
+
+### Bug Fixes
+
+* **core:** allow for QuestionAdapter\<string\> to proxy .replaceAll() method ([f1200c1](https://github.com/serenity-js/serenity-js/commit/f1200c1648471088c1f2943770c1bb4cc940e22f))
+
+
+
+
+
 # [3.11.0](https://github.com/serenity-js/serenity-js/compare/v3.10.4...v3.11.0) (2023-10-03)
@@ -8,0 +19,0 @@

lib/screenplay/Question.d.ts

@@ -247,3 +247,3 @@ /// <reference types="node" />
 export type QuestionAdapterFieldDecorator<Original_Type> = {
-    [Field in keyof Omit<Original_Type, keyof QuestionStatement<Original_Type>>]: Original_Type[Field] extends (...args: infer OriginalParameters) => infer OriginalMethodResult ? Field extends 'replace' ? (searchValue: Answerable<string | RegExp>, replaceValue: Answerable<string>) => QuestionAdapter<string> : (...args: {
+    [Field in keyof Omit<Original_Type, keyof QuestionStatement<Original_Type>>]: Original_Type[Field] extends (...args: infer OriginalParameters) => infer OriginalMethodResult ? Field extends 'replace' | 'replaceAll' ? (searchValue: Answerable<string | RegExp>, replaceValue: Answerable<string>) => QuestionAdapter<string> : (...args: {
         [P in keyof OriginalParameters]: Answerable<Awaited<OriginalParameters[P]>>;
@@ -250,0 +250,0 @@ }) => QuestionAdapter<Awaited<OriginalMethodResult>> : Original_Type[Field] extends number | bigint | boolean | string | symbol | object ? QuestionAdapter<Awaited<Original_Type[Field]>> : any;

package.json

 {
   "name": "@serenity-js/core",
-  "version": "3.11.0",
+  "version": "3.11.1",
   "description": "Serenity/JS Screenplay, reporting engine and core interfaces.",
@@ -74,3 +74,3 @@ "author": {
   },
-  "gitHead": "4cd38cd3f6c8ea72e7e2776d76af9fa8a0672265"
+  "gitHead": "b3e36f6e42eb2c545afa961946469fb6dd93f4df"
 }

src/screenplay/Question.ts

@@ -446,7 +446,5 @@ import { isRecord } from 'tiny-types/lib/objects';
         Original_Type[Field] extends (...args: infer OriginalParameters) => infer OriginalMethodResult
-            // Workaround for TypeScript giving up too soon when resolving type aliases in lib.es2015.symbol.wellknown
-            ? Field extends 'replace'
+            // Workaround for TypeScript giving up too soon when resolving type aliases in lib.es2015.symbol.wellknown and lib.es2021.string
+            ? Field extends 'replace' | 'replaceAll'
                 ? (searchValue: Answerable<string | RegExp>, replaceValue: Answerable<string>) => QuestionAdapter<string>
-
-                // make the method signature asynchronous, accepting Answerables and returning a QuestionAdapter
                 : (...args: { [P in keyof OriginalParameters]: Answerable<Awaited<OriginalParameters[P]>> }) =>
@@ -453,0 +451,0 @@ QuestionAdapter<Awaited<OriginalMethodResult>>

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1364561

increased by0.02%

Worsened metrics

Lines of code

26984

No dependency changes