@serenity-js/web - npm Package Compare versions

Comparing version 3.1.2 to 3.1.3

CHANGELOG.md

@@ -6,2 +6,13 @@ # Change Log
 
+## [3.1.3](https://github.com/serenity-js/serenity-js/compare/v3.1.2...v3.1.3) (2023-04-14)
+
+
+### Bug Fixes
+
+* **protractor:** click interactions now scroll element into view before performing their action ([3ea7bb8](https://github.com/serenity-js/serenity-js/commit/3ea7bb8158302bfec0390dca6bc88060f0f291e9))
+
+
+
+
+
 ## [3.1.2](https://github.com/serenity-js/serenity-js/compare/v3.1.1...v3.1.2) (2023-04-07)
@@ -8,0 +19,0 @@

lib/screenplay/interactions/DoubleClick.js

@@ -93,3 +93,4 @@ "use strict";
         const element = await this.resolve(actor, this.pageElement);
-        return element.doubleClick();
+        await element.scrollIntoView();
+        await element.doubleClick();
     }
@@ -96,0 +97,0 @@ }

lib/screenplay/interactions/Hover.js

@@ -74,3 +74,4 @@ "use strict";
         const element = await this.resolve(actor, this.element);
-        return element.hoverOver();
+        await element.scrollIntoView();
+        await element.hoverOver();
     }
@@ -77,0 +78,0 @@ }

lib/screenplay/interactions/RightClick.d.ts

@@ -6,3 +6,3 @@ import { Answerable, AnswersQuestions, Interaction, UsesAbilities } from '@serenity-js/core';
  * Instructs an {@apilink Actor|actor} who has the {@apilink Ability|ability} to {@apilink BrowseTheWeb}
- * to perfom a right click on a given {@apilink PageElement}.
+ * to perform a right click on a given {@apilink PageElement}.
  *
@@ -9,0 +9,0 @@ * This is typically used to open a [custom context menu](https://developer.mozilla.org/en-US/docs/Web/API/Element/click_event)

lib/screenplay/interactions/RightClick.js

@@ -8,3 +8,3 @@ "use strict";
  * Instructs an {@apilink Actor|actor} who has the {@apilink Ability|ability} to {@apilink BrowseTheWeb}
- * to perfom a right click on a given {@apilink PageElement}.
+ * to perform a right click on a given {@apilink PageElement}.
  *
@@ -90,3 +90,4 @@ * This is typically used to open a [custom context menu](https://developer.mozilla.org/en-US/docs/Web/API/Element/click_event)
         const element = await this.resolve(actor, this.pageElement);
-        return element.rightClick();
+        await element.scrollIntoView();
+        await element.rightClick();
     }
@@ -93,0 +94,0 @@ }

lib/screenplay/interactions/Scroll.d.ts

@@ -5,3 +5,3 @@ import { Answerable, AnswersQuestions, Interaction, UsesAbilities } from '@serenity-js/core';
  * Instructs an {@apilink Actor|actor} who has the {@apilink Ability|ability} to {@apilink BrowseTheWeb}
- * to scroll until a given Web element comes into view.
+ * to scroll until a given {@apilink PageElement} comes into view.
  *
@@ -8,0 +8,0 @@ * ## Example widget

lib/screenplay/interactions/Scroll.js

@@ -7,3 +7,3 @@ "use strict";
  * Instructs an {@apilink Actor|actor} who has the {@apilink Ability|ability} to {@apilink BrowseTheWeb}
- * to scroll until a given Web element comes into view.
+ * to scroll until a given {@apilink PageElement} comes into view.
  *
@@ -72,3 +72,3 @@ * ## Example widget
         const target = await actor.answer(this.element);
-        return target.scrollIntoView();
+        await target.scrollIntoView();
     }
@@ -75,0 +75,0 @@ }

package.json

 {
   "name": "@serenity-js/web",
-  "version": "3.1.2",
+  "version": "3.1.3",
   "description": "Serenity/JS Screenplay Pattern APIs for the Web",
@@ -47,4 +47,4 @@ "author": {
   "dependencies": {
-    "@serenity-js/assertions": "3.1.2",
-    "@serenity-js/core": "3.1.2",
+    "@serenity-js/assertions": "3.1.3",
+    "@serenity-js/core": "3.1.3",
     "tiny-types": "^1.19.1"
@@ -62,3 +62,3 @@ },
   },
-  "gitHead": "0c8881d5e7085f9b7885ae325235665de0e71b8b"
+  "gitHead": "6cabc4cb6e6f25411862c7375738b931012b6361"
 }

src/screenplay/interactions/DoubleClick.ts

@@ -95,4 +95,5 @@ import { Answerable, AnswersQuestions, d, Interaction, UsesAbilities } from '@serenity-js/core';
         const element = await this.resolve(actor, this.pageElement);
-        return element.doubleClick();
+        await element.scrollIntoView();
+        await element.doubleClick();
     }
 }

src/screenplay/interactions/Hover.ts

@@ -76,4 +76,5 @@ import { Answerable, AnswersQuestions, d, Interaction, UsesAbilities } from '@serenity-js/core';
         const element = await this.resolve(actor, this.element);
-        return element.hoverOver();
+        await element.scrollIntoView();
+        await element.hoverOver();
     }
 }

src/screenplay/interactions/RightClick.ts

@@ -8,3 +8,3 @@ import { Answerable, AnswersQuestions, d, Interaction, UsesAbilities } from '@serenity-js/core';
  * Instructs an {@apilink Actor|actor} who has the {@apilink Ability|ability} to {@apilink BrowseTheWeb}
- * to perfom a right click on a given {@apilink PageElement}.
+ * to perform a right click on a given {@apilink PageElement}.
  *
@@ -91,4 +91,5 @@ * This is typically used to open a [custom context menu](https://developer.mozilla.org/en-US/docs/Web/API/Element/click_event)
         const element = await this.resolve(actor, this.pageElement);
-        return element.rightClick();
+        await element.scrollIntoView();
+        await element.rightClick();
     }
 }

src/screenplay/interactions/Scroll.ts

@@ -7,3 +7,3 @@ import { Answerable, AnswersQuestions, d, Interaction, UsesAbilities } from '@serenity-js/core';
  * Instructs an {@apilink Actor|actor} who has the {@apilink Ability|ability} to {@apilink BrowseTheWeb}
- * to scroll until a given Web element comes into view.
+ * to scroll until a given {@apilink PageElement} comes into view.
  *
@@ -74,5 +74,4 @@ * ## Example widget
         const target = await actor.answer(this.element);
-
-        return target.scrollIntoView();
+        await target.scrollIntoView();
     }
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

673561

increased by0.1%

Lines of code

14599

increased by0.04%

Dependency changes

• + Added@serenity-js/assertions@3.1.3(transitive)

• + Added@serenity-js/core@3.1.3(transitive)

• - Removed@serenity-js/assertions@3.1.2(transitive)

• - Removed@serenity-js/core@3.1.2(transitive)

• Updated@serenity-js/assertions@3.1.3

• Updated@serenity-js/core@3.1.3