@serialport/binding-abstract - npm Package Compare versions

Comparing version 3.0.0 to 8.0.1

binding-abstract.js

@@ -88,8 +88,8 @@ const debug = require('debug')('serialport/binding-abstract')
 
-    if (typeof offset !== 'number') {
-      throw new TypeError('"offset" is not an integer')
+    if (typeof offset !== 'number' || isNaN(length)) {
+      throw new TypeError(`"offset" is not an integer got "${isNaN(length) ? 'NaN' : typeof offset}"`)
     }
 
-    if (typeof length !== 'number') {
-      throw new TypeError('"length" is not an integer')
+    if (typeof length !== 'number' || isNaN(length)) {
+      throw new TypeError(`"length" is not an integer got "${isNaN(length) ? 'NaN' : typeof length}"`)
     }
@@ -123,2 +123,4 @@
     if (!this.isOpen) {
+      debug('write', 'error port is not open')
+
       throw new Error('Port is not open')
@@ -125,0 +127,0 @@ }

CHANGELOG.md

@@ -6,8 +6,14 @@ # Change Log
 
-# [3.0.0](https://github.com/node-serialport/node-serialport/compare/@serialport/binding-abstract@2.0.5...@serialport/binding-abstract@3.0.0) (2019-05-16)
+## [8.0.1](https://github.com/serialport/node-serialport/compare/v6.2.2...v8.0.1) (2019-09-18)
 
 
+### Bug Fixes
+
+* bindings now error when closed during empty writes ([#1872](https://github.com/serialport/node-serialport/issues/1872)) ([9d01492](https://github.com/serialport/node-serialport/commit/9d01492))
+* stream read not working past 1 read ([#1925](https://github.com/serialport/node-serialport/issues/1925)) ([3a13279](https://github.com/serialport/node-serialport/commit/3a13279))
+
+
 ### chore
 
-* remove node6 support and upgrade codebase ([#1851](https://github.com/node-serialport/node-serialport/issues/1851)) ([d4f15c0](https://github.com/node-serialport/node-serialport/commit/d4f15c0))
+* remove node6 support and upgrade codebase ([#1851](https://github.com/serialport/node-serialport/issues/1851)) ([d4f15c0](https://github.com/serialport/node-serialport/commit/d4f15c0))
 
@@ -23,4 +29,20 @@
 
-## [2.0.5](https://github.com/node-serialport/node-serialport/compare/@serialport/binding-abstract@2.0.4...@serialport/binding-abstract@2.0.5) (2019-04-27)
+# [3.0.0](https://github.com/serialport/node-serialport/compare/@serialport/binding-abstract@2.0.5...@serialport/binding-abstract@3.0.0) (2019-05-16)
 
+
+### chore
+
+* remove node6 support and upgrade codebase ([#1851](https://github.com/serialport/node-serialport/issues/1851)) ([d4f15c0](https://github.com/serialport/node-serialport/commit/d4f15c0))
+
+
+### BREAKING CHANGES
+
+* bindings now use async functions so they’ll never throw, only reject
+
+
+
+
+
+## [2.0.5](https://github.com/serialport/node-serialport/compare/@serialport/binding-abstract@2.0.4...@serialport/binding-abstract@2.0.5) (2019-04-27)
+
 **Note:** Version bump only for package @serialport/binding-abstract
@@ -32,3 +54,3 @@
 
-## [2.0.4](https://github.com/node-serialport/node-serialport/compare/@serialport/binding-abstract@2.0.3...@serialport/binding-abstract@2.0.4) (2019-01-08)
+## [2.0.4](https://github.com/serialport/node-serialport/compare/@serialport/binding-abstract@2.0.3...@serialport/binding-abstract@2.0.4) (2019-01-08)
 
@@ -41,3 +63,3 @@ **Note:** Version bump only for package @serialport/binding-abstract
 
-## [2.0.3](https://github.com/node-serialport/node-serialport/compare/@serialport/binding-abstract@2.0.2...@serialport/binding-abstract@2.0.3) (2018-12-19)
+## [2.0.3](https://github.com/serialport/node-serialport/compare/@serialport/binding-abstract@2.0.2...@serialport/binding-abstract@2.0.3) (2018-12-19)
 
@@ -50,3 +72,3 @@ **Note:** Version bump only for package @serialport/binding-abstract
 
-## [2.0.2](https://github.com/node-serialport/node-serialport/compare/@serialport/binding-abstract@2.0.1...@serialport/binding-abstract@2.0.2) (2018-11-27)
+## [2.0.2](https://github.com/serialport/node-serialport/compare/@serialport/binding-abstract@2.0.1...@serialport/binding-abstract@2.0.2) (2018-11-27)
 
@@ -60,3 +82,3 @@ **Note:** Version bump only for package @serialport/binding-abstract
 <a name="2.0.1"></a>
-## [2.0.1](https://github.com/node-serialport/node-serialport/compare/@serialport/binding-abstract@2.0.0...@serialport/binding-abstract@2.0.1) (2018-08-29)
+## [2.0.1](https://github.com/serialport/node-serialport/compare/@serialport/binding-abstract@2.0.0...@serialport/binding-abstract@2.0.1) (2018-08-29)
 
@@ -63,0 +85,0 @@ **Note:** Version bump only for package @serialport/binding-abstract

package.json

 {
   "name": "@serialport/binding-abstract",
-  "version": "3.0.0",
+  "version": "8.0.1",
   "main": "binding-abstract.js",
@@ -20,5 +20,5 @@ "keywords": [
     "type": "git",
-    "url": "git://github.com/node-serialport/node-serialport.git"
+    "url": "git://github.com/serialport/node-serialport.git"
   },
-  "gitHead": "524a2729003a94c9575904448d878a151f4f3790"
+  "gitHead": "eae28d4a00df1cc44e054acd34b530377cdc62c6"
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

18988

increased by5.1%

Lines of code

193

increased by0.52%

No dependency changes